pzakha approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/311#pullrequestreview-43302566
--
openzfs-developer
pzakha requested changes on this pull request.
> vdev_dbgmsg(vd, "vdev_disk_open: invalid "
"vdev_devid '%s'", vd->vdev_devid);
- return (SET_ERROR(EINVAL));
+ dvd->vd_devid = NULL;
+
pzakha approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/526#pullrequestreview-89849486
--
openzfs-developer
pzakha approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/537#pullrequestreview-94794188
--
openzfs-developer
pzakha commented on this pull request.
> @@ -461,6 +461,16 @@ kernel_fini(void)
system_taskq_fini();
}
+/* ARGSUSED */
+uint32_t
+zone_get_hostid(void *zonep)
I'll need to look into it. It seems like `zone_get_hostid()` has a behaviour
specific to libzpool as the value returned
pzakha commented on this pull request.
> @@ -461,6 +461,16 @@ kernel_fini(void)
system_taskq_fini();
}
+/* ARGSUSED */
+uint32_t
+zone_get_hostid(void *zonep)
After further investigation I'd propose to keep this in `libzpool` as the
generic `libfakekernel` implementation should
pzakha approved this pull request.
Great changes!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/688#pullrequestreview-150579785
--
openzfs:
pzakha approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/677#pullrequestreview-155965770
--
openzfs:
Note that there was a complementary change that was pushed a few months ago to
deal with un-parseable devids: https://github.com/openzfs/openzfs/pull/605.
It doesn't directly address the problem of swapped devids but the upside of
that approach is that it allows to import a pool without
