[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)

brad-lewis approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/407#pullrequestreview-49254397 -- openzfs-developer

[developer] Re: [openzfs/openzfs] 8166 zpool scrub thinks it repaired offline device (#372)

brad-lewis approved this pull request. Looks good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/372#pullrequestreview-38781210 -- openzfs

[developer] Re: [openzfs/openzfs] 0000 arc_reclaim_thread has 2 jobs (#486)

brad-lewis approved this pull request. Looks good. I noted a few nits with extra tabs that could be removed. > @@ -282,10 +283,11 @@ boolean_t arc_watch = B_FALSE; int arc_procfd; #endif -static kmutex_tarc_reclaim_lock; -static kcondvar_t arc_reclaim_thread_cv; -sta

[developer] Re: [openzfs/openzfs] 9255 obsolete_counts feature should be documented in zpool-features.5… (#584)

Closed #584. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/584#event-1618419096 -- openzfs: openzfs-developer Permalink:

[developer] Re: [openzfs/openzfs] 9433 Fix ARC hit rate (#606)

brad-lewis requested changes on this pull request. > + * which otherwise would be skipped for entries in the dbuf cache. + */ +void +arc_buf_access(arc_buf_t *buf) +{ + mutex_enter(>b_evict_lock); + arc_buf_hdr_t *hdr = buf->b_hdr; + + /* +* Avoid taking the

[developer] [openzfs/openzfs] 9617 too-frequent TXG sync causes excessive write inflation (#655)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Brad Lewis Reviewed by: George Wilson ZFS starts syncing a TXG if there's 64MB of dirty data. This can result in very short TXG syncs, which can be inefficient because the ratio of metadata to user data is poor. Typically, this is not a real

[developer] [openzfs/openzfs] 9577 remove zfs_dbuf_evict_key tsd (#645)

Reviewed by: George Wilson Reviewed by: Serapheim Dimitropoulos The zfs_dbuf_evict_key TSD (thread-specific data) is not necessary - we can instead pass a flag down in a few places to prevent recursive dbuf eviction. Making this change has 3 benefits: 1. The code semantics are easier to

[developer] [openzfs/openzfs] 9077 zloop misses core files because they're no longer written into cwd (#540)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Prakash Surya To make zloop for resilient to coreadm configuration differences on the various illumos distributions, we should enable per process core dumps at the start of zloop. Upstream bug:

[developer] [openzfs/openzfs] 9192 explicitly pass good_writes to vdev_uberblock/label_sync (#568)

Reviewed by: Pavel Zakharov Reviewed by: George Wilson Currently vdev_label_sync and vdev_uberblock_sync take a zio_t and assume that its io_private is a pointer to the good_writes count. They should instead accept this argument explicitly.

[developer] [openzfs/openzfs] 9190 Fix cleanup routine in import_cachefile_device_replaced.ksh (#566)

Reviewed by: Dan Kimmel Reviewed by: John Kennedy Must clear slow-disk zinject injections in test cleanup routine. Otherwise, when this test fails, it causes most subsequent tests to fail. Upstream bug: DLPX-48060 You can view, comment on, or

[developer] [openzfs/openzfs] 9191 dump vdev tree to zfs_dbgmsg when spa load fails due to missing … (#567)

…log devices Reviewed by: George Wilson Reviewed by: Prakash Surya Reviewed by: Matt Ahrens Add vdev_print_tree() in spa_check_for_missing_logs() when some log devices are missing to ease debugging Upstream bug:

[developer] [openzfs/openzfs] 9193 bootcfg -C doesn't work (#569)

Reviewed by: Name Chris Williamson Reviewed by: Name Sebastien Roy When given an empty string as a rootds value, bootcfg -C fails with the error message 'could not set nextboot: '' is an invalid name'. This should be allowed because it

[developer] [openzfs/openzfs] 9187 racing condition between vdev label and spa_last_synced_txg in v… (#563)

…dev_validate Reviewed by: George Wilson Reviewed by: Matt Ahrens ztest failed with uncorrectable IO error despite having the fix for #7163. Both sides of the mirror have CANT_OPEN_BAD_LABEL, which also distinguishes it from that issue.

[developer] [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Prakash Surya There should be a mechanism to override the ashift reported by the underlying devices, at pool creation time. For now, it will be a global tunable. Upstream bug: DLPX-50992 You

[developer] [openzfs/openzfs] 9188 increase size of dbuf cache to reduce indirect block decompression (#564)

Reviewed by: Dan Kimmel Reviewed by: Prashanth Sreenivasa Reviewed by: Paul Dagnelie With compressed ARC (bug #6950) we use up to 25% of our CPU to decompress indirect blocks, under a workload of random cached reads. To reduce this

[developer] [openzfs/openzfs] 9189 Add debug to vdev_label_read_config when txg check fails (#565)

Reviewed by: George Wilson Reviewed by: Prashanth Sreenivasa These changes were added to help debug issue #9187. Essentially, in the original bug, vdev_validate() seems to fails in vdev_label_read_config() and prints "failed reading config". This

[developer] [openzfs/openzfs] 9195 New coreadm config causes failure in zpool_003_pos (#571)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Dan Kimmel dan.kim...@delphix.com If a core file is not created in the cwd the test fails. The solution is to invoke `coreadm -i core` just before running this test. Also included are Makefile changes in zfstest cannot

[developer] [openzfs/openzfs] 9186 performance test suite should use checksum=edonr (#572)

Reviewed by: Paul Dagnelie Reviewed by: Dan Kimmel Reviewed by: John Kennedy The zfs performance test suite should be using checksum=edonr. Upstream bug: DLPX-50672 You can view, comment on, or merge this pull request online

[developer] [openzfs/openzfs] 9691 fat zap should prefetch when iterating (#682)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Pavel Zakharov Reviewed by: George Wilson When iterating over a ZAP object, we're almost always certain to iterate over the entire object. If there are multiple leaf blocks, we can realize a performance win by issuing reads for all the leaf

[developer] Re: [openzfs/openzfs] 9678 ZFS panic when cancelling removal with Log Spacemap feature enabled (#672)

See Matt's comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/672#issuecomment-408173187 -- openzfs: openzfs-developer Permalink:

[developer] Re: [openzfs/openzfs] 9678 ZFS panic when cancelling removal with Log Spacemap feature enabled (#672)

Closed #672. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/672#event-1755591899 -- openzfs: openzfs-developer Permalink:

[developer] [openzfs/openzfs] 9678 ZFS panic when cancelling removal with Log Spacemap feature enabled (#672)

Reviewed by: Matt Ahrens Reviewed by: Prashanth Sreenivasa Reviewed by: John Kennedy This panic was hit three times during device removal tests: vdev_indirect_mark_obsolete+0xc8(ff03885a6000, 20003000, 800) free_mapped_segment_cb+0x2e(ff03885a6000, 20003000, 800)

[developer] [openzfs/openzfs] 9680 dsl_dataset_hold_obj can leak bookmarks (#674)

Reviewed by: Matt Ahrens Reviewed by: Prakash Surya During the analysis of a hang we were able to discovery that during calls to dsl_dataset_hold_obj we could call dsl_bookmark_init_ds which would allocate the DSL's ds_bookmarks AVL tree. If we have multiple threads trying to instantiate

[developer] [openzfs/openzfs] 9679 Race condition in mountd sharetab logic (#673)

Reviewed by: Sebastien Roy Reviewed by: Pavel Zakharov Reviewed by: Serapheim Dimitropoulos This bug presented itself with /temp filesystem of some databases failing to mount. It turns out that mountd doesn't think the filesystem is in the sharetab, so it refuses to allow the remote system

[developer] [openzfs/openzfs] 9683 Allow bypassing devid in vdev_disk_open() (#677)

Reviewed by: Sara Hartse Reviewed by: George Wilson We've had 2 cases where the devids of disks were shuffled, preventing domain0 from being imported, which required a tedious manual process to zero-out devids through kmdb during zpool import. This feature would add a tunable to

[developer] [openzfs/openzfs] 9681 ztest failure in spa_history_log_internal due to spa_rename() (#676)

Reviewed by: Prakash Surya Reviewed by: Serapheim Dimitropoulos A recent test failed while running ztest, and produced the following result: 05/01 10:25:22 ztest -V -m 2 -r 0 -R 1 -v 2 -a 9 -T 43 -P 11 -s 128m -f /var/tmp/os-ztest zloop finished, 1 crashes found running: cat ztest.cores

[developer] [openzfs/openzfs] 9682 page fault in dsl_async_clone_destroy() while opening pool (#675)

Reviewed by: Brad Lewis Reviewed by: Matt Ahrens Reviewed by: Sara Hartse While running the zfs test suite for an unrelated change, I observed a crash. The problem is that when we are opening the pool, spa_load_impl() calls dmu_objset_find(dsl_destroy_inconsistent) before calling

[developer] [openzfs/openzfs] 9688 aggsum_fini leaks memory (#679)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Matt Ahrens Reviewed by: Prashanth Sreenivasa aggsum_fini() does not free as_buckets. It should do so. Upstream bug: DLPX-58607 You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/679 --

[developer] [openzfs/openzfs] 9690 metaslab of vdev with no space maps was flushed during removal (#681)

Reviewed by: Matt Ahrens Reviewed by: Brad Lewis While running zloop, this assertion was hit: assertion failed for thread 0xfd7ffe64a240, thread-id 334: dn->dn_phys->dn_type || dn->dn_allocated_txg, file ../../../uts/common/fs/zfs/dnode.c, line 1327 libc.so.1`_lwp_kill+0xa()

[developer] [openzfs/openzfs] 9689 zfs range lock code should not be zpl-specific (#680)

Reviewed by: Serapheim Dimitropoulos Reviewed by: George Wilson The ZFS range locking code in zfs_rlock.c/h depends on ZPL-specific data structures, specifically znode_t. However, it's also used by the ZVOL code, which uses a "dummy" znode_t to pass to the range locking code. We should clean

[developer] [openzfs/openzfs] 9675 memory leak from cpupart_create (#669)

Reviewed by: George Wilson Reviewed by: Pavel Zakharov In usr/src/uts/common/disp/cpupart.c, cpupart_create() allocates a buffer and assigns it to the cp_lgrploads member of a cpupart_t struct: pp->cp_nlgrploads = lgrp_plat_max_lgrps(); pp->cp_lgrploads = kmem_zalloc(sizeof (lpl_t) *

[developer] [openzfs/openzfs] 9676 mdb's ::stacks command can loop forever (#670)

Reviewed by: Brad Lewis Reviewed by: Prakash Surya Reviewed by: Paul Dagnelie Problem mdb's ::stacks dcmd can loop forever if it encounters a bad frame pointer that points to itself. Solution Check that the stack grows in the direction expected. For platforms like x86 where the stack grows

[developer] [openzfs/openzfs] 9425 allow channel programs to be stopped via signals (#668)

Reviewed by: Sebastien Roy Reviewed by: Serapheim Dimitropoulos Reviewed by: Matt Ahrens Problem Statement ZFS Channel program scripts currently require a timeout, so that hung or long-running scripts return a timeout error instead of causing ZFS to get wedged. This limit can currently be

[developer] [openzfs/openzfs] 8601 memory leak in get_special_prop() (#667)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Sara Hartse Reviewed by: Pavel Zakharov Reviewed by: Matt Ahrens after running "zfstest" and then using "reboot -d" and "::findleaks", there's a couple of leaks like the following: kmem_alloc_8 leak: 2 buffers, 8 bytes each, 16 bytes total

[developer] Re: [openzfs/openzfs] 9194 mechanism to override ashift at pool creation time (#570)

brad-lewis commented on this pull request. > @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd) vd->vdev_asize = asize; vd->vdev_max_asize = max_asize; vd->vdev_ashift = MAX(ashift, vd->vdev_ashift); + vd->

[developer] Re: [openzfs/openzfs] nuke spa_dbgmsg (#580)

@brad-lewis pushed 1 commit. 6a011e2 9236 nuke spa_dbgmsg -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/580/files/b2e7f36afc829bb3e9ac87f479fab2e213f41a6e..6a011e28705ad106f2a2809be864d58db95bbe05

[developer] Re: [openzfs/openzfs] nuke spa_dbgmsg (#580)

@brad-lewis pushed 1 commit. 8d8a566 9236 nuke spa_dbgmsg -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/580/files/9e6bd4e52120bc9b0a0176656bf8753b7c121e5c..8d8a56690529bd2addca6c6602ee0ea1e1bbb8b3

[developer] [openzfs/openzfs] 9280 Assertion failure while running removal_with_ganging test with 4… (#588)

…K devices Reviewed by: George Wilson Reviewed by: John Kennedy We hit a panic in the removal_with_ganging test using vdevs with 4k ashift for testing. The problem is that the test intentionally induces ganging in allocations as small as

[developer] [openzfs/openzfs] 9255 obsolete_counts feature should be documented in zpool-features.5… (#584)

… manpage Reviewed by: Sebastien Roy Reviewed by: Serapheim Dimitropoulos Reviewed by: Steve Gonczi This is part of device removal that should be documented. Upstream bug: DLPX-47652 You can view, comment on,

[developer] [openzfs/openzfs] 9256 zfs send space estimation off by > 10% on some datasets (#585)

Reviewed by: Matt Ahrens Reviewed by: John Kennedy Here is an instance where we see a big discrepancy. estimate is : 431217656 bytes actual size is : 492215048 bytes Without the -e flag, the discrepancy is much higher. Upstream bug: DLPX-45514 You

[developer] [openzfs/openzfs] 9245 zfs-test failures: slog_013_pos and slog_014_pos (#583)

Reviewed by: Matt Ahrens Reviewed by: Chris Williamson Test 13 would fail because of attempts to zpool destroy -f a pool that was still busy. Changed those calls to destroy_pool which does a retry loop, and the problem is no longer reproducible.

[developer] [openzfs/openzfs] DLPX-39390 metaslab size can exceed offset addressable by spacemap (#608)

Reviewed by: Paul Dagnelie Reviewed by: Matt Ahrens metaslab size can exceed offset addressable by spacemap. The vdev can address up to 2^63 * SPA_MAXBLOCKSIZE (512). A metaslab can address up to 2^47 * 2^vdev_ashift. Therefore we may need to increase the

[developer] [openzfs/openzfs] 9442 decrease indirect block size of spacemaps (#609)

Reviewed by: Serapheim Dimitropoulos Reviewed by: George Wilson Updates to indirect blocks of spacemaps can contribute significantly to write inflation. Therefore we want to reduce the indirect block size of spacemaps from 128K to 16K.

[developer] [openzfs/openzfs] 9443 panic when scrub a v10 pool (#610)

Reviewed by: Serapheim Dimitropoulos Reviewed by: George Wilson While expanding stored pools, we ran into a panic using an old pool. Steps to reproduce: jkennedy-origin% sudo zpool create -o version=2 test c2t1d0 jkennedy-origin% sudo

[developer] [openzfs/openzfs] 9456 ztest failure in zil_commit_waiter_timeout (#613)

Reviewed by: Matt Ahrens Reviewed by: Serapheim Dimitropoulos Problem Illumos bug 8373 was integrated, which now presents a code path where "dmu_tx_assign" can fail. When "dmu_tx_assign" fails, it will not issue the lwb that was passed in to

[developer] [openzfs/openzfs] 9463 zloop warns that "sudo: command not found" (#615)

At the start of the zloop logs we find a warning that states "/bin/zloop: line 150: sudo: command not found". /bin/zloop: line 150: sudo: command not found Upstream bug: DLPX-52252 You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/615 --

[developer] [openzfs/openzfs] 9464 txg_kick() fails to see that we are quiescing, forcing transacti… (#616)

…ons to their next stages without leaving them accumulate changes Reviewed by: Matt Ahrens <m...@delphix.com> Reviewed by: Brad Lewis <brad.le...@delphix.com> Creating a fragmented pool in a DCenter VM and continuously writing to it with multiple instances of randwritecomp, we get t

[developer] [openzfs/openzfs] 9454 ::zfs_blkstats should count embedded blocks and 9443 panic when scrub a v10 pool (#618)

You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/618 -- Commit Summary -- * 9454 ::zfs_blkstats should count embedded blocks * 9443 panic when scrub a v10 pool -- File Changes -- M usr/src/uts/common/fs/zfs/dsl_scan.c (13) --

[developer] [openzfs/openzfs] 9465 ARC check for 'anon_size > arc_c/2' can stall the system (#617)

Reviewed by: Sebastien Roy Reviewed by: Matt Ahrens Reviewed by: Prashanth Sreenivasa Seen in a test suite run of checkpoint_big_rewind which uses a nested pool. Does not appear to reproduce easily. Current theory is that the

[developer] Re: [openzfs/openzfs] dnode related bug fixes (#603)

Thanks Matt and Andy. I will close this request and try again with other relevant delphix commits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/603#issuecomment-379869565

[developer] Re: [openzfs/openzfs] dnode related bug fixes (#603)

Closed #603. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/603#event-1564629388 -- openzfs: openzfs-developer Permalink:

[developer] [openzfs/openzfs] 9338 moved dnode has incorrect dn_next_type and related fixes (#611)

This request is really a replacement for https://github.com/openzfs/openzfs/pull/603. The fix for 9338 is dependent on other fixes that are included here. Doing so eliminated the merging issues. You can view, comment on, or merge this pull request online at:

[developer] [openzfs/openzfs] 9457 libzfs_import.c:add_config() has a memory leak (#614)

Reviewed by: Matt Ahrens Reviewed by: Serapheim Dimitropoulos A memory leak occurs on lines 209 and 213 because the config is not freed in the error case. The interface to add_config() seems less than ideal - it would be better if it copied any

[developer] Re: [openzfs/openzfs] 9245 zfs-test failures: slog_013_pos and slog_014_pos (#583)

brad-lewis commented on this pull request. > @@ -1675,6 +1675,26 @@ function is_pool_removed #pool return $? } +function wait_for_degraded +{ + typeset pool=$1 + typeset timeout=${2:-30} + typeset t0=$SECONDS + + while :; do + zpool status

[developer] [openzfs/openzfs] 9403 assertion failed in arc_buf_destroy() when concurrently reading … (#601)

…block with checksum error Reviewed by: George Wilson Reviewed by: Paul Dagnelie Reviewed by: Pavel Zakharov This assertion (VERIFY) failure was reported when reading a block. Turns out the problem is that if we get an

[developer] [openzfs/openzfs] 9421 zdb should detect and print out the number of "leaked" objects (#604)

9422 zfs diff and zdb should explicitly mark objects that are on the deleted queue Reviewed by: Matt Ahrens Reviewed by: Pavel Zakharov It is possible for zfs to "leak" objects in such a way that they are not freed, but are also not accessible

[developer] [openzfs/openzfs] dnode related bug fixes (#603)

You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/603 -- Commit Summary -- * 9338 moved dnode has incorrect dn_next_type * 9339 ztest process hung remapping blocks from a removed vdev -- File Changes -- M

[developer] [openzfs/openzfs] 9330 stack overflow when creating a deeply nested dataset (#598)

Reviewed by: John Kennedy Reviewed by: Matt Ahrens Datasets that are deeply nested (~100 levels) are impractical. We just put a limit of 50 levels to newly created datasets. Existing datasets should work without a problem. The problem can be seen by

[developer] [openzfs/openzfs] Openzfs dlpx 45002 (#597)

You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/597 -- Commit Summary -- * 9328 zap code can take advantage of c99 * 9329 panic in zap_leaf_lookup() due to concurrent zapification -- File Changes -- M

[developer] Re: [openzfs/openzfs] 9326 nuke spa_dbgmsg (#580)

@brad-lewis pushed 1 commit. 9a4f19a Merge branch 'master' into openzfs-DLPX-49012 -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/580/files/8d8a56690529bd2addca6c6602ee0ea1e1bbb8b3

[developer] [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (#599)

Reviewed by: Prakash Surya Reviewed by: George Wilson This project's goal is to make read-heavy channel programs and zfs(1m) administrative commands faster by caching all the metadata that they will need in the dbuf layer. This will prevent

[developer] [openzfs/openzfs] DLPX-50219 reduce apic calibration error by taking multiple measurements (#578)

Reviewed by: George Wilson Reviewed by: Sebastien Roy Calibration of the APIC timer is currently performed by doing one mesurement at boot time. On some hypervisors, like Azure, the calibration can be quite off because timers are

[developer] [openzfs/openzfs] 9235 rename zpool_rewind_policy_t to zpool_load_policy_t (#579)

Reviewed by: Matt Ahrens Reviewed by: George Wilson We want to be able to pass various settings during import/open of a pool, which are not only related to rewind. Instead of adding a new policy and duplicate a bunch of code, we should just rename

[developer] [openzfs/openzfs] DLPX-49012 nuke spa_dbgmsg (#580)

Reviewed by: Serapheim Dimitropoulos Reviewed by: Pavel Zakharov Reviewed by: George Wilson We should use zfs_dbgmsg instead of spa_dbgmsg. Or at least, metaslab_condense() should call zfs_dbgmsg because

[developer] Re: [openzfs/openzfs] 9679 Race condition in mountd sharetab logic (#673)

brad-lewis commented on this pull request. > @@ -3104,18 +3103,23 @@ check_sharetab() } /* -* Remember the mod time, then after getting the -* write lock check again. If another thread -* already did the update, then there's no -* work to

[developer] Re: [openzfs/openzfs] 9680 dsl_dataset_hold_obj can leak bookmarks (#674)

Yes, I got ahead of myself in trying to upstream a group of delphix commits. Obviously we should back this out. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 9688 aggsum_fini leaks memory (#679)

@lundman, your analysis looks right on to me. I'm doing some further testing on a change similar to what you suggested. Sorry for the slow response. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 9688 aggsum_fini leaks memory (#679)

I switched the order of commands in arc_fini() to address the panic in arc_space_return. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/679#issuecomment-422248590