[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-13 Thread Prakash Surya
Merged #539. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/539#event-1472048156 -- openzfs-developer Archives:

[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-12 Thread Pavel Zakharov
pzakha commented on this pull request. > @@ -461,6 +461,16 @@ kernel_fini(void) system_taskq_fini(); } +/* ARGSUSED */ +uint32_t +zone_get_hostid(void *zonep) After further investigation I'd propose to keep this in `libzpool` as the generic `libfakekernel` implementation should

[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-12 Thread Pavel Zakharov
pzakha commented on this pull request. > @@ -461,6 +461,16 @@ kernel_fini(void) system_taskq_fini(); } +/* ARGSUSED */ +uint32_t +zone_get_hostid(void *zonep) I'll need to look into it. It seems like `zone_get_hostid()` has a behaviour specific to libzpool as the value returned

[developer] Re: [openzfs/openzfs] 9075 Improve ZFS pool import/load process and corrupted pool recovery (#539)

2018-02-10 Thread Andrew Stormont
andy-js commented on this pull request. Overall looks good. > +# +# We want to test the case where a whole created by a log device is filled +# by a regular device +# +function test_remove_log_then_add_vdev +{ + log_note "$0." + log_must zpool create -o cachefile=$CPATH $TESTPOOL1 \