[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

2018-05-01 Thread Prakash Surya
Closed #582 via 68fd0f19dedb96a20444f464246af332988587d8. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/582#event-1604096519 -- openzfs: openzf

[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

2018-04-15 Thread Andriy Gapon
@asomers , could you please push (and rebase before that) to trigger another build? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/582#issuecomment-381497292 -

[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

2018-03-16 Thread Matthew Ahrens
This looks good to go once we confirm that the tests pass. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/582#issuecomment-373844114 -- openzfs:

[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

2018-03-05 Thread Andriy Gapon
avg-I approved this pull request. Looked good for FreeBSD, still looks good. Thank you! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/582#pullrequestreview-101320066 --

[developer] Re: [openzfs/openzfs] 9237 "zpool add" fails for very large pools (#582)

2018-03-05 Thread Matthew Ahrens
ahrens approved this pull request. I'm not sure that this design of having callers check `errno` is the best, but your fix seems reasonable given how this is used. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://g