[developer] Re: [openzfs/openzfs] 9479 fix wrong format specifier for vdev_id (#623)

[Prakash Surya]

Closed #623 via 20aa447c1981d8a98f2607c1f99732bd4699fb56.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/623#event-1658699373
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/T2cb600ac138fbef6-M8d0debad3773fbd7af289c92
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] 9479 fix wrong format specifier for vdev_id (#623)

[Matthew Ahrens]

ahrens approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/623#pullrequestreview-112484917
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T2cb600ac138fbef6-M76975fd747ac8ece983e4db3
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] 9479 fix wrong format specifier for vdev_id (#623)

[Andriy Gapon]

avg-I commented on this pull request.



> @@ -159,7 +159,7 @@ vdev_dbgmsg_print_tree(vdev_t *vd, int indent)
}
 
zfs_dbgmsg("%*svdev %u: %s%s, guid: %llu, path: %s, %s", indent,
-   "", vd->vdev_id, vd->vdev_ops->vdev_op_type,
+   "", (int)vd->vdev_id, vd->vdev_ops->vdev_op_type,

I think that either can work, but just adding the int cast seemed like a 
simpler change.
And I cannot imagine a pool with billions of vdevs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/623#discussion_r181656256
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T2cb600ac138fbef6-Maaa8edcd2d14b8f7472706f2
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] 9479 fix wrong format specifier for vdev_id (#623)

[Steven Hartland]

stevenh requested changes on this pull request.



> @@ -159,7 +159,7 @@ vdev_dbgmsg_print_tree(vdev_t *vd, int indent)
}
 
zfs_dbgmsg("%*svdev %u: %s%s, guid: %llu, path: %s, %s", indent,
-   "", vd->vdev_id, vd->vdev_ops->vdev_op_type,
+   "", (int)vd->vdev_id, vd->vdev_ops->vdev_op_type,

zdb uses ```%llu``` with ```u_longlong_t```
Should we do that for consistency, which is also less risky given the 
definition of vdev_id?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/623#pullrequestreview-112307642
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T2cb600ac138fbef6-M47af2196b7d8633b309b833c
Delivery options: https://openzfs.topicbox.com/groups