[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-27 Thread Paul Dagnelie
pcd1193182 approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/656#pullrequestreview-132612380 -- openzfs:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-22 Thread Josh Paetzel
As far as I can tell this built fine and the issue was with the EC2 instances that the checks fire up. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/656#issuecomment-399626773

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-22 Thread Josh Paetzel
Thanks for the help, I've pushed the fix. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/656#issuecomment-399579575 -- openzfs:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-22 Thread Yuri Pankov
Any distribution using illumos-gate proper (which dilos isn't) -- omnios, openindiana. I'm not sure what version of mandoc FreeBSD ships. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-22 Thread Josh Paetzel
I guess my next question is: which OS is that command from? FreeBSD mandoc bails out with a macro error. OSX and DilOS don't have mandoc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-22 Thread Yuri Pankov
```mandoc -Tlint -Wwarning /zfs.1m``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/656#issuecomment-399514716 -- openzfs:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-22 Thread Josh Paetzel
Jenkins errors are: dmake: Warning: Command failed for target `man' dmake: Warning: Command failed for target `man1m' dmake: Warning: Command failed for target `zfs.1m.check' dmake: Warning: Target `check' not remade because of errors mandoc: zfs.1m:554:63: WARNING: new sentence, new line mandoc:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-21 Thread Andrew Stormont
andy-js approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/656#pullrequestreview-131002382 -- openzfs:

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

2018-06-21 Thread Matthew Ahrens
ahrens approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/656#pullrequestreview-130991711 -- openzfs: