[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Paul Dagnelie]

pcd1193182 approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#pullrequestreview-132612380
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/T12eb07a1de514d40-Mc092436d641f81c010ecc927
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Josh Paetzel]

As far as I can tell this built fine and the issue was with the EC2 instances 
that the checks fire up.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#issuecomment-399626773
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/T12eb07a1de514d40-M8dc699b5eb0188d34dbeae69
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Josh Paetzel]

Thanks for the help, I've pushed the fix.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#issuecomment-399579575
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/T12eb07a1de514d40-Mce144ec48d347d7dafee153c
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Yuri Pankov]

Any distribution using illumos-gate proper (which dilos isn't) -- omnios, 
openindiana.  I'm not sure what version of mandoc FreeBSD ships.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#issuecomment-399553316
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb0c0d1f1c824d904-M23482c14ecddf82ca7ce7784
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Josh Paetzel]

I guess my next question is: which OS is that command from?  FreeBSD mandoc 
bails out with a macro error.  OSX and DilOS don't have mandoc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#issuecomment-399537313
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb0c0d1f1c824d904-M753ab1e929bd1a86024c18bc
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Yuri Pankov]

```mandoc -Tlint -Wwarning /zfs.1m```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#issuecomment-399514716
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb0c0d1f1c824d904-M788adb543cf494dbf9f389fc
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Josh Paetzel]

Jenkins errors are:

dmake: Warning: Command failed for target `man'
dmake: Warning: Command failed for target `man1m'
dmake: Warning: Command failed for target `zfs.1m.check'
dmake: Warning: Target `check' not remade because of errors
mandoc: zfs.1m:554:63: WARNING: new sentence, new line
mandoc: zfs.1m:557:45: WARNING: new sentence, new line
mandoc: zfs.1m:592:18: WARNING: new sentence, new line
mandoc: zfs.1m:593:29: WARNING: new sentence, new line

What command is actually being run?  I'd like to verify a fix locally before 
throwing something over the wall.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#issuecomment-399510448
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb0c0d1f1c824d904-M68a20b50e2682a96bd44813d
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Andrew Stormont]

andy-js approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#pullrequestreview-131002382
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb0c0d1f1c824d904-M4a8652307d947f4f2dce5b2b
Delivery options: https://openzfs.topicbox.com/groups

[developer] Re: [openzfs/openzfs] Make createtxg and guid properties public (#656)

[Matthew Ahrens]

ahrens approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/656#pullrequestreview-130991711
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Tb0c0d1f1c824d904-M470e87210dbcb4cf66a22e9c
Delivery options: https://openzfs.topicbox.com/groups