[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
Closed #558 via 92b05f3a18ecbbd541fbd3d9746c173042e49a55. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#event-1533512554 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-M9f760c0e223ac4c70b32f18c Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
I opened https://www.illumos.org/issues/9321 and will RTI this today. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#issuecomment-374673338 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-Mda879d8de1bb054d502335ad Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
@allanjude Could you file an illumos bug for this? The content can be the same as your PR description. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#issuecomment-373845433 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-Me83258fee9a1311caa302645 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
Looks like the Jenkins test failed before it even started the build, can we get a rerun on this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#issuecomment-369118860 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-M7767e915b6b7f1897445053c Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
grwilson approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#pullrequestreview-99102002 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-M279a791a0241b69ede4f9bfe Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
@allanjude pushed 1 commit. 73ea8bd fixup! arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/558/files/ca78e6e459f4d99efb0fefbbc27b6087c238f296..73ea8bdac7bda12d48280f871ed23953bc80d42c -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-Mbfa8cbb12948c9acf5fff7fb Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
grwilson requested changes on this pull request. This change looks good, can you also change `arc_loan_buf` to mimic this change. I think we should always rely on `arc_buf_size` to determine the correct value to pass to `arc_loaned_bytes_update` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#pullrequestreview-99065653 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-Meb38a8a3ec5b5179e7015416 Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] arc_loan_compressed_buf() can increment arc_loaned_bytes by the wrong value (#558)
Sorry, missing step to the reproduction case: compressed arc must be disabled. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/558#issuecomment-366872279 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T396cc9871881f0d5-M20a36bea656ed782fbbe5369 Powered by Topicbox: https://topicbox.com
