Re: [Development] Removing the -c++11 option from configure

2015-03-25 Thread Oswald Buddenhagen
On Tue, Mar 24, 2015 at 01:23:25PM -0700, Thiago Macieira wrote: On Tuesday 24 March 2015 20:20:46 Oswald Buddenhagen wrote: And all for what? What do people gain by passing -no-c++11 today? they can (at least hypothetically) test their stuff with older language versions without

[Development] building the xcb platform plugin on OS X

2015-03-25 Thread René J . V . Bertin
Hi, I have been toying with the xcb platform on OS X (10.9; Qt 5.4.1), mostly because it's supposed to work. Surprisingly it does build without too much issues once one has the right combination of configure flags and installed dependencies, and even more surprisingly even OpenGL works (on a

Re: [Development] Removing the -c++11 option from configure

2015-03-25 Thread Matthew Woehlke
On 2015-03-24 15:04, Keith Gardner wrote: Why not make it a switch for highest language support. Instead of -no-c++11, make it -c++03. This would allow for adding -c++1z in the future without adding the -no-c++* all over. This will also handle the contradictory -c++03 and -c++14 being in

Re: [Development] Removing the -c++11 option from configure

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 10:12:41 Oswald Buddenhagen wrote: Aside from an option for the CI to test non- C++11, why do we need it? i think even that would be already a good enough reason. Ok, I'm convinced. But since I'm lazy, I'll just swap the option around: -force-c++98

[Development] Heads-up: new headersclean is going in soon

2015-03-25 Thread Thiago Macieira
[See thread A better headersclean test] The alpha is out and all the dependencies are in. I will try staging the new headersclean during tonight's night in Europe so as to avoid disruption. I anticipate at least one failure with some compiler combination I haven't tried in qtbase or

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Mandeep Sandhu
Is git stripspace or grep malfuncitoning? 'git stripspace' seems to be working fine. $ cat COMMIT_EDITMSG | git stripspace produces contents of COMMIT_EDITMSG Although the commit-msg script seems to be exiting early in add_ChangeId()... snip MSG=$1 # Check for, and add if missing, a

[Development] No Change-Id being generated for commit message

2015-03-25 Thread Mandeep Sandhu
Hi All, I'm having trouble pushing a change. 'git push' failed stating that the commit message was missing the Change-Id field. I had this working until recently when I moved my setup toa different machine. So something likely got screwed-up. I have the commit-msg hook installed in my repo's

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 17:36:58 Mandeep Sandhu wrote: Hi All, I'm having trouble pushing a change. 'git push' failed stating that the commit message was missing the Change-Id field. I had this working until recently when I moved my setup toa different machine. So something likely got

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 18:02:08 Mandeep Sandhu wrote: It doesn't show up. $ grep Change-Id: .git/COMMIT_EDITMSG $ .git/hooks/commit-msg .git/COMMIT_EDITMSG $ grep Change-Id: .git/COMMIT_EDITMSG Then the script chose not to add it. Try to debug it. Check if gerrit.createChangeId is set

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Mandeep Sandhu
Hi Thiago, How are you committing? If you're using Qt Creator's integrated commit editor, I use the commandline. sure that the script works. To do that, check that your .git/COMMIT_EDITMSG I verified this. .git/COMMIT_EDITMSG does not have Change-Id string. file does not contain a

Re: [Development] [Mac] tst_qquickwindow::testWindowVisibilityOrder() regression

2015-03-25 Thread Aaron McCarthy
On Thu, 19 Mar 2015 10:00:37 Pocheptsov Timur wrote: For me this test fails with 5.4 and passes with 5.5, so something was fixed :) (the test code is the same, of course). Has there been any progress on this? I haven't seen any relevant commits in either qtbase or qtdeclarative. This failure

Re: [Development] No Change-Id being generated for commit message

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 18:53:18 Mandeep Sandhu wrote: I'm not sure, but is that a valid sed expression (with all the white-spaces in-between)? Yes. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Heads-up: new headersclean is going in soon

2015-03-25 Thread Thiago Macieira
On Wednesday 25 March 2015 14:07:59 Thiago Macieira wrote: The alpha is out and all the dependencies are in. I will try staging the new headersclean during tonight's night in Europe so as to avoid disruption. I anticipate at least one failure with some compiler combination I haven't tried in