Re: [Development] Fwd: [Qt bugreports] (QTBUG-46505) assertion failure (=> crash) in harfbuzz-shaper

2015-06-05 Thread Thiago Macieira
On Friday 05 June 2015 21:45:37 René J.V. Bertin wrote: > Hi, > > As asked in the bug report below: is it necessary to handle this situation > with an assert/abort, instead of simply returning (with whatever error the > void function in question can return)? The assert is inside HB, so it's not o

Re: [Development] Qt 5.5.0 header diff: QtDBus.diff

2015-06-05 Thread Thiago Macieira
On Friday 05 June 2015 10:10:48 Frederik Gladhorn wrote: > Looks fine. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org http://lists.

Re: [Development] Qt 5.5.0 header diff

2015-06-05 Thread Thiago Macieira
On Thursday 04 June 2015 15:29:10 Frederik Gladhorn wrote: > Found module QtWinExtras in /home/frederik/dev/qt/qt-src- > dev//qtwinextras/src/winextras/winextras.pro > - No public headers for module QtWinExtras Note that the script only checks the modules that your qmake actually ran on. So QtWi

Re: [Development] Q_OBJECT and "override"

2015-06-05 Thread Thiago Macieira
On Thursday 04 June 2015 17:02:52 Christian Kandeler wrote: > On 06/04/2015 04:52 PM, Konstantin Ritt wrote: > > #define Q_OBJECT \ > > > > public: \ > > > > Q_OBJECT_CHECK \ > > > > QT_WARNING_PUSH \ > > > > Q_OBJECT_NO_OVERRIDE_WARNING \ > > > > stati

Re: [Development] date/time adjust for (auto) testing

2015-06-05 Thread Thiago Macieira
On Wednesday 03 June 2015 08:00:54 Curtis Mitch wrote: > Sounds like a great thing to have if you can get it working. The QDateTime > tests themselves would benefit from this quite a lot. > > Perhaps you've already seen, but it looks like Thiago attempted something > similar with a8c74ddcf78604c90

Re: [Development] date/time adjust for (auto) testing

2015-06-05 Thread Thiago Macieira
On Wednesday 03 June 2015 08:38:48 André Somers wrote: > Hi, > > We have applications that use the current date and time at places spread > around the code. For normal operations, that works very nicely. However, > we find that for (auto) testing, it would be very convenient if we could > trick th

Re: [Development] Qt 4.8.6 win32-msvc2008 compilation. error LNK2001: unresolved external symbol __imp__q_atomic_increment

2015-06-05 Thread Thiago Macieira
On Wednesday 03 June 2015 08:20:23 Soraya Santana de la Fe wrote: > I have found the problem and why QT_ARCH_WINDOWS was not defined. I was > using a diferent folder for my includes, comming from a linux compilation > instead the one generated by the "make install" command of my new windows > compi

[Development] Fwd: [Qt bugreports] (QTBUG-46505) assertion failure (=> crash) in harfbuzz-shaper

2015-06-05 Thread René J . V . Bertin
Hi, As asked in the bug report below: is it necessary to handle this situation with an assert/abort, instead of simply returning (with whatever error the void function in question can return)? Thanks, René -- Forwarded Message -- Subject: [Qt bugreports] (QTBUG-46505) assert

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread René J . V . Bertin
On Friday June 05 2015 18:18:28 Sean Harmer wrote: >But you did ask in a branch of a thread about a Qt3D change, so I >answered with respect to the part that I have knowledge about. That wasn't evident to me from the thread's subject :) >I was asking because I'm genuinely curious about the answ

Re: [Development] Qt 5.5.0 header diff: QtGui.diff

2015-06-05 Thread Sean Harmer
The OpenGL changes within QtGui look sane to me. Thanks for generating the diffs. Cheers, Sean On 05/06/2015 09:10, Frederik Gladhorn wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/devel

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread Edward Sutton
>Given recent OS X updates are free do you really need support for anything >older? Supporting only OS X 10.8 and newer is reasonable IMO. There are many good and usable Apple computers that will unfortunately live on OS X 10.8 until they die. Anything older than this can never be updated to

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread Sean Harmer
On 05/06/2015 19:07, René J.V. Bertin wrote: > On Friday June 05 2015 18:00:42 Sean Harmer wrote: > >>> What is the earliest OS X version on which 5.5 is supposed to work, >>> officially? >> For Qt3D, 10.8 is the oldest version handled by the CI. Given recent OS > I didn't ask about Qt3D?? But yo

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread René J . V . Bertin
On Friday June 05 2015 18:00:42 Sean Harmer wrote: > > What is the earliest OS X version on which 5.5 is supposed to work, > > officially? > > For Qt3D, 10.8 is the oldest version handled by the CI. Given recent OS I didn't ask about Qt3D?? > X updates are free do you really need support for

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread Sean Harmer
On 05/06/2015 14:52, René J.V. Bertin wrote: > On Friday June 05 2015 13:30:58 Sean Harmer wrote: > >>> could QTBUG-46143 possibly be added to the list of blockers? it is a P1 >>> bug in qt3d/qt5.5, as it does not build against the macos10.8 sdk. >> A day later than promised... >> >> https://codere

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread René J . V . Bertin
On Friday June 05 2015 13:30:58 Sean Harmer wrote: > > could QTBUG-46143 possibly be added to the list of blockers? it is a P1 > > bug in qt3d/qt5.5, as it does not build against the macos10.8 sdk. > > A day later than promised... > > https://codereview.qt-project.org/#/c/113797/2 I presume tha

Re: [Development] Your actions needed, Qt5.5.0 RC & Final is nearing!

2015-06-05 Thread Sean Harmer
On Wednesday 03 Jun 2015 11:05:35 Tim Blechmann wrote: > > We are quite close to Qt 5.5.0 RC & final releases. Plan is to put RC > > out Thu 11.6.2015 & Final Tue 23.6.2015. To be able to keep the schedule > > we need to make sure all real blockers are fixed in RC so that it will > > be really RC &

Re: [Development] Qt 5.5.0 header diff

2015-06-05 Thread Giuseppe D'Angelo
Il 04/06/2015 15:29, Frederik Gladhorn ha scritto: I'll send mails in reply to this one with the diffs attached (that will take a while). I see that a ton of changes are simply style refactorings -- adding Q_DECL_OVERRIDE, dropping Q_NO_USING, moving Q_ENUMS to Q_ENUM. Any chance of getting

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-05 Thread Simon Hausmann
On Friday, June 05, 2015 10:11:30 AM Frederik Gladhorn wrote: > There's a bug in this diff: --- a/src/qml/qml/qqmlerror.h +++ b/src/qml/qml/qqmlerror.h @@ -68,8 +68,6 @@ public: const char *data() const; QByteArray dataByteArray() const; -QByteArray metaData(const QString &) cons

[Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/qml/debugger/qqmldebug.h b/src/qml/debugger/qqmldebug.h index 876d068..bb90c4f 100644 --- a/src/qml/debugger/qqmldebug.h +++ b/src/qml/debugger/qqmldebug.h @@ -35,6 +35,7 @@ #define QQMLDEBUG_H #include +#include QT_BEGIN_NAMESPACE @@ -42,6 +43,8 @@ QT_BEGIN_NAMESPACE s

[Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/network/access/qabstractnetworkcache.h b/src/network/access/qabstractnetworkcache.h index b563090..352daa9 100644 --- a/src/network/access/qabstractnetworkcache.h +++ b/src/network/access/qabstractnetworkcache.h @@ -37,6 +37,7 @@ #include #ifndef QT_NO_SSL #include +#include

[Development] Qt 5.5.0 header diff: QtBluetooth.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/bluetooth/qbluetooth.h b/src/bluetooth/qbluetooth.h index ebe546f..f448af0 100644 --- a/src/bluetooth/qbluetooth.h +++ b/src/bluetooth/qbluetooth.h @@ -58,6 +58,7 @@ public: InputOutputError, PoweredOffError, InvalidBluetoothAdapterError, +Unsuppo

[Development] Qt 5.5.0 header diff: QtSql.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/sql/kernel/qsql.h b/src/sql/kernel/qsql.h index 49377d4..c0f82df 100644 --- a/src/sql/kernel/qsql.h +++ b/src/sql/kernel/qsql.h @@ -58,7 +58,7 @@ template class QSqlDriverCreator : public QSqlDriverCreatorBase { public: -QSqlDriver *createObject() const { return new T; } +

[Development] Qt 5.5.0 header diff: QtXml.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/xml/dom/qdom.h b/src/xml/dom/qdom.h index 7c5dc7f..5a83659 100644 --- a/src/xml/dom/qdom.h +++ b/src/xml/dom/qdom.h @@ -229,29 +229,29 @@ public: QXmlSimpleReader(); virtual ~QXmlSimpleReader(); -bool feature(const QString& name, bool *ok = 0) const; -void setFe

[Development] Qt 5.5.0 header diff: QtScriptTools.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/scripttools/debugging/qscriptenginedebugger.h b/src/scripttools/debugging/qscriptenginedebugger.h index dfeac90..0286072 100644 --- a/src/scripttools/debugging/qscriptenginedebugger.h +++ b/src/scripttools/debugging/qscriptenginedebugger.h __

[Development] Qt 5.5.0 header diff: QtPrintSupport.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/printsupport/dialogs/qabstractprintdialog.h b/src/printsupport/dialogs/qabstractprintdialog.h index f3e865e..cf55cfa 100644 --- a/src/printsupport/dialogs/qabstractprintdialog.h +++ b/src/printsupport/dialogs/qabstractprintdialog.h @@ -58,18 +58,12 @@ public: #if defined(Q_OS_MAC)

[Development] Qt 5.5.0 header diff: QtOpenGL.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/opengl/qgl.h b/src/opengl/qgl.h index 482c215..8c55cff 100644 --- a/src/opengl/qgl.h +++ b/src/opengl/qgl.h @@ -398,7 +398,7 @@ public: const QFont & fnt = QFont()); void renderText(double x, double y, double z, const QString & str, co

[Development] Qt 5.5.0 header diff: QtQuick.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/quick/designer/designersupport.h b/src/quick/designer/designersupport.h index 59f0cf2..51fcef4 100644 --- a/src/quick/designer/designersupport.h +++ b/src/quick/designer/designersupport.h @@ -80,7 +80,7 @@ public: void releaseResources() Q_DECL_OVERRIDE; protected: -voi

[Development] Qt 5.5.0 header diff: QtWebSockets.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/websockets/qmaskgenerator.h b/src/websockets/qmaskgenerator.h index b8748c3..a155340 100644 --- a/src/websockets/qmaskgenerator.h +++ b/src/websockets/qmaskgenerator.h ___ Development mailing list Development@qt-project.org http://lists.q

[Development] Qt 5.5.0 header diff: QtX11Extras.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/x11extras/qtx11extrasglobal.h b/src/x11extras/qtx11extrasglobal.h index c30f1bb..e9614e7 100644 --- a/src/x11extras/qtx11extrasglobal.h +++ b/src/x11extras/qtx11extrasglobal.h ___ Development mailing list Development@qt-project.org http:/

[Development] Qt 5.5.0 header diff: QtMultimediaWidgets.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/multimediawidgets/qcameraviewfinder.h b/src/multimediawidgets/qcameraviewfinder.h index 5467574..65556c4 100644 --- a/src/multimediawidgets/qcameraviewfinder.h +++ b/src/multimediawidgets/qcameraviewfinder.h ___ Development mailing list D

Re: [Development] Qt 5.5.0 header diff

2015-06-05 Thread Simon Hausmann
On Thursday, June 04, 2015 03:29:10 PM Frederik Gladhorn wrote: [...] > Modules for which Git failed to retrieve changes: [...] > QtWebEngine > QtWebEngineWidgets Oops, I suppose we do need to look at the diffs for those though? Simon _

[Development] Qt 5.5.0 header diff: QtScript.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/script/api/qscriptable.h b/src/script/api/qscriptable.h index 4f4fdc2..8756e1a 100644 --- a/src/script/api/qscriptable.h +++ b/src/script/api/qscriptable.h ___ Development mailing list Development@qt-project.org http://lists.qt-project.or

[Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/multimedia/audio/qaudio.h b/src/multimedia/audio/qaudio.h index 7e9793f..6395314 100644 --- a/src/multimedia/audio/qaudio.h +++ b/src/multimedia/audio/qaudio.h @@ -47,6 +47,7 @@ #include #include #include +#include #include @@ -76,6 +77,8 @@ class Q_MULTIMEDIA_EXPORT Q

[Development] Qt 5.5.0 header diff: QtPositioning.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/positioning/qgeoaddress.h b/src/positioning/qgeoaddress.h index 93a5c19..9c107b1 100644 --- a/src/positioning/qgeoaddress.h +++ b/src/positioning/qgeoaddress.h @@ -43,6 +43,10 @@ class QGeoCirclePrivate; class Q_POSITIONING_EXPORT QGeoCircle : public QGeoShape { +Q_GADGET +

[Development] Qt 5.5.0 header diff: QtDeclarative.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/declarative/debugger/qdeclarativedebug.h b/src/declarative/debugger/qdeclarativedebug.h index e5aba61..8183a2b 100644 --- a/src/declarative/debugger/qdeclarativedebug.h +++ b/src/declarative/debugger/qdeclarativedebug.h ___ Development ma

[Development] Qt 5.5.0 header diff: QtDBus.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/dbus/qdbusabstractadaptor.h b/src/dbus/qdbusabstractadaptor.h index 7344335..0ceb331 100644 --- a/src/dbus/qdbusabstractadaptor.h +++ b/src/dbus/qdbusabstractadaptor.h @@ -56,7 +56,7 @@ class QDBusAbstractInterfacePrivate; class Q_DBUS_EXPORT QDBusAbstractInterfaceBase: public QOb

[Development] Qt 5.5.0 header diff: QtSerialPort.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h index fa681ad..cbf489d 100644 --- a/src/serialport/qserialport.h +++ b/src/serialport/qserialport.h @@ -63,6 +63,7 @@ class Q_SERIALPORT_EXPORT QSerialPort : public QIODevice #if QT_DEPRECATED_SINCE(5, 3) Q_PROPERTY(bool

[Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/testlib/qbenchmark.h b/src/testlib/qbenchmark.h index de4f9a1..9481e91 100644 --- a/src/testlib/qbenchmark.h +++ b/src/testlib/qbenchmark.h @@ -70,7 +70,7 @@ template<> inline char *toString(const QLatin1String &str) template<> inline char *toString(const QByteArray &ba) { -

[Development] Qt 5.5.0 header diff: QtQuickWidgets.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/quickwidgets/qquickwidget.h b/src/quickwidgets/qquickwidget.h index 530a523..a8bf03e 100644 --- a/src/quickwidgets/qquickwidget.h +++ b/src/quickwidgets/qquickwidget.h @@ -90,6 +90,8 @@ public: void setClearColor(const QColor &color); +QQuickWindow *quickWindow() const

[Development] Qt 5.5.0 header diff: QtXmlPatterns.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/xmlpatterns/api/qabstractmessagehandler.h b/src/xmlpatterns/api/qabstractmessagehandler.h index a43c01e..3106f0d 100644 --- a/src/xmlpatterns/api/qabstractmessagehandler.h +++ b/src/xmlpatterns/api/qabstractmessagehandler.h ___ Developmen

[Development] Qt 5.5.0 header diff: QtMultimediaQuick_p.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/qtmultimediaquicktools/qsgvideonode_rgb.h b/src/qtmultimediaquicktools/qsgvideonode_rgb.h index e6800ce..77d11b6 100644 --- a/src/qtmultimediaquicktools/qsgvideonode_rgb.h +++ b/src/qtmultimediaquicktools/qsgvideonode_rgb.h @@ -50,7 +50,10 @@ public: virtual QVideoFrame::Pixel

[Development] Qt 5.5.0 header diff: QtSvg.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/svg/qgraphicssvgitem.h b/src/svg/qgraphicssvgitem.h index 8af0d1e..541ddec 100644 --- a/src/svg/qgraphicssvgitem.h +++ b/src/svg/qgraphicssvgitem.h ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailma

[Development] Qt 5.5.0 header diff: QtWebChannel.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/webchannel/qqmlwebchannel.h b/src/webchannel/qqmlwebchannel.h index 92741c6..52d09e6 100644 --- a/src/webchannel/qqmlwebchannel.h +++ b/src/webchannel/qqmlwebchannel.h ___ Development mailing list Development@qt-project.org http://lists.q

[Development] Qt 5.5.0 header diff: QtNfc.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/nfc/qndeffilter.h b/src/nfc/qndeffilter.h index 053dfe2..56721bf 100644 --- a/src/nfc/qndeffilter.h +++ b/src/nfc/qndeffilter.h @@ -80,6 +80,7 @@ public: QNdefNfcSmartPosterRecord(); QNdefNfcSmartPosterRecord(const QNdefRecord &other); QNdefNfcSmartPosterRecord(const

[Development] Qt 5.5.0 header diff: QtConcurrent.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/concurrent/qtconcurrent_global.h b/src/concurrent/qtconcurrent_global.h index 5f09a1b..d6c0f03 100644 --- a/src/concurrent/qtconcurrent_global.h +++ b/src/concurrent/qtconcurrent_global.h @@ -107,7 +107,7 @@ private: void startThreads(); void threadExit(); bool threa

[Development] Qt 5.5.0 header diff: QtOpenGLExtensions.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/openglextensions/qopenglextensions.h b/src/openglextensions/qopenglextensions.h index 78bbf4b..c9d1ef1 100644 --- a/src/openglextensions/qopenglextensions.h +++ b/src/openglextensions/qopenglextensions.h ___ Development mailing list Devel

[Development] Qt 5.5.0 header diff: QtLocation.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/location/maps/qgeocodereply.h b/src/location/maps/qgeocodereply.h index a30a863..f713e42 100644 --- a/src/location/maps/qgeocodereply.h +++ b/src/location/maps/qgeocodereply.h @@ -56,7 +59,7 @@ class QGeoServiceProviderPrivate; class Q_LOCATION_EXPORT QGeoServiceProvider : public

[Development] Qt 5.5.0 header diff: QtQuickTest.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/qmltest/quicktest.h b/src/qmltest/quicktest.h index aa34e0f..49bd7ed 100644 --- a/src/qmltest/quicktest.h +++ b/src/qmltest/quicktest.h ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/d

[Development] Qt 5.5.0 header diff: QtSensors.diff

2015-06-05 Thread Frederik Gladhorn
diff --git a/src/sensors/gestures/qsensorgesture.h b/src/sensors/gestures/qsensorgesture.h index 7e8b806..46d7e77 100644 --- a/src/sensors/gestures/qsensorgesture.h +++ b/src/sensors/gestures/qsensorgesture.h ___ Development mailing list Development@qt-pr