Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Marc Mutz
On Friday 01 July 2016 20:36:56 Thiago Macieira wrote: > The use of the Standard Library member "empty" is highly confusing at > first sight because it does not follow the Qt naming guidelines. It's > even more confusing because the next line has "isEmpty". When I read this > code, I had to

Re: [Development] Announcing moc_combine

2016-07-01 Thread Thiago Macieira
On domingo, 29 de maio de 2016 13:05:07 PDT Thiago Macieira wrote: > I've just pushed a feature[1] Change is now abandoned due to lack of volunteers to modify qmake to generate a suitable Makefile. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source

Re: [Development] New configuration system

2016-07-01 Thread Samuel Gaist
On 23 juin 2016, at 09:29, Lars Knoll wrote: > Hi, > > As some of you might know, I’ve been working for some time now on developing > a new configuration system for Qt. As the first large change went in > yesterday evening, I guess it’s time I describe it a little, and also

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Thiago Macieira
On sexta-feira, 1 de julho de 2016 18:31:17 PDT Rafael Roquetto wrote: > Of course, all this assumes the introduction of a QtStl namespace to be a > feasible task. Whether it really is I cannot say. I'd say we start with it in a private header, add classes to it as needed. If we're happy with

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Thiago Macieira
On sexta-feira, 1 de julho de 2016 22:13:42 PDT Giuseppe D'Angelo wrote: > Even today: where is QList::push_back(T&&)? Where are our emplacement > functions and their try versions? Where are our exception guarantees?) We don't care about exceptions, so we won't be adding those. As for the

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Rafael Roquetto
On Fri, Jul 01, 2016 at 01:05:45PM -0700, Thiago Macieira wrote: > On sexta-feira, 1 de julho de 2016 22:52:24 PDT Konstantin Tokarev wrote: > > > I had to look up the definition of readHeaders in the review and note that > > > it was a std::deque, not a Qt container. > > > > STL was standardized

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Matthew Woehlke
On 2016-07-01 16:13, Giuseppe D'Angelo wrote: > Even today: where is QList::push_back(T&&)? Where are our emplacement > functions and their try versions? Where are our exception guarantees?) ...what's an exception? ;-) Never heard of those in Qt... -- Matthew

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Giuseppe D'Angelo
Howdy, Il 01/07/2016 21:34, Thiago Macieira ha scritto: On sexta-feira, 1 de julho de 2016 11:36:56 PDT Thiago Macieira wrote: Option 1: Not use Standard Library containers, just use the Qt containers as they exist. However this is an anti-goal. As you stated, STL containers usage inside Qt

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Thiago Macieira
On sexta-feira, 1 de julho de 2016 22:52:24 PDT Konstantin Tokarev wrote: > > I had to look up the definition of readHeaders in the review and note that > > it was a std::deque, not a Qt container. > > STL was standardized 18 years ago, I think it should be enough to get used > to empty(). Qt

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Konstantin Tokarev
01.07.2016, 21:37, "Thiago Macieira" : > Premises not under discussion: > > Qt source code is product and meant to be read by our users > Qt source code must be clean and readable > > The above is not up for debate. > > For some time now, we've had a

Re: [Development] dev branch compile fails module-qtdatavis3d

2016-07-01 Thread Thiago Macieira
On sexta-feira, 1 de julho de 2016 21:36:21 PDT Martin Koller wrote: > On Friday 01 July 2016 08:39:07 Thiago Macieira wrote: > > On sexta-feira, 1 de julho de 2016 13:26:17 PDT Martin Koller wrote: > > > g++ -Wl,--gc-sections > > > -Wl,-rpath,/home/PACKAGES/qt/qt-repo/qt5/qtbase/lib -o > > >

Re: [Development] dev branch compile fails module-qtdatavis3d

2016-07-01 Thread Martin Koller
On Friday 01 July 2016 08:39:07 Thiago Macieira wrote: > On sexta-feira, 1 de julho de 2016 13:26:17 PDT Martin Koller wrote: > > g++ -Wl,--gc-sections -Wl,-rpath,/home/PACKAGES/qt/qt-repo/qt5/qtbase/lib -o > > /home/PACKAGES/qt/qt-repo/qt5/qtbase/bin/qml .obj/main.o .obj/qrc_qml.o > >

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-01 Thread Thiago Macieira
On sexta-feira, 1 de julho de 2016 11:36:56 PDT Thiago Macieira wrote: > Option 1: > Not use Standard Library containers, just use the Qt containers as they > exist. > > Option 2: > Create new Qt containers to have the same complexity as Standard Library > containers, but following the Qt naming

Re: [Development] dev branch compile fails module-qtdatavis3d

2016-07-01 Thread Thiago Macieira
On sexta-feira, 1 de julho de 2016 13:26:17 PDT Martin Koller wrote: > g++ -Wl,--gc-sections -Wl,-rpath,/home/PACKAGES/qt/qt-repo/qt5/qtbase/lib -o > /home/PACKAGES/qt/qt-repo/qt5/qtbase/bin/qml .obj/main.o .obj/qrc_qml.o > .obj/moc_conf.o -L/home/PACKAGES/qt/qt-repo/qt5/qtbase/lib >

[Development] dev branch compile fails module-qtdatavis3d

2016-07-01 Thread Martin Koller
Hi, trying to build module-qtdatavis3d on dev branch (with a namespace) fails here with: make[3]: Entering directory '/home/PACKAGES/qt/qt-repo/qt5/qtdeclarative/tools/qml' g++ -Wl,--gc-sections -Wl,-rpath,/home/PACKAGES/qt/qt-repo/qt5/qtbase/lib -o

Re: [Development] Input events handling ideas and feedback

2016-07-01 Thread Filippo Cucchetto
> if we had time to filter out all the good ideas from all the frameworks, we’d > have a better chance of making ours the best. ;-) Agreed :) > Well we advertise that it’s a declarative language. We could make it even > more that way, even if it’s not strictly necessary. Would it be more