Re: [Development] dev branch compile fails module-qtdatavis3d

2016-07-04 Thread Martin Koller
On Saturday 02 July 2016 09:43:51 Thiago Macieira wrote: > Can you find which .o in QtGui made a reference to > qt_version_tag? Not sure I do it the correct way.. I grepped in objdump -x and find the symbol in all .o files, e.g.: ... l .group qt_version_ta

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Thiago Macieira
On segunda-feira, 4 de julho de 2016 13:54:45 PDT Matthew Woehlke wrote: > Consider... if I ask you what relation the letter 'A' has to the > alphabet, is it the letter *at the front*, or is it the *first* letter? > I bet you, and most (native, certainly) English speakers said it's the > *first* le

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Thiago Macieira
On segunda-feira, 4 de julho de 2016 13:26:13 PDT Matthew Woehlke wrote: > Option N+1: Convince the committee to adopt Qt's naming conventions and > convenience API's in STL2¹ ;-). > > (¹ Or whatever it's being called...) We can try, but that is orthogonal to the discussion. Such a standard does

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Thiago Macieira
On segunda-feira, 4 de julho de 2016 09:59:44 PDT Christian Kandeler wrote: > > The use of the Standard Library member "empty" is highly confusing at > > first > > sight because it does not follow the Qt naming guidelines. It's even more > > confusing because the next line has "isEmpty". When I rea

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Matthew Woehlke
On 2016-07-02 02:42, Marc Mutz wrote: > The STL has a great API. push_back() / back() vs. append() / last(), e.g. It > just happens to be largely consistent with itself instead of with Qt. But > camelCase is not intrinsically "better" than underscored_names, and I also > fail to see why first()

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Matthew Woehlke
On 2016-07-01 17:56, Thiago Macieira wrote: > On sexta-feira, 1 de julho de 2016 22:13:42 PDT Giuseppe D'Angelo wrote: >> Even today: where is QList::push_back(T&&)? Where are our emplacement >> functions and their try versions? Where are our exception guarantees?) > > We don't care about exceptio

Re: [Development] Why QFontDatabase::hasFamily() is marked as internal?

2016-07-04 Thread Jiang Jiang
On Mon, Jul 4, 2016 at 11:47 PM, Konstantin Tokarev wrote: > Hello, > > Are there any reasons not to make QFontDatabase::hasFamily() a part of public > API? Looks like it was originally added for QtWebKit and stayed internal as is since then. https://github.com/qt/qtbase/commit/b2553443739f7875

[Development] Why QFontDatabase::hasFamily() is marked as internal?

2016-07-04 Thread Konstantin Tokarev
Hello, Are there any reasons not to make QFontDatabase::hasFamily() a part of public API? -- Regards, Konstantin ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Edward Welbourne
Thanks to Olivier for pointing out a mistake: > I've fixed issues in qmake [0] where for-loops caused similar problems. > [0] e.g. https://codereview.qt-project.org/#/c/161133 That should have been: [0] https://codereview.qt-project.org#/c/141305/14//ALL,unified Eddy. ___

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Edward Welbourne
Stephen Kelly gave QQuickListViewPrivate::applyInsertionChange as an example of "raw" for-loops being tricky to follow: There's a `++index` somewhere in the middle 3 scopes deep. Further up in the function `index` is assigned, but then assigned again (conditionally) from the `count`

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Marc Mutz
On Monday 04 July 2016 10:03:11 Philippe wrote: > >>Actually, I disagree with that. As someone who has come to appreciate > >>STL after growing up in the Qt world, > > Exact opposite here: I learned STL from its early days, and could never > become at ease with its namings... and I started to bre

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread André Somers
Op 04/07/2016 om 10:03 schreef Philippe: Actually, I disagree with that. As someone who has come to appreciate STL after growing up in the Qt world, Exact opposite here: I learned STL from its early days, and could never become at ease with its namings... and I started to breath with Qt contai

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Philippe
>>Actually, I disagree with that. As someone who has come to appreciate >>STL after growing up in the Qt world, Exact opposite here: I learned STL from its early days, and could never become at ease with its namings... and I started to breath with Qt containers :) Philippe __

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread Christian Kandeler
On 07/01/2016 08:36 PM, Thiago Macieira wrote: For some time now, we've had a flurry of changes to Qt source code that uses the Standard Library's containers and algorithms, in the name of performance and often code size gains. I'm not disputing that there is a gain. But I am wondering about the

Re: [Development] Use of Standard Library containers in Qt source code

2016-07-04 Thread André Somers
Op 04/07/2016 om 08:41 schreef Thiago Macieira: On segunda-feira, 4 de julho de 2016 08:14:21 PDT Julien Blanc wrote: Following Stephen Kelly’s mails, I’m convinced that instead of wrapping stl containers, implementing a free function qIsEmpty is less work and addresses all your readability co