Re: [Development] how to include further changes while previous commit is still under review?

21.01.2018, 01:25, "Daniel Savi" : > On 19.01.2018 18:40, Konstantin Tokarev wrote: >>  19.01.2018, 01:58, "Samuel Gaist" :    On 18 Jan 2018, at 22:42, Daniel Savi wrote:    Hello qt devs    I'm back

Re: [Development] how to include further changes while previous commit is still under review?

On 19.01.2018 18:40, Konstantin Tokarev wrote: 19.01.2018, 01:58, "Samuel Gaist" :  On 18 Jan 2018, at 22:42, Daniel Savi wrote:  Hello qt devs  I'm back with another newbie question. I have committed a patch that is still under review on

Re: [Development] Setters: Clarifying the ownership

Please use an already existing solution to this problem : https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Ri-raw Errors will be caught by the compiler in case of std::unique_ptr, and by static analysers (like clang-tidy) for gsl::owner, without run-time cost. There was