Re: [Development] On deprecating functions

2019-03-05 Thread Christian Ehrlicher
Am 05.03.2019 um 11:53 schrieb Tor Arne Vestbø: On 5 Mar 2019, at 11:27, Giuseppe D'Angelo via Development wrote: Il 05/03/19 08:14, Lars Knoll ha scritto: One solution I thought about is to replace the QT_DEPRECATED(_X) macros with something that also contains the version (similar to

Re: [Development] forcing libxkbcommon to be present in the system makes newer Qt unusable on older linux distros

2019-03-05 Thread Thiago Macieira
On Tuesday, 5 March 2019 06:52:27 PST Gatis Paeglis wrote: > "This library is present on all supported platforms." Please note the implication on this: the Linux distribution you're using is NOT a supported one. The commit removing xkbcommon explicitly says so:

Re: [Development] forcing libxkbcommon to be present in the system makes newer Qt unusable on older linux distros

2019-03-05 Thread Gatis Paeglis
> library doesn't provide another way to build itself. libxkbcommon changelog for 0.7.2 https://lists.freedesktop.org/archives/wayland-devel/2017-August/034721.html "Added a Meson build system as an alternative to existing autotools build system. The intent is to remove the autotools build in

[Development] forcing libxkbcommon to be present in the system makes newer Qt unusable on older linux distros

2019-03-05 Thread NIkolai Marchenko
- [QTBUG-65503] Removed xkbcommon from bundled sources. This library is present on all supported platforms. The minimal required version now is 0.5.0. The change above makes updating Qt a gargantuan task for Centos 6 at least. Building xkbcommon there requires meson (which centos 6

Re: [Development] On deprecating functions

2019-03-05 Thread Tor Arne Vestbø
> On 5 Mar 2019, at 11:27, Giuseppe D'Angelo via Development > wrote: > > Il 05/03/19 08:14, Lars Knoll ha scritto: >> One solution I thought about is to replace the QT_DEPRECATED(_X) macros with >> something that also contains the version (similar to QT_DEPRECATED_SINCE). >> Then the user

Re: [Development] On deprecating functions

2019-03-05 Thread Giuseppe D'Angelo via Development
Il 05/03/19 08:14, Lars Knoll ha scritto: One solution I thought about is to replace the QT_DEPRECATED(_X) macros with something that also contains the version (similar to QT_DEPRECATED_SINCE). Then the user could define how current he wants to be, and we could set a reasonable default going

Re: [Development] On deprecating functions

2019-03-05 Thread Jedrzej Nowacki
On Tuesday, March 5, 2019 8:14:00 AM CET Lars Knoll wrote: > One solution I thought about is to replace the QT_DEPRECATED(_X) macros with > something that also contains the version (similar to QT_DEPRECATED_SINCE). > Then the user could define how current he wants to be, and we could set a >

Re: [Development] On deprecating functions

2019-03-05 Thread Christian Kandeler
On Mon, 4 Mar 2019 22:27:42 +0100 André Pönitz wrote: > (5) Use #if (QT_VERSION / QT_VERSION_CHECK. To "fix" perfectly > valid code *for cosmetical reasons*? DUH! Example: https://codereview.qt-project.org/#/c/252715/1 was necessary because of the immediate deprecation of an existing function

Re: [Development] On deprecating functions

2019-03-05 Thread Eike Ziller
> On 4. Mar 2019, at 22:27, André Pönitz wrote: > > On Mon, Mar 04, 2019 at 05:51:08PM +0100, Christian Ehrlicher wrote: >> Hi, >> >> I recently introduced some new signals >> (Q(Double)SpinBox::textChanged, QComboBox::textActivated) as >> replacements for old ones to be able to avoid the use