Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Lars Knoll
On 6 May 2019, at 20:23, André Pönitz mailto:apoen...@t-online.de>> wrote: On Mon, May 06, 2019 at 07:41:05AM +, Lars Knoll wrote: On 6 May 2019, at 09:30, Christian Kandeler mailto:christian.kande...@qt.io>> wrote: On Sat, 04 May 2019 09:06:39 +0200 Allan Sandfeld Jensen mailto:k...@carew

Re: [Development] Gerrit Upgrade

2019-05-06 Thread Konstantin Tokarev
Are we planning to use Polymer-based UI, as currently used by Chromium and Android, or the "old" one (which is probably still a default)? I believe "old" one has a horrible UX, while Polymer one is a bit nicer. Also, Polymer's patch viewer plays nicely with X selection buffer, while "old" does n

Re: [Development] Gerrit Upgrade

2019-05-06 Thread Sergio Ahumada
On 06.05.19 14:16, Frederik Gladhorn wrote: > Hello, > > We've been working on the Gerrit Upgrade for a while now and we are finally > getting ready to deploy the new goodness. > > We have all patches in our fork (yes, sadly we continue diverging a bit from > mainstream, adding our own state ha

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread André Pönitz
On Mon, May 06, 2019 at 07:41:05AM +, Lars Knoll wrote: > > On 6 May 2019, at 09:30, Christian Kandeler > > wrote: > > > > On Sat, 04 May 2019 09:06:39 +0200 Allan Sandfeld Jensen > > wrote: > > > >> On Samstag, 4. Mai 2019 00:43:10 CEST Thiago Macieira wrote: > >>> On Friday, 3 May 2019 13

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Vitaly Fanaskov
Well, it should be possible, to support parents, created on the stack. We already have the code to do it. The code is private, unfortunately, but it doesn't matter. In the following file: qtbase/src/corelib/tools/qsharedpointer_impl.h We have the following constructor, used by QPointer: templa

[Development] Gerrit Upgrade

2019-05-06 Thread Frederik Gladhorn
Hello, We've been working on the Gerrit Upgrade for a while now and we are finally getting ready to deploy the new goodness. We have all patches in our fork (yes, sadly we continue diverging a bit from mainstream, adding our own state handling for the CI). The good news is that there are very f

Re: [Development] A monologue about platforms in the Qt world

2019-05-06 Thread Giuseppe D'Angelo via Development
Hi Tony, On 02/05/2019 13:48, Tony Sarajärvi wrote: What's a supported platform? --- It means that The Qt Company gives you support if you stumble upon a problem with that distro I don't agree on "The Qt Company gives you support" part. That's part of whatever commercial support agreemen

Re: [Development] A monologue about platforms in the Qt world

2019-05-06 Thread Volker Hilsheimer
See inline. From: Development mailto:development-boun...@qt-project.org>> on behalf of Danila Malyutin mailto:danilamalju...@gmail.com>> Sent: Friday, May 3, 2019 4:07 PM To: development@qt-project.org Subject: Re: [Development] A monologue about platforms in

[Development] Qt CMake Workshop May 2019 Summary

2019-05-06 Thread Alexandru Croitor
Hi, Last week a bunch of Qt and KDAB people met to work on the Qt CMake port. You can read the discussion notes and the work done at https://wiki.qt.io/CMake_Port/Development_Notes It looks like Milestone 1 https://bugreports.qt.io/browse/QTBUG-73925 is getting closer to seeing the light. Che

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Lars Knoll
On 6 May 2019, at 10:27, Konstantin Shegunov mailto:kshegu...@gmail.com>> wrote: On Mon, May 6, 2019 at 10:42 AM Lars Knoll mailto:lars.kn...@qt.io>> wrote: Not sure whether it’s most projects, but there certainly are users doing it. And we’ve been using the pattern in our examples in some cas

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Konstantin Shegunov
On Mon, May 6, 2019 at 10:42 AM Lars Knoll wrote: > Not sure whether it’s most projects, but there certainly are users doing > it. And we’ve been using the pattern in our examples in some cases as well. > But I can relate to Allan that creating widgets on the stack is bad style > (as it conflicts

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Lars Knoll
> On 6 May 2019, at 09:30, Christian Kandeler wrote: > > On Sat, 04 May 2019 09:06:39 +0200 > Allan Sandfeld Jensen wrote: > >> On Samstag, 4. Mai 2019 00:43:10 CEST Thiago Macieira wrote: >>> On Friday, 3 May 2019 13:00:52 PDT Иван Комиссаров wrote: Which should be considered bad practice

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Иван Комиссаров
True, but it’s ownership is never transferred, so it’s out of the scope of discussion - user is free to use any c++ idiom he likes. I would like to discuss how to transfer ownership in modern Qt. > 6 мая 2019 г., в 9:30, Christian Kandeler > написал(а): > > On Sat, 04 May 2019 09:06:39 +0200 >

Re: [Development] unique_ptr and Qt, Take 2

2019-05-06 Thread Christian Kandeler
On Sat, 04 May 2019 09:06:39 +0200 Allan Sandfeld Jensen wrote: > On Samstag, 4. Mai 2019 00:43:10 CEST Thiago Macieira wrote: > > On Friday, 3 May 2019 13:00:52 PDT Иван Комиссаров wrote: > > > Which should be considered bad practice and banned on an API level > > > > No way. > > > > Are you g