Re: [Development] [RFO QTBUG-84739] QJsonValue::fromVariant containing QByteArray

2020-07-09 Thread Thiago Macieira
On Wednesday, 1 July 2020 14:21:33 PDT Thiago Macieira wrote: > Re: https://bugreports.qt.io/browse/QTBUG-84739 > Summary: Qt 5.15 has an unintentional change in behaviour that has broken > existing applications. We need to decide whether to: > b) revert permanently Looks like the discussion has

Re: [Development] How do I fix a vulnerability in Qt. I forward the question to someone, or should I write the code myself?

2020-07-09 Thread Lisandro Damián Nicanor Pérez Meyer
Hi Bruno! On Thu, 9 Jul 2020 at 15:11, Bruno Crocamo wrote: > > Thank u, Eddy. > > Lars, in my first message I mentioned a link: > https://github.com/wkhtmltopdf/qt/pull/47. > > Here you can see the changes I made: > https://github.com/wkhtmltopdf/qt/pull/47/commits/5d639d9c04dbc644875e913cf0a6

Re: [Development] How do I fix a vulnerability in Qt. I forward the question to someone, or should I write the code myself?

2020-07-09 Thread Bruno Crocamo
Thank u, Eddy. Lars, in my first message I mentioned a link: https://github.com/wkhtmltopdf/qt/pull/47. Here you can see the changes I made: https://github.com/wkhtmltopdf/qt/pull/47/commits/5d639d9c04dbc644875e913cf0a6f5f54abcbf75 The changes made by me perform a reordering. This lessens the ri

Re: [Development] How do I fix a vulnerability in Qt. I forward the question to someone, or should I write the code myself?

2020-07-09 Thread Thiago Macieira
On Thursday, 9 July 2020 03:48:18 PDT Lars Knoll wrote: > The easiest fix for this would probably be to simply change the "QList > glyph_indices;" in QFontSubset to a QSet. That would make the output non-deterministic. If determinism is wanted, a sorted container is preferable. -- Thiago Macie

Re: [Development] How do I fix a vulnerability in Qt. I forward the question to someone, or should I write the code myself?

2020-07-09 Thread Lars Knoll
> On 8 Jul 2020, at 19:02, Thiago Macieira wrote: > > On Wednesday, 8 July 2020 09:44:33 PDT Bruno Crocamo wrote: >> An organization may need to remove sensitive information from a PDF >> document to share an ostentatious version. Adobe software is one way to do >> this. However, depending on th

Re: [Development] How do I fix a vulnerability in Qt. I forward the question to someone, or should I write the code myself?

2020-07-09 Thread Edward Welbourne
Hi Bruno, In addition to what Thiago said, about contributing in general, for future reference, The Qt Project does also have a security policy [1], which outlines the process for handling vulnerabilities. Given that this discussion has happened in public already, the confidentiality aspects of t