Re: [Development] QSortFilterProxyModel: recursiveFilteringEnabled

2023-09-21 Thread László Papp
Thanks! Since both QML and KDE have had this use case, and now, I also have it, as well as another person on Stack Overflow, should we propose a public API in Qt for this? I think this would be a great addition to the public interface. For now, I will implement my own version, but it sounds

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-09-21 Thread Thiago Macieira
On Thursday, 21 September 2023 02:10:22 PDT Ivan Solovev via Development wrote: > But I'd say that if someone wants to implement three-way comparison for > their classes in C++17, then a bit better understanding of the language > features is a reasonable expectation. Allowing class developers to

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-09-21 Thread Ivan Solovev via Development
I drafted a QUIP that describes how to apply C++20 comparison to Qt classes: https://codereview.qt-project.org/c/meta/quips/+/490932 It intentionally does not mention `qCompareThreeWay()` and `qComparesEqual()`, because these public APIs are not required for the internal implementation.

Re: [Development] QSortFilterProxyModel: recursiveFilteringEnabled

2023-09-21 Thread Richard Gustavsen via Development
On 21 Sep 2023, at 14:10, László Papp wrote: Thanks! So, something like this? https://api.kde.org/frameworks/kitemmodels/html/index.html E.g. KDescendantsProxyModel or that would also require further work? Yes, that could work. And then you give that model to QSFPM to filter away rows

Re: [Development] QSortFilterProxyModel: recursiveFilteringEnabled

2023-09-21 Thread László Papp
Thanks! So, something like this? https://api.kde.org/frameworks/kitemmodels/html/index.html E.g. KDescendantsProxyModel or that would also require further work? -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QSortFilterProxyModel: recursiveFilteringEnabled

2023-09-21 Thread Richard Gustavsen via Development
You basically want top flatten a tree model into a list (or table) model, and then remove the rows that have children, and then sort the list. Note that sorting such a list of leafs would be different from how QSFPM works today, where it sorts the children of each parent node locally, without

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-09-21 Thread Ivan Solovev via Development
> See my other email: the (1) is not discoverable, teachable, or particularly > understandable by average C++ developers. It is not a good corner of C++. As you correctly pointed out, most of the developers will just use public operator==(), and, come C++20, operator<=>(). But I'd say that if

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-09-21 Thread Ivan Solovev via Development
> I have just rebased the chain on top of the latest dev and fixed the issue > with qfloat16 and -Wfloat-equal. > Now it builds fine for me locally on Linux with GCC. Started a full pre-check > in the CI to test other configurations. > I'll keep an eye on the pre-check results and try to fix any

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-21 Thread Volker Hilsheimer via Development
On 13 Sep 2023, at 16:25, Volker Hilsheimer via Development wrote: On 13 Sep 2023, at 13:23, Ahmad Samir wrote: On 13/9/23 11:06, Ivan Solovev via Development wrote: I would therefore propose to remove the file from qt5.git: +1 from my side. I believe I simply do not have the clang-format