lking about these two patches:
Change-Id: Iaa8ec0246aaba004d98c9e8c66609795101519a9
Change-Id: I2d269ef0f842e73af64d48bfef531d5fa3078088
What am I doing wrong?
Regards,
Daniel Savi
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Dear developers
My journey into Qt development came again to a sudden halt. I've
commited this patch (Iaa8ec0246aaba004d98c9e8c66609795101519a9) and Lars
Knoll gave it green light after comments from him, André Hartman and
Edward Welbourne.
Now, when I hit the "Merge patch Set to
ev <annu...@yandex.ru>:
>
>
>21.01.2018, 01:25, "Daniel Savi" <daniel.s...@gaess.ch>:
>> On 19.01.2018 18:40, Konstantin Tokarev wrote:
>>> 19.01.2018, 01:58, "Samuel Gaist" <samuel.ga...@edeltech.ch>:
>>>>> On 18 Jan
On 19.01.2018 18:40, Konstantin Tokarev wrote:
19.01.2018, 01:58, "Samuel Gaist" <samuel.ga...@edeltech.ch>:
On 18 Jan 2018, at 22:42, Daniel Savi <daniel.s...@gaess.ch> wrote:
Hello qt devs
I'm back with another newbie question. I have committed a patch that
Hello qt devs
I'm back with another newbie question. I have committed a patch that is
still under review on gerrit.
Meanwhile, I've got a local and unrelated patch on the same file, that I
would like to commit, too.
Now, how would I include this patch into my local git repo and how would
Thank you all for the helpful comments on my previous message.
I think that I have now managed to amend my changes into one commit and
may understand how to react on comments.
While amending my commits I must somehow have pushed another commit
again that is not from me at all. It is this
Hello everybody
I've just pushed my first commit to QtGui, trying to follow the
contribution guidelines posted here
http://wiki.qt.io/Qt_Contribution_Guidelines. Now I have some questions
regarding the process. It seems that I have done it at least partly
wrong ;-)
The codereview to my
