Re: [Development] [Releasing] Qt 5.8.0 API review

2017-01-04 Thread Edward Welbourne
Back on the 7th of November 2016 I announced: > With the 5.8.0 release now close at hand, I've updated the API reviews: I've now updated these for the actual 5.8.0 branch (fetched this morning): https://codereview.qt-project.org/170634 - qtbase https://codereview.qt-project.org/170635 - qtdeclara

Re: [Development] [Releasing] Qt 5.8.0 API review

2016-11-14 Thread Lars Knoll
Thanks, Looks good once these two changes are integrated. Cheers, Lars On 14/11/16 11:42, "Development on behalf of Sean Harmer" wrote: On Monday 14 November 2016 10:34:38 Sean Harmer wrote: > On Monday 14 November 2016 09:37:21 Lars Knoll wrote: > > Hi, > > > > I went th

Re: [Development] [Releasing] Qt 5.8.0 API review

2016-11-14 Thread Sean Harmer
On Monday 14 November 2016 10:34:38 Sean Harmer wrote: > On Monday 14 November 2016 09:37:21 Lars Knoll wrote: > > Hi, > > > > I went through all modules now, and added my comments. Mainly small > > issues, > > with the exception of Qt 3D, where I see some real BC breakages. > > > > Sean, could y

Re: [Development] [Releasing] Qt 5.8.0 API review

2016-11-14 Thread Sean Harmer
On Monday 14 November 2016 09:37:21 Lars Knoll wrote: > Hi, > > I went through all modules now, and added my comments. Mainly small issues, > with the exception of Qt 3D, where I see some real BC breakages. > > Sean, could you please look at https://codereview.qt-project.org/#/c/170642/ > asap.

Re: [Development] [Releasing] Qt 5.8.0 API review

2016-11-14 Thread Lars Knoll
Hi, I went through all modules now, and added my comments. Mainly small issues, with the exception of Qt 3D, where I see some real BC breakages. Sean, could you please look at https://codereview.qt-project.org/#/c/170642/ asap. Thanks, Lars On 14/11/16 09:44, "Jani Heikkinen" wrote: Hi

Re: [Development] [Releasing] Qt 5.8.0 API review

2016-11-14 Thread Jani Heikkinen
Hi all, It seems this is still badly ongoing, only few '+1' and only one '+2' there :( Please try to finalize the review during this week: We need to have reviews done & possible changes in '5.8' before we can start branching from '5.8' to '5.8.0' br, Jani ___

Re: [Development] [Releasing] Qt 5.8.0 API review

2016-11-07 Thread Edward Welbourne
With the 5.8.0 release now close at hand, I've updated the API reviews: https://codereview.qt-project.org/170634 - qtbase https://codereview.qt-project.org/170635 - qtdeclarative https://codereview.qt-project.org/170636 - qtactiveqt https://codereview.qt-project.org/170637 - qtmultimedia https://c