Re: [Development] Do we really need Assimp?

2018-06-08 Thread Mike Krus
Hi Using system assimp is probably the best scenario indeed. Except I think users would expect install packages to have that enabled so ideally assimp should be installed on CI systems. Mike > On 7 Jun 2018, at 17:24, Lisandro Damián Nicanor Pérez Meyer > wrote: > > El jueves, 7 de junio

Re: [Development] Do we really need Assimp?

2018-06-07 Thread Lisandro Damián Nicanor Pérez Meyer
El jueves, 7 de junio de 2018 13:03:43 -03 Thiago Macieira escribió: > On Thursday, 7 June 2018 04:31:13 PDT Sean Harmer wrote: > > Another option is to only rely upon a system installed assimp and build > > these tools only if found at configure time. In fact, that's probably > > easiest and

Re: [Development] Do we really need Assimp?

2018-06-07 Thread Sean Harmer
Hi Thiago, Apologies for the delay in replying, I was on vacation. On 23/05/2018 01:16, Thiago Macieira wrote: Given the number of warnings in this codebase, I am really skeptical about the quality of the code. Today, compiling with GCC, Clang an ICC, I saw the following warnings scroll by,

[Development] Do we really need Assimp?

2018-05-22 Thread Thiago Macieira
Given the number of warnings in this codebase, I am really skeptical about the quality of the code. Today, compiling with GCC, Clang an ICC, I saw the following warnings scroll by, which are real issues: LWSLoader.cpp:428:14: warning: duplicated ‘if’ condition [-Wduplicated-cond]