Re: [Development] How to write a ChangeLog entry

2014-01-22 Thread Thiago Macieira
On quarta-feira, 22 de janeiro de 2014 09:26:57, Blasche Alexander wrote: > It's the first time that I had to provide a changes file for my modules. > Obviously I was a bit too ambitious ;) but yes: > > qt.gitorious.org/qt/qtconnectivity/blobs/release/dist/changes-5.2.1 Thanks Alex I'll split t

Re: [Development] How to write a ChangeLog entry

2014-01-22 Thread Frederik Gladhorn
Mandag 20. januar 2014 12.59.49 skrev Thiago Macieira: > On segunda-feira, 20 de janeiro de 2014 12:39:04, Thiago Macieira wrote: > > Accessibility > > - > > > > - On Linux action names were returned as empty strings in AT-SPI > > > >getActions, now returns the proper names. >

Re: [Development] How to write a ChangeLog entry

2014-01-22 Thread Blasche Alexander
ject.org > Subject: Re: [Development] How to write a ChangeLog entry > > On terça-feira, 21 de janeiro de 2014 08:09:43, Blasche Alexander wrote: > > Why are you pushing change log items for modules outside of qtbase to > > qtbase? > I'm editing everything in one

Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Samuel Gaist
On 21 janv. 2014, at 00:43, Thiago Macieira wrote: > On segunda-feira, 20 de janeiro de 2014 23:58:21, Samuel Gaist wrote: >> On 20 janv. 2014, at 23:44, Thiago Macieira > wrote: >>> On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote: Yes it does, with that, QLocale supp

Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Thiago Macieira
On terça-feira, 21 de janeiro de 2014 08:09:43, Blasche Alexander wrote: > Why are you pushing change log items for modules outside of qtbase to > qtbase? > > http://qt-project.org/wiki/Change-files-in-Qt-5.2 > > clearly accumulates the various files from the various git repos. I'm editing every

Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Joerg Bornemann
On 20.01.2014 21:59, Thiago Macieira wrote: >> - QProcess: >> * [QTBUG-35357] Fixed a regression from Qt4 in QProcess that >> prevented altering the pipe modes of stdin in the child process. > > I've rewritten this text. Please confirm that it is accurate. I hereby confirm the accurac

Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Blasche Alexander
> -Original Message- > From: development-bounces+alexander.blasche=digia@qt-project.org > [mailto:development-bounces+alexander.blasche=digia@qt-project.org] > On Behalf Of Thiago Macieira > Here's the edited changelog. Please re-read it. You can also find it here: > https://

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 21:46:22, Sune Vuorela wrote: > On 2014-01-20, Thiago Macieira wrote: > > On segunda-feira, 20 de janeiro de 2014 21:30:37, Sune Vuorela wrote: > >> On 2014-01-20, Thiago Macieira wrote: > >> > Windows > >> > --- > >> > >> [QTBUG-35500] Fix printing on

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 23:58:21, Samuel Gaist wrote: > On 20 janv. 2014, at 23:44, Thiago Macieira wrote: > > On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote: > >> Yes it does, with that, QLocale supports the various possible negative > >> signs> > > Can you

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Samuel Gaist
On 20 janv. 2014, at 23:44, Thiago Macieira wrote: > On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote: >> Yes it does, with that, QLocale supports the various possible negative signs > > Can you verify if the change also affects QString::toInt, toDouble, etc.? > > 5.1.1 doe

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote: > Yes it does, with that, QLocale supports the various possible negative signs Can you verify if the change also affects QString::toInt, toDouble, etc.? 5.1.1 doesn't support U+2212. -- Thiago Macieira - thiago.macieira (AT)

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Samuel Gaist
On 20 janv. 2014, at 22:40, Thiago Macieira wrote: > On segunda-feira, 20 de janeiro de 2014 22:21:54, Samuel Gaist wrote: >> On 20 janv. 2014, at 21:59, Thiago Macieira > wrote: QtCore -- - [QTBUG-35069] Fixed a bug that caused negative number input using '-' to

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Sune Vuorela
On 2014-01-20, Thiago Macieira wrote: > On segunda-feira, 20 de janeiro de 2014 21:30:37, Sune Vuorela wrote: >> On 2014-01-20, Thiago Macieira wrote: >> > Windows >> > --- >> >> [QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page >> sizes for system printers. > > Sounds

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 22:21:54, Samuel Gaist wrote: > On 20 janv. 2014, at 21:59, Thiago Macieira wrote: > >> QtCore > >> -- > >> > >> - [QTBUG-35069] Fixed a bug that caused negative number input using '-' > >> to > >> > >> be rejected because the current locale uses e.

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 21:30:37, Sune Vuorela wrote: > On 2014-01-20, Thiago Macieira wrote: > > Windows > > --- > > [QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page > sizes for system printers. Sounds like I should merge with the OS X fix: - [QTBUG-

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Sune Vuorela
On 2014-01-20, Thiago Macieira wrote: > Windows > --- [QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page sizes for system printers. (I would like another sentence about the actual implications. For me, it was that my custom printing code went from 'completely broken' to

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Samuel Gaist
On 20 janv. 2014, at 21:59, Thiago Macieira wrote: > >> QtCore >> -- >> >> - [QTBUG-35069] Fixed a bug that caused negative number input using '-' to >> be rejected because the current locale uses e.g. 0x2212. QIntValidator >> and QDoubleValidator now accepts both signs as well as the l

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
Requesting comments below. On segunda-feira, 20 de janeiro de 2014 12:39:04, Thiago Macieira wrote: > Accessibility > - > > - On Linux action names were returned as empty strings in AT-SPI >getActions, now returns the proper names. Should I move this to QtGui? Or to QtWidgets? O

Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 12:08:37, Thiago Macieira wrote: > Hello everyone > [snip] Here's the edited changelog. Please re-read it. You can also find it here: https://codereview.qt-project.org/76094 If you have updates, please reply to this email or leave a comment in the

[Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
Hello everyone I've attached the raw output of the Qt 5.2.1 changelog, as created by the create_changelog.pl tool. As you can see, it has several mistakes. This email is meant to explain how to properly write a changelog entry in your commit message. The basic format is: [ChangeLog][Major are