Re: [Development] New Qt example development guideline and revamping examples

2023-04-19 Thread Topi Reiniö via Development
07 PM To: Shawn Rutledge ; Qt Development Subject: Re: [Development] New Qt example development guideline and revamping examples ”The point of examples is to show how to use Qt to do specific things. Some of them are redundant? Well there is not only one way to do things; why should we hide some

Re: [Development] New Qt example development guideline and revamping examples

2023-02-03 Thread Tuukka Turunen via Development
, Tuukka From: Development on behalf of Shawn Rutledge via Development Date: Friday, 3. February 2023 at 15.56 To: Qt Development Subject: Re: [Development] New Qt example development guideline and revamping examples On 3 Feb 2023, at 13:56, Tuukka Turunen via Development wrote: pdf

Re: [Development] New Qt example development guideline and revamping examples

2023-02-03 Thread Shawn Rutledge via Development
On 3 Feb 2023, at 13:56, Tuukka Turunen via Development wrote: pdf/pdfviewer Depends which one you mean. They are all new and maintained at this point. There is some redundancy on purpose, because there are multiple PDF-viewing components. So I wouldn’t delete any of them. quick/delegate

Re: [Development] New Qt example development guideline and revamping examples

2023-02-03 Thread Tuukka Turunen via Development
iner) these during February. Yours, Tuukka From: Development on behalf of Kimmo Leppälä via Development Date: Friday, 3. February 2023 at 9.03 To: development@qt-project.org Subject: Re: [Development] New Qt example development guideline and revamping examples Hi, There has

Re: [Development] New Qt example development guideline and revamping examples

2023-02-02 Thread Kimmo Leppälä via Development
Hi, There has been slight modifications to the guideline document https://wiki.qt.io/Qt6/Example-Guideline Most important change being that the examples that are not shown in Qt documentation should be moved under tests/manual/examples. This cleanup should be done preferably during February so

Re: [Development] New Qt example development guideline and revamping examples

2023-01-20 Thread Volker Hilsheimer via Development
On 20 Jan 2023, at 10:45, Tor Arne Vestbø via Development wrote: On 20 Jan 2023, at 09:49, Eike Ziller wrote: Am 19/01/2023 um 13:33 schrieb Giuseppe D'Angelo via Development : Il 19/01/23 10:27, Tor Arne Vestbø ha scritto: All the contrary, do NOT do that, as it results in 200+ lines un

Re: [Development] New Qt example development guideline and revamping examples

2023-01-20 Thread Tor Arne Vestbø via Development
On 20 Jan 2023, at 09:49, Eike Ziller wrote: Am 19/01/2023 um 13:33 schrieb Giuseppe D'Angelo via Development : Il 19/01/23 10:27, Tor Arne Vestbø ha scritto: All the contrary, do NOT do that, as it results in 200+ lines unnamed lambdas. Strongly prefer named slots. Keep the lambdas short an

Re: [Development] New Qt example development guideline and revamping examples

2023-01-20 Thread Eike Ziller via Development
> Am 19/01/2023 um 13:33 schrieb Giuseppe D'Angelo via Development > : > > Il 19/01/23 10:27, Tor Arne Vestbø ha scritto: >>> All the contrary, do NOT do that, as it results in 200+ lines unnamed >>> lambdas. Strongly prefer named slots. Keep the lambdas short and to the >>> point. Do not use

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread A . Pönitz
On Thu, Jan 19, 2023 at 01:44:16PM +, Friedemann Kleint via Development wrote: > Hi, > > we also need to agree on whether the Qt library rules apply to the > full extent; for example: > > - Do we use the modern string literals (u"bla"_s, previously, example > code just constructed QString fro

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread Elvis Stansvik
Den tors 19 jan. 2023 13:34Giuseppe D'Angelo via Development < development@qt-project.org> skrev: > Il 19/01/23 10:27, Tor Arne Vestbø ha scritto: > >> All the contrary, do NOT do that, as it results in 200+ lines unnamed > lambdas. Strongly prefer named slots. Keep the lambdas short and to the >

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread Thiago Macieira
On Thursday, 19 January 2023 05:44:16 PST Friedemann Kleint via Development wrote: > - Do we use the modern string literals (u"bla"_s, previously, example code > just constructed QString from ASCII and did not care about > -DQT_NO_CAST_FROM_ASCII, IIRC) I don't mind using modern string literals,

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread Friedemann Kleint via Development
Hi, we also need to agree on whether the Qt library rules apply to the full extent; for example: - Do we use the modern string literals (u"bla"_s, previously, example code just constructed QString from ASCII and did not care about -DQT_NO_CAST_FROM_ASCII, IIRC) - Should tr() be used for all u

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread Giuseppe D'Angelo via Development
Il 19/01/23 10:27, Tor Arne Vestbø ha scritto: All the contrary, do NOT do that, as it results in 200+ lines unnamed lambdas. Strongly prefer named slots. Keep the lambdas short and to the point. Do not use unnamed lambdas. No, strongly prefer lambdas if they are within a reasonable size. No-o

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread Tor Arne Vestbø via Development
> On 18 Jan 2023, at 13:12, Giuseppe D'Angelo via Development > wrote: > >> RECOMMENDED >>Prefer signal/slot connection with lambdas: >> https://doc.qt.io/qt-6/signalsandslots.html > > All the contrary, do NOT do that, as it results in 200+ lines unnamed > lambdas. Strongly prefer name

Re: [Development] New Qt example development guideline and revamping examples

2023-01-19 Thread Christian Kandeler via Development
On 1/18/23 19:56, A. Pönitz wrote: As a data point, even at it's height of .ui usage, Qt Creator (which is a "namespace aware" code base, see https://wiki.qt.io/Qt_In_Namespace) needed the QT_*_NAMESPACE for about 30 of its >200 .ui classes, and that in the presence of ~680 places where it was n

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Kimmo Leppälä via Development
Hi, Thank you for the proposals Giuseppe! On 18.1.2023, 14.14, "Development" wrote: On 18/01/2023 10:51, Kimmo Leppälä via Development wrote: > Also, the guideline is a living document in wiki and we would be happy > to hear feedback and proposals for it! > Here's a few considerations: > RE

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread A . Pönitz
On Wed, Jan 18, 2023 at 04:10:20PM +, Kai Köhne via Development wrote: > > -Original Message- > >[...] > > > > MANDATORY > > > > > > Do not use QT_BEGIN_NAMESPACE ... QT_END_NAMESPACE for example > > types. This namespace is exclusively for types in the Qt libraries. > > > > This

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Giuseppe D'Angelo via Development
Il 18/01/23 17:10, Kai Köhne ha scritto: (A nasty feature of uic is btw that it also does generate C++ code inside QT_BEGIN_NAMESPACE, QT_END_NAMESPACE. That is, if you have a .ui file for a Dialog, and you want to pre-declare the type generated by uic, you have to also put it in QT_BEGIN_NAME

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Giuseppe D'Angelo via Development
Il 18/01/23 17:10, Kai Köhne ha scritto: Do not use QT_BEGIN_NAMESPACE ... QT_END_NAMESPACE for example types. This namespace is exclusively for types in the Qt libraries. This is broken. How is one going to correctly forward declare Qt names in a namespaced build of Qt without using those

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Kai Köhne via Development
> -Original Message- >[...] > > MANDATORY > > > > Do not use QT_BEGIN_NAMESPACE ... QT_END_NAMESPACE for example > types. This namespace is exclusively for types in the Qt libraries. > > This is broken. How is one going to correctly forward declare Qt names > in a namespaced build of

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Giuseppe D'Angelo via Development
On 18/01/2023 10:51, Kimmo Leppälä via Development wrote: Also, the guideline is a living document in wiki and we would be happy to hear feedback and proposals for it! Here's a few considerations: RECOMMENDED Consider also compiling with the more strict warning flags and fix any issues th

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Tuukka Turunen via Development
Subject: Re: [Development] New Qt example development guideline and revamping examples Hello, I'd like to point to https://bugreports.qt.io/browse/QTBUG-100100 where you can read: "Ah, those examples are in the qtdoc repository, where nobody looks at them..." "Back when we w

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Tuukka Turunen via Development
: [Development] New Qt example development guideline and revamping examples Hi, Should the example updates be picked to 6.5, or is it only a 6.6 thing? Is there any general guideline from the Release Team? Best regards, Ivan From: Development on behalf of Kimmo Leppälä

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Rui Oliveira
Hello, I'd like to point to https://bugreports.qt.io/browse/QTBUG-100100 where you can read: "Ah, those examples are in the qtdoc repository, where nobody looks at them..." "Back when we worked on QTBUG-98130, we forgot to add the examples in qtdoc to the list." Are these going to receive

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Ivan Solovev via Development
: development@qt-project.org Subject: Re: [Development] New Qt example development guideline and revamping examples Also, the guideline is a living document in wiki and we would be happy to hear feedback and proposals for it! -Kimmo From: Kimmo Leppälä Date: Wednesday, 18. January 2023 at

Re: [Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Kimmo Leppälä via Development
Also, the guideline is a living document in wiki and we would be happy to hear feedback and proposals for it! -Kimmo From: Kimmo Leppälä Date: Wednesday, 18. January 2023 at 11.37 To: development@qt-project.org Subject: New Qt example development guideline and revamping examples Hi, We have s

[Development] New Qt example development guideline and revamping examples

2023-01-18 Thread Kimmo Leppälä via Development
Hi, We have started revamping Qt examples (https://doc.qt.io/qt-6/qtexamples.html) to follow the new example development guideline: https://wiki.qt.io/Qt6/Example-Guideline. Target is to go through all the ~600 examples and either modify according the guideline or remove, if the example is obso