Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-15 Thread Olivier Goffart
On 10/13/18 9:03 AM, Boudewijn Rempt wrote: On vrijdag 12 oktober 2018 14:31:33 CEST Konstantin Ritt wrote: It didn't. Then what else made it necessary to suddenly add lots of #include lines? Maybe that was commit 000c76ada5cc21479fc479be16a7507fed6490f8 ? The commit you mentioned does n

Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-13 Thread Giuseppe D'Angelo via Development
Hi, Il 13/10/2018 09:03, Boudewijn Rempt ha scritto: Then what else made it necessary to suddenly add lots of #include lines? I still don't get it, how is that possible? * If we're talking about a SIC internal to Qt, that is, some other part of Qt not building because of that change, that o

Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-13 Thread Boudewijn Rempt
On vrijdag 12 oktober 2018 14:31:33 CEST Konstantin Ritt wrote: > It didn't. Then what else made it necessary to suddenly add lots of #include lines? -- https://www.krita.org signature.asc Description: This is a digitally signed message part. ___ De

Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-13 Thread Boudewijn Rempt
On vrijdag 12 oktober 2018 15:57:35 CEST Mathias Hasselmann wrote: > Hi Boudewijn, > > these kind of refactorings are neccessary to keep code maintainable I fear. Well... If code stops building from Qt 5 to another Qt 5, that means that thousands of projects have to change their code. Thousands

Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-12 Thread Mathias Hasselmann
Hi Boudewijn, these kind of refactorings are neccessary to keep code maintainable I fear. Anyway, it seems like you are maintaining a bunch of custom patches on top of Qt? How about reducing your maintainance burden by upstreaming them? Qt would benefit from bugfixes and new features. You woul

Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-12 Thread Konstantin Ritt
It didn't. Regards, Konstantin пт, 12 окт. 2018 г. в 13:59, Giuseppe D'Angelo via Development < development@qt-project.org>: > Hello, > > Il 12/10/2018 12:48, b...@valdyas.org ha scritto: > > Which of course breaks source compatibility. It's bad enough to have to > > adapt one's codebase; but t

Re: [Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-12 Thread Giuseppe D'Angelo via Development
Hello, Il 12/10/2018 12:48, b...@valdyas.org ha scritto: Which of course breaks source compatibility. It's bad enough to have to adapt one's codebase; but this also makes it impossible to bisect code when Qt 5.11 is installed that had to be adapted. I'm constantly running into this problem. Wou

[Development] QButtonGroup: When the "right thing to do" is absolutely the wrong thing to do

2018-10-12 Thread boud
So, there's this commit: https://git.qt.io/consulting-usa/qtbase-xcb-rendering/commit/69335920f724d2d4a49924f373c4fef57c942831 " Move QButtonGroup implementation from qabstractbutton.cpp to qbuttongroup.cpp Because it's the right thing to do. Needed to introduce qbuttongroup_p.h because QAbs