Re: [Development] Qt 5.3 header diff: QtQml

2014-04-23 Thread Knoll Lars
Look ok to me. Lars On 23/04/14 12:55, "Simon Hausmann" wrote: >On Tuesday 22. April 2014 14.12.46 Thiago Macieira wrote: >> http://macieira.org/~thiago/qt-5.3/QtQml.diff > >I think those changes look okay. > >The bulk of the work going into Qml right now is all focused on the >internals >firs

Re: [Development] Qt 5.3 header diff: QtQml

2014-04-23 Thread Simon Hausmann
On Tuesday 22. April 2014 14.12.46 Thiago Macieira wrote: > http://macieira.org/~thiago/qt-5.3/QtQml.diff I think those changes look okay. The bulk of the work going into Qml right now is all focused on the internals first. Simon ___ Development maili

Re: [Development] Qt 5.3 header diff: QtQml

2014-04-23 Thread Simon Hausmann
On Tuesday 22. April 2014 16.37.06 Thiago Macieira wrote: > Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: > > diff --git a/src/qml/qml/qqmlprivate.h b/src/qml/qml/qqmlprivate.h > > Why do we have a public header with "private" in the name? It part of the "private" interface into the

Re: [Development] Qt 5.3 header diff: QtQml

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: > diff --git a/src/qml/qml/qqmlprivate.h b/src/qml/qml/qqmlprivate.h Why do we have a public header with "private" in the name? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

[Development] Qt 5.3 header diff: QtQml

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtQml.diff diff --git a/src/qml/qml/qqml.h b/src/qml/qml/qqml.h index b6c6fe8..721f2cc 100644 --- a/src/qml/qml/qqml.h +++ b/src/qml/qml/qqml.h @@ -91,13 +91,13 @@ class QQmlPropertyValueInterceptor; const char *className = T::staticMetaObject.className(); \