Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-20 Thread Alejandro Exojo
El Wednesday 19 November 2014, Thiago Macieira escribió: On Tuesday 18 November 2014 16:24:05 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn wrote: Attached the wrong file. Probably irrelevant, but, on which branch was the script run? On both 5.4.0 and 5.4 (as

Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-20 Thread Alejandro Exojo
El Thursday 20 November 2014, Alejandro Exojo escribió: El Wednesday 19 November 2014, Thiago Macieira escribió: On Tuesday 18 November 2014 16:24:05 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn wrote: Attached the wrong file. Probably irrelevant, but,

Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-20 Thread Thiago Macieira
On Thursday 20 November 2014 12:08:45 Alejandro Exojo wrote: El Thursday 20 November 2014, Alejandro Exojo escribió: El Wednesday 19 November 2014, Thiago Macieira escribió: On Tuesday 18 November 2014 16:24:05 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn

Re: [Development] Qt 5.4.0 header diff: QtWidgets.diff

2014-11-19 Thread Giuseppe D'Angelo
Thanks for the simplified diff, question: index b603415..7193f69 100644 --- a/src/widgets/widgets/qrubberband.h +++ b/src/widgets/widgets/qrubberband.h @@ -196,6 +196,7 @@ protected: #endif void keyPressEvent(QKeyEvent *); void changeEvent(QEvent *); +void timerEvent(QTimerEvent

Re: [Development] Qt 5.4.0 header diff: QtWidgets.diff

2014-11-19 Thread Thiago Macieira
On Wednesday 19 November 2014 09:22:46 Giuseppe D'Angelo wrote: Was adding a new override in the middle of an hierarchy safe? Or subclasses in user code will now require a recompilation? (Not a big deal, I don't expect that many QRubberBand subclasses with a timerEvent override...)

Re: [Development] Qt 5.4.0 header diff: QtWidgets.diff

2014-11-19 Thread Giuseppe D'Angelo
Il 19/11/2014 09:35, Thiago Macieira ha scritto: On Wednesday 19 November 2014 09:22:46 Giuseppe D'Angelo wrote: Was adding a new override in the middle of an hierarchy safe? Or subclasses in user code will now require a recompilation? (Not a big deal, I don't expect that many QRubberBand

Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Giuseppe D'Angelo
Il 19/11/2014 01:23, Thiago Macieira ha scritto: On Tuesday 18 November 2014 16:38:33 Frederik Gladhorn wrote: Attaching simpler diff. The diff is still huge because it trips over a massive change in Khronos headers, which are 3rd party -- we have no control over those. Should we move

Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Giuseppe D'Angelo
ABI break (changing a private static in a public exported class)? --- a/src/gui/text/qfontdatabase.h +++ b/src/gui/text/qfontdatabase.h @@ -160,14 +152,14 @@ private: static void createDatabase(); static void parseFontName(const QString name, QString foundry, QString family);

Re: [Development] Qt 5.4.0 header diff: QtWidgets.diff

2014-11-19 Thread Knoll Lars
On 19/11/14 09:46, Giuseppe D'Angelo giuseppe.dang...@kdab.com wrote: Il 19/11/2014 09:35, Thiago Macieira ha scritto: On Wednesday 19 November 2014 09:22:46 Giuseppe D'Angelo wrote: Was adding a new override in the middle of an hierarchy safe? Or subclasses in user code will now require a

Re: [Development] Qt 5.4.0 header diff: QtGui.diff

2014-11-19 Thread Knoll Lars
On 19/11/14 11:59, Knoll Lars lars.kn...@theqtcompany.com wrote: API and style mistake -- the new constructor should very likely be protected (useful only from subclasses?), but the private should be passed by reference (or QOpenGLPaintDevice(0) gives a cryptic error): class Q_GUI_EXPORT

[Development] Qt 5.4.0 header diff

2014-11-18 Thread Frederik Gladhorn
Found module QtAndroidExtras in ./qtandroidextras/src/androidextras/androidextras.pro - No public headers for module QtAndroidExtras Found module QtConcurrent in ./qtbase/src/concurrent/concurrent.pro - Module has 15 public headers now - QtConcurrent.diff created Found module QtCore in

[Development] Qt 5.4.0 header diff: QtXmlPatterns.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/xmlpatterns/api/qabstractmessagehandler.h b/src/xmlpatterns/api/qabstractmessagehandler.h index cf62754..a43c01e 100644 --- a/src/xmlpatterns/api/qabstractmessagehandler.h +++ b/src/xmlpatterns/api/qabstractmessagehandler.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public

[Development] Qt 5.4.0 header diff: QtXml.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/xml/dom/qdom.h b/src/xml/dom/qdom.h index f1c04a4..7c5dc7f 100644 --- a/src/xml/dom/qdom.h +++ b/src/xml/dom/qdom.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the GNU Lesser -** General Public

[Development] Qt 5.4.0 header diff: QtX11Extras.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/x11extras/qtx11extrasglobal.h b/src/x11extras/qtx11extrasglobal.h index ce59c21..c30f1bb 100644 --- a/src/x11extras/qtx11extrasglobal.h +++ b/src/x11extras/qtx11extrasglobal.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be

[Development] Qt 5.4.0 header diff: QtWebSockets.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/websockets/qmaskgenerator.h b/src/websockets/qmaskgenerator.h index a93ed01..b8748c3 100644 --- a/src/websockets/qmaskgenerator.h +++ b/src/websockets/qmaskgenerator.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used

[Development] Qt 5.4.0 header diff: QtSvg.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/svg/qgraphicssvgitem.h b/src/svg/qgraphicssvgitem.h index 09cda2a..1626131 100644 --- a/src/svg/qgraphicssvgitem.h +++ b/src/svg/qgraphicssvgitem.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the

[Development] Qt 5.4.0 header diff: QtScriptTools.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/scripttools/debugging/qscriptenginedebugger.h b/src/scripttools/debugging/qscriptenginedebugger.h index 9589f65..dfeac90 100644 --- a/src/scripttools/debugging/qscriptenginedebugger.h +++ b/src/scripttools/debugging/qscriptenginedebugger.h @@ -16,25 +16,17 @@ ** ** GNU Lesser

[Development] Qt 5.4.0 header diff: QtSerialPort.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h index 8a0bbb1..a8f9a05 100644 --- a/src/serialport/qserialport.h +++ b/src/serialport/qserialport.h @@ -17,25 +17,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms

[Development] Qt 5.4.0 header diff: QtQuick.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/quick/designer/designersupport.h b/src/quick/designer/designersupport.h index 41458ae..59f0cf2 100644 --- a/src/quick/designer/designersupport.h +++ b/src/quick/designer/designersupport.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this

[Development] Qt 5.4.0 header diff: QtPrintSupport.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/printsupport/dialogs/qabstractprintdialog.h b/src/printsupport/dialogs/qabstractprintdialog.h index 8797931..f3e865e 100644 --- a/src/printsupport/dialogs/qabstractprintdialog.h +++ b/src/printsupport/dialogs/qabstractprintdialog.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General

[Development] Qt 5.4.0 header diff: QtOpenGLExtensions.diff

2014-11-18 Thread Frederik Gladhorn
___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

[Development] Qt 5.4.0 header diff: QtNfc.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/nfc/qndeffilter.h b/src/nfc/qndeffilter.h index 5b121cc..053dfe2 100644 --- a/src/nfc/qndeffilter.h +++ b/src/nfc/qndeffilter.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the GNU Lesser -**

[Development] Qt 5.4.0 header diff: QtMultimediaWidgets.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/multimediawidgets/qcameraviewfinder.h b/src/multimediawidgets/qcameraviewfinder.h index 4b3f7d0..5467574 100644 --- a/src/multimediawidgets/qcameraviewfinder.h +++ b/src/multimediawidgets/qcameraviewfinder.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage **

[Development] Qt 5.4.0 header diff: QtDBus.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/dbus/qdbusabstractadaptor.h b/src/dbus/qdbusabstractadaptor.h index 2a32344..7344335 100644 --- a/src/dbus/qdbusabstractadaptor.h +++ b/src/dbus/qdbusabstractadaptor.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used

[Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/sql/kernel/qsql.h b/src/sql/kernel/qsql.h index 9b9381f..49377d4 100644 --- a/src/sql/kernel/qsql.h +++ b/src/sql/kernel/qsql.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the GNU Lesser -**

[Development] Qt 5.4.0 header diff: QtTest.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/testlib/qbenchmark.h b/src/testlib/qbenchmark.h index ea5023c..de4f9a1 100644 --- a/src/testlib/qbenchmark.h +++ b/src/testlib/qbenchmark.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the GNU

[Development] Qt 5.4.0 header diff: QtQuickTest.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/qmltest/quicktest.h b/src/qmltest/quicktest.h index d6ffcf8..aa34e0f 100644 --- a/src/qmltest/quicktest.h +++ b/src/qmltest/quicktest.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the GNU Lesser

[Development] Qt 5.4.0 header diff: QtSensors.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/sensors/gestures/qsensorgesture.h b/src/sensors/gestures/qsensorgesture.h index 5ae7bb2..e8e1853 100644 --- a/src/sensors/gestures/qsensorgesture.h +++ b/src/sensors/gestures/qsensorgesture.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively,

[Development] Qt 5.4.0 header diff: QtQml.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/qml/debugger/qqmldebug.h b/src/qml/debugger/qqmldebug.h index d6b6bb0..876d068 100644 --- a/src/qml/debugger/qqmldebug.h +++ b/src/qml/debugger/qqmldebug.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms

[Development] Qt 5.4.0 header diff: QtPositioning.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/positioning/qgeoaddress.h b/src/positioning/qgeoaddress.h index 1aedd1a..93a5c19 100644 --- a/src/positioning/qgeoaddress.h +++ b/src/positioning/qgeoaddress.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the

[Development] Qt 5.4.0 header diff: QtMultimediaQuick_p.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/qtmultimediaquicktools/qsgvideonode_i420.h b/src/qtmultimediaquicktools/qsgvideonode_i420.h index a9def55..06d302d 100644 --- a/src/qtmultimediaquicktools/qsgvideonode_i420.h +++ b/src/qtmultimediaquicktools/qsgvideonode_i420.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public

[Development] Qt 5.4.0 header diff: QtConcurrent.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/concurrent/qtconcurrent_global.h b/src/concurrent/qtconcurrent_global.h index 965d33f..5f09a1b 100644 --- a/src/concurrent/qtconcurrent_global.h +++ b/src/concurrent/qtconcurrent_global.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this

[Development] Qt 5.4.0 header diff: QtLocation.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/location/maps/qgeocodereply.h b/src/location/maps/qgeocodereply.h index 4305531..a30a863 100644 --- a/src/location/maps/qgeocodereply.h +++ b/src/location/maps/qgeocodereply.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be

[Development] Qt 5.4.0 header diff: QtDeclarative.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/declarative/debugger/qdeclarativedebug.h b/src/declarative/debugger/qdeclarativedebug.h index b425060..e5aba61 100644 --- a/src/declarative/debugger/qdeclarativedebug.h +++ b/src/declarative/debugger/qdeclarativedebug.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License

[Development] Qt 5.4.0 header diff: QtQuickWidgets.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/quickwidgets/qquickwidget.h b/src/quickwidgets/qquickwidget.h index 4287933..530a523 100644 --- a/src/quickwidgets/qquickwidget.h +++ b/src/quickwidgets/qquickwidget.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used

[Development] Qt 5.4.0 header diff: QtScript.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/script/api/qtscriptglobal.h b/src/script/api/qtscriptglobal.h index 1b74cf6..ecb3708 100644 --- a/src/script/api/qtscriptglobal.h +++ b/src/script/api/qtscriptglobal.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used

[Development] Qt 5.4.0 header diff: QtBluetooth.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/bluetooth/qbluetooth.h b/src/bluetooth/qbluetooth.h index b13c004..ebe546f 100644 --- a/src/bluetooth/qbluetooth.h +++ b/src/bluetooth/qbluetooth.h @@ -16,30 +16,21 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the

[Development] Qt 5.4.0 header diff: QtOpenGL.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/opengl/qgl.h b/src/opengl/qgl.h index 72fe7b8..482c215 100644 --- a/src/opengl/qgl.h +++ b/src/opengl/qgl.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage ** Alternatively, this file may be used under the terms of the GNU Lesser -** General Public License

[Development] Qt 5.4.0 header diff: QtNetwork.diff

2014-11-18 Thread Frederik Gladhorn
diff --git a/src/network/access/qabstractnetworkcache.h b/src/network/access/qabstractnetworkcache.h index b9a086f..b563090 100644 --- a/src/network/access/qabstractnetworkcache.h +++ b/src/network/access/qabstractnetworkcache.h @@ -16,25 +16,17 @@ ** ** GNU Lesser General Public License Usage

Re: [Development] Qt 5.4.0 header diff: QtX11Extras.diff

2014-11-18 Thread Richard Moore
This one is fine. Rich. On 18 November 2014 14:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:19:29 Frederik Gladhorn wrote: Modules with no public headers: QtAndroidExtras QtMacExtras QtWinExtras I'm guessing that's because you ran on Linux and the necessary bits from syncqt aren't present. -- Thiago Macieira - thiago.macieira

Re: [Development] Qt 5.4.0 header diff: QtXmlPatterns.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:37:12 Frederik Gladhorn wrote: Looks good. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org

Re: [Development] Qt 5.4.0 header diff: QtXml.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:21 Frederik Gladhorn wrote: No changes. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org

Re: [Development] Qt 5.4.0 header diff

2014-11-18 Thread Giuseppe D'Angelo
Erk... would it be possible to resend the diff EXCLUDING the license header changes? The Gui/Widgets header diffs are huge... On 18 November 2014 19:03, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:19:29 Frederik Gladhorn wrote: Modules with no public headers:

Re: [Development] Qt 5.4.0 header diff: QtSvg.diff

2014-11-18 Thread Knoll Lars
Ok. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtSerialPort.diff

2014-11-18 Thread Knoll Lars
Ok as well. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtWebSockets.diff

2014-11-18 Thread Knoll Lars
This one is ok. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtPrintSupport.diff

2014-11-18 Thread Knoll Lars
Ok. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtScriptTools.diff

2014-11-18 Thread Knoll Lars
Ok. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtQuickWidgets.diff

2014-11-18 Thread Knoll Lars
Ok. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtQuick.diff

2014-11-18 Thread Knoll Lars
Ok as well. Lars On 18/11/14 15:38, Frederik Gladhorn frederik.gladh...@theqtcompany.com wrote: ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.4.0 header diff: QtNfc.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:30 Frederik Gladhorn wrote: No changes, ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org

Re: [Development] Qt 5.4.0 header diff: QtMultimediaWidgets.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:31 Frederik Gladhorn wrote: No changes, ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org

Re: [Development] Qt 5.4.0 header diff: QtMultimedia.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:32 Frederik Gladhorn wrote: One change, ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list Development@qt-project.org

Re: [Development] Qt 5.4.0 header diff: QtMultimedia.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:32 Frederik Gladhorn wrote: Simpler diff. Looks fine. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/multimedia/audio/qaudio.h b/src/multimedia/audio/qaudio.h index

Re: [Development] Qt 5.4.0 header diff: QtDBus.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:34 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/dbus/qdbusabstractadaptor.h b/src/dbus/qdbusabstractadaptor.h index 2a32344..7344335 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtTest.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:54 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/testlib/qbenchmark.h b/src/testlib/qbenchmark.h index ea5023c..de4f9a1 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtWidgets.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:54 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/widgets/accessible/qaccessiblewidget.h b/src/widgets/accessible/qaccessiblewidget.h index

Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/svg/qgraphicssvgitem.h b/src/svg/qgraphicssvgitem.h index 09cda2a..1626131 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtConcurrent.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:35 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/concurrent/qtconcurrent_global.h b/src/concurrent/qtconcurrent_global.h index 965d33f..5f09a1b 100644

Re: [Development] Qt 5.4.0 header diff: QtScript.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:57 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/script/api/qtscriptglobal.h b/src/script/api/qtscriptglobal.h index 1b74cf6..ecb3708 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtQml.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:58 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/qml/debugger/qqmldebug.h b/src/qml/debugger/qqmldebug.h index d6b6bb0..876d068 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtSensors.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:56 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/sensors/gestures/qsensorgesture.h b/src/sensors/gestures/qsensorgesture.h index 5ae7bb2..e8e1853 100644

Re: [Development] Qt 5.4.0 header diff: QtQuickTest.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:58 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/qmltest/quicktest.h b/src/qmltest/quicktest.h index d6ffcf8..aa34e0f 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtPositioning.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:38:59 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/positioning/qgeoaddress.h b/src/positioning/qgeoaddress.h index 1aedd1a..93a5c19 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtOpenGL.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:39:00 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/opengl/qgl.h b/src/opengl/qgl.h index 72fe7b8..482c215 100644 --- a/src/opengl/qgl.h +++

Re: [Development] Qt 5.4.0 header diff: QtNetwork.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:39:01 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/network/access/qabstractnetworkcache.h b/src/network/access/qabstractnetworkcache.h index

Re: [Development] Qt 5.4.0 header diff: QtLocation.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:39:07 Frederik Gladhorn wrote: Not a released module. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development mailing list

Re: [Development] Qt 5.4.0 header diff: QtDeclarative.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:39:08 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/declarative/debugger/qdeclarativedebug.h b/src/declarative/debugger/qdeclarativedebug.h index

Re: [Development] Qt 5.4.0 header diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 19:24:13 Giuseppe D'Angelo wrote: Erk... would it be possible to resend the diff EXCLUDING the license header changes? The Gui/Widgets header diffs are huge... Done. The old header was actually 41 lines long. I had the threshold for this is the header at 40 lines.

Re: [Development] Qt 5.4.0 header diff: QtBluetooth.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:39:09 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/bluetooth/qbluetooth.h b/src/bluetooth/qbluetooth.h index b13c004..ebe546f 100644 ---

Re: [Development] Qt 5.4.0 header diff: QtDBus.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:23:29 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:34 Frederik Gladhorn wrote: No changes, ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtTest.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:23:52 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:54 Frederik Gladhorn wrote: Looks ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___

Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:24:05 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn wrote: No changes, looks ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:24:05 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn wrote: Attached the wrong file. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center diff --git a/src/sql/kernel/qsql.h

Re: [Development] Qt 5.4.0 header diff: QtSensors.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:24:10 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:56 Frederik Gladhorn wrote: No changes, ok -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtPositioning.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:24:33 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:59 Frederik Gladhorn wrote: No changes, ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtScript.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:24:18 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:57 Frederik Gladhorn wrote: No changes, looks ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtOpenGL.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:24:41 Thiago Macieira wrote: On Tuesday 18 November 2014 16:39:00 Frederik Gladhorn wrote: No changes, ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtCore.diff

2014-11-18 Thread Thiago Macieira
Impressive number of ### Qt6 comments we're adding... qjsonobject.h -//typedef T *pointer; typedef QJsonValueRef reference; Missing typedef for pointer, like was done for QJsonArray --- a/src/corelib/thread/qmutex.h +++ b/src/corelib/thread/qmutex.h @@ -101,10 +93,6 @@

Re: [Development] Qt 5.4.0 header diff: QtDeclarative.diff

2014-11-18 Thread Thiago Macieira
No changes. On Tuesday 18 November 2014 16:25:07 Thiago Macieira wrote: On Tuesday 18 November 2014 16:39:08 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___

Re: [Development] Qt 5.4.0 header diff: QtSql.diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:54:47 Thiago Macieira wrote: On Tuesday 18 November 2014 16:24:05 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:55 Frederik Gladhorn wrote: Attached the wrong file. Looks ok. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect -

Re: [Development] Qt 5.4.0 header diff: QtTest.diff

2014-11-18 Thread Jason McDonald
On Wed, Nov 19, 2014 at 10:53 AM, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:23:52 Thiago Macieira wrote: On Tuesday 18 November 2014 16:38:54 Frederik Gladhorn wrote: Looks ok. +1 -- Jason ___ Development

Re: [Development] Qt 5.4.0 header diff

2014-11-18 Thread Jason McDonald
On Wed, Nov 19, 2014 at 10:25 AM, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 19:24:13 Giuseppe D'Angelo wrote: Erk... would it be possible to resend the diff EXCLUDING the license header changes? The Gui/Widgets header diffs are huge... Done. The old

Re: [Development] Qt 5.4.0 header diff

2014-11-18 Thread Heikkinen Jani
=theqtcompany@qt-project.org] On Behalf Of Jason McDonald Sent: 19. marraskuuta 2014 5:56 To: Thiago Macieira Cc: development Subject: Re: [Development] Qt 5.4.0 header diff On Wed, Nov 19, 2014 at 10:25 AM, Thiago Macieira thiago.macie...@intel.commailto:thiago.macie...@intel.com wrote: On Tuesday 18

Re: [Development] Qt 5.4.0 header diff: QtWidgets.diff

2014-11-18 Thread Knoll Lars
Looks good to me. Lars On 19/11/14 01:23, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:38:54 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtQuickTest.diff

2014-11-18 Thread Knoll Lars
No changes. Ok. Lars On 19/11/14 01:24, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:38:58 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtQml.diff

2014-11-18 Thread Knoll Lars
Ok as well. Lars On 19/11/14 01:24, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:38:58 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtNetwork.diff

2014-11-18 Thread Knoll Lars
Looks ok as well. Lars On 19/11/14 01:24, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:39:01 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff: QtBluetooth.diff

2014-11-18 Thread Knoll Lars
Looks ok as well. Lars On 19/11/14 01:25, Thiago Macieira thiago.macie...@intel.com wrote: On Tuesday 18 November 2014 16:39:09 Frederik Gladhorn wrote: -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.4.0 header diff

2014-11-18 Thread Thiago Macieira
On Tuesday 18 November 2014 16:25:56 Thiago Macieira wrote: On Tuesday 18 November 2014 19:24:13 Giuseppe D'Angelo wrote: Erk... would it be possible to resend the diff EXCLUDING the license header changes? The Gui/Widgets header diffs are huge... Done. The old header was actually 41

Re: [Development] Qt 5.4.0 header diff: QtCore.diff

2014-11-18 Thread Morten Johan Sørvig
On 19 Nov 2014, at 02:22, Thiago Macieira thiago.macie...@intel.com wrote: Impressive number of ### Qt6 comments we're adding... Should we mandate that the pattern for doing this is #if QT_VERSION = QT_VERSION_CHECK(6,0,0) and then actually writing the Qt 6 code? There are a couple of

Re: [Development] Qt 5.4.0 header diff: QtCore.diff

2014-11-18 Thread Thiago Macieira
On Wednesday 19 November 2014 08:52:41 Morten Johan Sørvig wrote: On 19 Nov 2014, at 02:22, Thiago Macieira thiago.macie...@intel.com wrote: Impressive number of ### Qt6 comments we're adding... Should we mandate that the pattern for doing this is #if QT_VERSION =