Re: [Development] RFD: Removing environment variable support from configure

2016-03-19 Thread Oswald Buddenhagen
On Thu, Mar 17, 2016 at 01:45:44PM -0700, Thiago Macieira wrote: > Summary: if CXXFLAGS is set on the environment when you run configure, the OS > X > build breaks. > > This happened because we don't test the building while those flags are set. > > I'm proposing we drop even checking them

Re: [Development] RFD: Removing environment variable support from configure

2016-03-19 Thread Olivier Goffart
Am Donnerstag, 17. März 2016, 21:31:27 CET schrieb Knoll Lars: > Yes, let's drop this. Btw, I'm currently anyway working on changing how > configuration handling is done for Qt, so there will be some changes in > this area coming for Qt 5.8. How then are we going to insert custom compiler flags?

Re: [Development] RFD: Removing environment variable support from configure

2016-03-19 Thread Marc Mutz
On Friday 18 March 2016 15:44:14 Oswald Buddenhagen wrote: > instead, configure needs to be fed these options explicitly. after all, > we already do it for a bunch of specific options: -I/-L/-l/-F/-fw. we > could add some more options like that, or alternatively parse variable > assignments like

Re: [Development] RFD: Removing environment variable support from configure

2016-03-19 Thread Oswald Buddenhagen
On Fri, Mar 18, 2016 at 04:02:22PM +0100, Marc Mutz wrote: > On Friday 18 March 2016 15:44:14 Oswald Buddenhagen wrote: > > instead, configure needs to be fed these options explicitly. after all, > > we already do it for a bunch of specific options: -I/-L/-l/-F/-fw. we > > could add some more

[Development] RFD: Removing environment variable support from configure

2016-03-19 Thread Thiago Macieira
See below for more details. Summary: if CXXFLAGS is set on the environment when you run configure, the OS X build breaks. This happened because we don't test the building while those flags are set. I'm proposing we drop even checking them (configure lines 556 to 580). If you disagree and you

Re: [Development] RFD: Removing environment variable support from configure

2016-03-19 Thread Knoll Lars
Yes, let's drop this. Btw, I'm currently anyway working on changing how configuration handling is done for Qt, so there will be some changes in this area coming for Qt 5.8. Cheers, Lars On 17/03/16 21:45, "Development on behalf of Thiago Macieira"