[Development] Review Request (qtdeclarative): Add imageSourceSize property to QQuickDrag

2023-12-10 Thread Wang Gary
Hi, I have a patch submitted a few weeks ago, intended to add a property to QQuickDrag to allow set a source size to tell the image provider the preferred size of the image. Kindly request for review. Thanks! Patch link: https://codereview.qt-project.org/c/qt/qtdeclarative/+/518814 --

Re: [Development] Review request

2017-10-31 Thread Frederik Gladhorn
Hi, I just moved the changes to dev. They fix P2s which is great, but in my opinion we should target dev by default. If there is agreement that they should go to other branches, we can move them again. Cheers, Frederik On søndag 29. oktober 2017 20.45.53 CET Thiago Macieira wrote: > On

Re: [Development] Review request

2017-10-30 Thread Thiago Macieira
On domingo, 29 de outubro de 2017 23:50:01 PDT Alberto Mardegan wrote: > On 29/10/2017 22:45, Thiago Macieira wrote: > > I wish I could help in the reviews, but those are not things I understand > > at all. But I can give this advice: the three changes targetting pre-5.9 > > need to be updated.

Re: [Development] Review request

2017-10-30 Thread Alberto Mardegan
On 29/10/2017 22:45, Thiago Macieira wrote: > I wish I could help in the reviews, but those are not things I understand at > all. But I can give this advice: the three changes targetting pre-5.9 need to > be updated. All three should be retargetted at 5.9. Good to know! I'll resubmit them,

Re: [Development] Review request

2017-10-29 Thread Thiago Macieira
On Sunday, 29 October 2017 11:52:02 PDT Alberto Mardegan wrote: > Hi there! > I've got a few merge proposals which were recently closed by the Qt > cleanup bot due to lack of activity; I've reopened them and ping a few > people, but to no avail. > All but one are tiny, and I would appreciate if

[Development] Review request

2017-10-29 Thread Alberto Mardegan
Hi there! I've got a few merge proposals which were recently closed by the Qt cleanup bot due to lack of activity; I've reopened them and ping a few people, but to no avail. All but one are tiny, and I would appreciate if someone could spend a couple of minutes to give the final +2 or to advise

[Development] [Review Request][Draft] CMake project for QtIFW

2016-07-18 Thread Konstantin Podsvirov
Hello guys! I like CMake and Qt and i initial write and now support CPack IFW generator. For more project integrations i create sugestion: https://bugreports.qt.io/browse/QTIFW-876 And start work on it: https://codereview.qt-project.org/#/c/165493 It's draft, but any feedback will be

Re: [Development] Review request for ArrayBuffer+WebSocket/XHR (a.k.a Introducing protobuf-qml)

2015-12-20 Thread Nobuaki Sukegawa
obuaki Sukegawa <nsu...@gmail.com> > *Sent:* Saturday, December 12, 2015 12:59 > *To:* development@qt-project.org > *Subject:* [Development] Review request for ArrayBuffer+WebSocket/XHR > (a.k.a Introducing protobuf-qml) > > Hello Qt team and community, > > Could anyone h

Re: [Development] Review request for ArrayBuffer+WebSocket/XHR (a.k.a Introducing protobuf-qml)

2015-12-18 Thread Hausmann Simon
a chat about it there? :) Simon From: Development <development-boun...@qt-project.org> on behalf of Nobuaki Sukegawa <nsu...@gmail.com> Sent: Saturday, December 12, 2015 12:59 To: development@qt-project.org Subject: [Development] Review request for

[Development] Review request for ArrayBuffer+WebSocket/XHR (a.k.a Introducing protobuf-qml)

2015-12-12 Thread Nobuaki Sukegawa
Hello Qt team and community, Could anyone help me with reviews on ArrayBuffer support for QtWebSockets and QtQuick XMLHttpRequest ? WebSockets: https://codereview.qt-project.org/#/c/125712/ XHR: https://codereview.qt-project.org/#/c/143732/ While I believe these features are generally useful,