Re: [Development] Undeprecating QString::null

On Tuesday, 16 January 2018 10:28:27 PST Uwe Rathmann wrote: > On Tue, 16 Jan 2018 18:38:48 +0100, Kevin Kofler wrote: > > So just use QString(), or define your own static instance of it if you > > really want to microoptimize it that much. > > No it is simply that the first version of Qwt was

Re: [Development] Undeprecating QString::null

On Tue, 16 Jan 2018 18:38:48 +0100, Kevin Kofler wrote: > So just use QString(), or define your own static instance of it if you > really want to microoptimize it that much. No it is simply that the first version of Qwt was for Qt 1.2 ( before QString even existed ) and during a history of

Re: [Development] Undeprecating QString::null

Uwe Rathmann wrote: > So my first question would be, what is wrong about using QString:null and > why using QString() is better. My second question then would be if this > is also for Qt4 ( Qwt 6.1.2 supports all versions >= Qt 4.4 ) and older > versions of C++ and compilers. A long long time

Re: [Development] Undeprecating QString::null

On Tue, 16 Jan 2018 17:54:43 +0100, Giuseppe D'Angelo wrote: > headers of 3rd party libraries > should be included under -isystem, not -I, to disable warnings in their > headers. Yes as there seems to be no BC break ( thanks to all correcting me, I should have a deeper look at the code before )

Re: [Development] Undeprecating QString::null

No it isn‘t about you. But your message suggested you blame it on Qt project ;) Anyway, default values are not part of a functions signature and don’t break binary compatibility. Beste Grüße / Best regards, Alexander Nassian > Am 16.01.2018 um 17:46 schrieb Uwe Rathmann

Re: [Development] Undeprecating QString::null

Il 16/01/2018 16:20, Uwe Rathmann ha scritto: Sure this is only a warning, but it is obviously something where Qwt users get irritated as they can't fix code of a 3rd party header. Changing to QString() is BC, as explained, so just do that. Note that this is actually a buildsystem issue:

Re: [Development] Undeprecating QString::null

On Tue, 16 Jan 2018 17:26:51 +0100, Alexander Nassian wrote: > Deprecated since Qt4 ... According to qstring.h: #if QT_DEPRECATED_SINCE(5, 9) ... #endif But come this is not about me and if I missed, that an API has been declared as deprecated. It is about what to best in the current

Re: [Development] Undeprecating QString::null

changing the parameter's default value *is* binary compatible. Regards, Konstantin 2018-01-16 20:35 GMT+04:00 Jean-Michaël Celerier < jeanmichael.celer...@gmail.com>: > > The "just change" introduces a binary incompatibility - right ? > > I don't think it does: the QString is constructed on

Re: [Development] Undeprecating QString::null

> On Jan 16, 2018, at 17:16, Uwe Rathmann wrote: > > On Tue, 16 Jan 2018 16:47:57 +0100, Olivier Goffart wrote: > >> Just change your code to use "= QString()", no #ifdef necessary. > > The "just change" introduces a binary incompatibility - right ? I don’t see why

Re: [Development] Undeprecating QString::null

> The "just change" introduces a binary incompatibility - right ? I don't think it does: the QString is constructed on the caller's side anyways and your function is always passed a QString object; if you had an app that linked to qwt and didn't recompile it will just keep calling QString::null()

Re: [Development] Undeprecating QString::null

Deprecated since Qt4 (so it survived already two versions that were allowed to break binary compatibility) means that you had 12 (twelve) years to do the migration. How long should it be maintained? And again, it also could have been removed in Qt4 or 5. > Am 16.01.2018 um 17:16 schrieb Uwe

Re: [Development] Undeprecating QString::null

16.01.2018, 19:18, "Uwe Rathmann" : > On Tue, 16 Jan 2018 16:47:57 +0100, Olivier Goffart wrote: > >>  Just change your code to use "= QString()", no #ifdef necessary. > > The "just change" introduces a binary incompatibility - right ? > > Please be aware, that Qwt is

Re: [Development] Undeprecating QString::null

On Tue, 16 Jan 2018 16:47:57 +0100, Olivier Goffart wrote: > Just change your code to use "= QString()", no #ifdef necessary. The "just change" introduces a binary incompatibility - right ? Please be aware, that Qwt is part of almost any Linux distro - according to sourceforge it has more than

Re: [Development] Undeprecating QString::null

Am Dienstag, 16. Januar 2018, 16:20:54 CET schrieb Uwe Rathmann: > Hi all, > > I received a bug report concerning a header of the Qwt library ( http:// > qwt.sf.net ), that is using the deprecated QString::null. > > Sure this is only a warning, but it is obviously something where Qwt > users get

[Development] Undeprecating QString::null

Hi all, I received a bug report concerning a header of the Qwt library ( http:// qwt.sf.net ), that is using the deprecated QString::null. Sure this is only a warning, but it is obviously something where Qwt users get irritated as they can't fix code of a 3rd party header. The offending line