Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-28 Thread John Layt
On Wednesday 27 Feb 2013 13:49:48 Thiago Macieira wrote: On quarta-feira, 27 de fevereiro de 2013 20.57.22, John Layt wrote: Currently is now dropped, we'll wait and see if there's any demand later. It would actually be isDaylightTime(QDateTime::currentMSecsSinceEpoch()). Then please

Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-27 Thread Oswald Buddenhagen
On Tue, Feb 26, 2013 at 04:12:07PM -0800, Thiago Macieira wrote: On terça-feira, 26 de fevereiro de 2013 22.42.31, John Layt wrote: On Wednesday 20 Feb 2013 16:16:55 Thiago Macieira wrote: For 12 commits, I'd just submit straight to dev. Would you prefer it squashed to one big commit,

Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-27 Thread John Layt
On Tuesday 26 Feb 2013 16:12:07 Thiago Macieira wrote: On terça-feira, 26 de fevereiro de 2013 22.42.31, John Layt wrote: I'm struggling to think of something different, I can only think of uglies like UnspecifiedTime, NonspecificTime or NotStandardTimeOrDaylightTime. We can't use

Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-27 Thread John Layt
On Wednesday 27 Feb 2013 10:26:51 Oswald Buddenhagen wrote: On Tue, Feb 26, 2013 at 04:12:07PM -0800, Thiago Macieira wrote: On terça-feira, 26 de fevereiro de 2013 22.42.31, John Layt wrote: On Wednesday 20 Feb 2013 16:16:55 Thiago Macieira wrote: For 12 commits, I'd just submit

Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-26 Thread John Layt
On Wednesday 20 Feb 2013 16:16:55 Thiago Macieira wrote: For 12 commits, I'd just submit straight to dev. Would you prefer it squashed to one big commit, or keep the platform backends separate commits? Except as noted below all other suggested changes are being made. - GenericTime and

Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-26 Thread Thiago Macieira
On terça-feira, 26 de fevereiro de 2013 22.42.31, John Layt wrote: On Wednesday 20 Feb 2013 16:16:55 Thiago Macieira wrote: For 12 commits, I'd just submit straight to dev. Would you prefer it squashed to one big commit, or keep the platform backends separate commits? I prefer separate

Re: [Development] [Releasing] Including QTimeZone in Qt 5.1

2013-02-20 Thread Thiago Macieira
On quarta-feira, 20 de fevereiro de 2013 23.26.51, John Layt wrote: Hi, As per Lars' email to development, I would like to submit my implementation of QTimeZone and its integration in QDateTime for inclusion in Qt 5.1. My development branch is currently on gitorious [1] but I'd like to push