Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-10 Thread Volker Hilsheimer via Development
> On 10 May 2023, at 07:39, Marc Mutz via Development > wrote: >> >> >> That said. I find discussing style-guides in general a waste of time, and >> will >> agree to anything that make us stop wasting time on this. > > I tend to agree, but the choice is either to define it centrally, or you

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Marc Mutz via Development
On 09.05.23 22:15, Allan Sandfeld Jensen wrote: > On Dienstag, 9. Mai 2023 08:51:37 CEST Marc Mutz via Development wrote: [...] >> - space after template and before <: >> >> // WRONG >> template >> // CORRECT: >> template >> > >> Rationale: We always used the latter in Qt. > >

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Allan Sandfeld Jensen
On Dienstag, 9. Mai 2023 08:51:37 CEST Marc Mutz via Development wrote: > Hi, > > I'd like to propose the following clarifications: > > - no space between "operator" and it's symbol: > > // WRONG > bool operator ==() > // CORRECT > bool operator==() > > Rationale:

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread A . Pönitz
On Tue, May 09, 2023 at 06:51:37AM +, Marc Mutz via Development wrote: > Hi, > > I'd like to propose the following clarifications: > > - no space between "operator" and it's symbol: > [...] > - exactly one space each between if and constexpr/constinit and > [...] > - space after template

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Ivan Solovev via Development
Hi! +1 to all suggestions Best regards, Ivan From: Development on behalf of Marc Mutz via Development Sent: Tuesday, May 9, 2023 8:51 AM To: qt-dev Subject: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style Hi, I'd like to propose the

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Thiago Macieira via Development
On Monday, 8 May 2023 23:51:37 PDT Marc Mutz via Development wrote: >// WRONG >template >// CORRECT: >template > > Rationale: We always used the latter in Qt. Then a faulty _clang-format > that dropped the space for unknown reasons was added to qt5.git and > since then, we have a

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Mårten Nordheim via Development
Hello! > -Original Message- > From: Development On Behalf Of > Marc Mutz via Development > Sent: tirsdag 9. mai 2023 08:52 > To: qt-dev > Subject: [Development] Proposing changes to > https://wiki.qt.io/Qt_Coding_Style > > Hi, > > I'd like to propose the following clarifications: > >

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Jaroslaw Kobus via Development
> - drop the requirement for () in lambdas > > Rationale: this was a word-around for older MSVCs. The standard doesn't > require the empty parameter list (except when adorning the lambda with > noexcept etc, and then the compiler complains) and people have voted > with their feet: we now have