Re: [Development] clang-format

On 2 Jul 2018, at 16:52, Tor Arne Vestbø mailto:tor.arne.ves...@qt.io>> wrote: On 2 Jul 2018, at 16:49, Lars Knoll mailto:lars.kn...@qt.io>> wrote: On 2 Jul 2018, at 13:35, Tor Arne Vestbø mailto:tor.arne.ves...@qt.io>> wrote: On 2 Jul 2018, at 12:56, Svenn-Arne Dragly

Re: [Development] QWebChannel pure C++14 client

Am 27.06.2018 um 16:55 schrieb Thiago Macieira: On Wednesday, 27 June 2018 01:24:53 PDT Arno Rehn wrote: FYI: We've now also completed the QWebChannel C++14 client: https://github.com/MenloSystems/webchannelpp It's header-only and depends only on the C++ JSON library by Niels Lohmann

Re: [Development] Urgent: increase timeout for tst_qcomplextext

> On 3 Jul 2018, at 05:55, Thiago Macieira wrote: > > On Saturday, 30 June 2018 10:09:11 PDT Lars Knoll wrote: >> Hi Thiago, >> >> maybe https://codereview.qt-project.org/#/c/233693/ helps with this case. > > It did help some. It went from > > PASS : tst_QComplexText::bidiTest(line #201771

Re: [Development] Urgent: increase timeout for tst_qcomplextext

On Tue, 3 Jul 2018 at 10:05, Lars Knoll wrote: > > On 3 Jul 2018, at 05:55, Thiago Macieira > wrote: > > > > On Saturday, 30 June 2018 10:09:11 PDT Lars Knoll wrote: > >> Hi Thiago, > >> > >> maybe https://codereview.qt-project.org/#/c/233693/ helps with this > case. > > > > It did help some.

Re: [Development] clang-format

On 07/03/2018 10:26 AM, Lars Knoll wrote: On 2 Jul 2018, at 16:52, Tor Arne Vestbø > wrote: > > > >> On 2 Jul 2018, at 16:49, Lars Knoll >> > wrote: >> >> >>> On 2 Jul 2018, at 13:35, Tor Arne Vestbø >>> >

Re: [Development] clang-format

>> I thought we were going to run it as a fancy style bot, complaining if >> the code isn't per the format-file, but allowing us to ignore it if we >> feel the tailored code-formatting is better? Doesn't this mean the bot >> will complain a lot? > If there is the need for some human

Re: [Development] clang-format

On 3 Jul 2018, at 13:42, Lars Knoll wrote: > > To some extent it might introduce new ones, but the idea was to aim for a > format file that is very close to our existing rules. It seems the extent is wider than first outlined. And even if it’s very close to the existing rules, those rules

Re: [Development] clang-format

> On 3 Jul 2018, at 14:12, Dominik Holland > wrote: > > >>> I thought we were going to run it as a fancy style bot, complaining if >>> the code isn't per the format-file, but allowing us to ignore it if we >>> feel the tailored code-formatting is better? Doesn't this mean the bot >>> will

Re: [Development] clang-format

> Really?? That sounds like a key feature, I’m surprised clang-format doesn’t > allow it to leave code untouched. As already mentionned, there is always the option to tag code sections: // clang-format off ... // clang-format on > I thought we were going to run it as a fancy style bot,

Re: [Development] clang-format

On 3 Jul 2018, at 12:13, Tor Arne Vestbø mailto:tor.arne.ves...@qt.io>> wrote: On 3 Jul 2018, at 10:26, Lars Knoll mailto:lars.kn...@qt.io>> wrote: On 2 Jul 2018, at 16:52, Tor Arne Vestbø mailto:tor.arne.ves...@qt.io>> wrote: On 2 Jul 2018, at 16:49, Lars Knoll

Re: [Development] clang-format

> On 3 Jul 2018, at 10:26, Lars Knoll wrote: > >> On 2 Jul 2018, at 16:52, Tor Arne Vestbø wrote: >> >> >> >>> On 2 Jul 2018, at 16:49, Lars Knoll wrote: >>> >>> On 2 Jul 2018, at 13:35, Tor Arne Vestbø wrote: > On 2 Jul 2018, at 12:56, Svenn-Arne Dragly >

[Development] Coding style: space after comma

I notice that our coding style [0] doesn't actually say out loud that we expect a space after each comma (and none before). Its sole mention of comma is that it goes at a line-end, unlike operators at line-start, on a continued line. Yet the Qt code-base is mostly consistent about this and I've

Re: [Development] clang-format

On onsdag 20. juni 2018 13.01.10 CEST Tor Arne Vestbø wrote: > On 20 Jun 2018, at 12:13, Lars Knoll wrote: > > > > > I can’t see how clang-format will make you jump through any sort of hoops. > > Creator already has a hook for doing it on file saving time afaik, > > git-clang-format will clean

Re: [Development] Urgent: increase timeout for tst_qcomplextext

On Tuesday, 3 July 2018 01:05:47 PDT Lars Knoll wrote: > Are you sure you already have the fix (it went into 5.11 first)? Because > with the patch, you shouldn't see those 'line #xxx' things at all anymore. > bidiTest should just report one single line. *facepalm* Right, this was in dev... --

Re: [Development] clang-format

Interesting discussion about using clang-format Qt wide. As someone who implemented something like that in a project (of smaller size than Qt, but not all that small) some points:   - clang-format virtually annihilates A LOT of manual work. It might not seem like much but I have measured it

[Development] Merge and Integration status report - 2018.07.04

Merges * qtbase 5.11->dev, https://codereview.qt-project.org/#/c/231959/ finally got merged after blocked about 3 weeks. A new round is ongoing, https://codereview.qt-project.org/#/c/233803/ Integrations * qt5 dev, last one is June 29, 4 days ago. A new one is at