Re: [Development] Gerrit Upgrade

2019-05-07 Thread Jukka Jokiniva
The new Gerrit version will use Polymer-based UI, the "old style UI" will be disabled. If someone want to see the new UI in action, the Gerrit code is reviewed in Gerrit: https://gerrit-review.googlesource.com/ Just a note that the site is using the very latest 3.0 RC, and we will be using

Re: [Development] Gerrit Upgrade

2019-05-07 Thread Jukka Jokiniva
On 06/05/2019, 22.46, "Development on behalf of Sergio Ahumada" wrote: > >On 06.05.19 14:16, Frederik Gladhorn wrote: >> We aim to do the Upgrade to Gerrit 2.16.7 around the 20th of May (yes, > that's >> a Monday, we assume Gerrit will be down for the full day that day). > >

Re: [Development] Gerrit Upgrade

2019-05-07 Thread Alexandru Croitor
I hope you have at least two backups in two different locations. : ) > On 7. May 2019, at 11:02, Jukka Jokiniva wrote: > > > On 06/05/2019, 22.46, "Development on behalf of Sergio Ahumada" > wrote: >> >> On 06.05.19 14:16, Frederik Gladhorn wrote: >>> We aim to do the Upgrade to Gerrit

Re: [Development] unique_ptr and Qt, Take 2

2019-05-07 Thread Volker Hilsheimer
On 6 May 2019, at 22:20, Lars Knoll mailto:lars.kn...@qt.io>> wrote: On 6 May 2019, at 20:23, André Pönitz mailto:apoen...@t-online.de>> wrote: On Mon, May 06, 2019 at 07:41:05AM +, Lars Knoll wrote: On 6 May 2019, at 09:30, Christian Kandeler mailto:christian.kande...@qt.io>> wrote: On

[Development] Be careful with duplicate Change-Ids in multiple branches in gerrit

2019-05-07 Thread Liang Qi
This is a very common issue when I do the integraton work in qt5. For example, currently we have 5.12->5.13->dev merge order, and the last round 5.13->5.13.0 today. One change(changeA) had been integrated in 5.13, and another change(changeB) with duplicate Change-Id was pushed to 5.13.0 branch

Re: [Development] unique_ptr and Qt, Take 2

2019-05-07 Thread Konstantin Tokarev
>> Can you explain what you mean with “understands the parent/child-ownership >> model”? >> >> Are you suggesting a unique_ptr-like template class that doesn’t destroy the >> object in its destructor if that object still has a parent? > > It could be something like that. One option could be to

Re: [Development] unique_ptr and Qt, Take 2

2019-05-07 Thread Lars Knoll
On 7 May 2019, at 15:00, Volker Hilsheimer mailto:volker.hilshei...@qt.io>> wrote: On 6 May 2019, at 22:20, Lars Knoll mailto:lars.kn...@qt.io>> wrote: On 6 May 2019, at 20:23, André Pönitz mailto:apoen...@t-online.de>> wrote: On Mon, May 06, 2019 at 07:41:05AM +, Lars Knoll wrote: On 6

[Development] HEADS-UP: Branching from '5.13' -> '5.13.0' completed

2019-05-07 Thread Jani Heikkinen
Hi all, Branching from '5.13' -> '5.13.0' is now done. So from now on all changes to Qt 5.13.0 release must be done in '5.13.0' and '5.13' is for Qt 5.13.1. And as usual no any nice-to-haves in '5.13.0' anymore; just a fixes for release blockers (and documentation improvements as well). And as

Re: [Development] Gerrit Upgrade

2019-05-07 Thread Giuseppe D'Angelo via Development
Il 06/05/19 14:16, Frederik Gladhorn ha scritto: We will collect some documentation here, currently it's just a placeholder page, not yet worth visiting, unless you know the newer Gerrit and want to help out documenting what is new: https://wiki.qt.io/Gerrit_Upgrade_2019 Wow, this is a very

Re: [Development] Be careful with duplicate Change-Ids in multiple branches in gerrit

2019-05-07 Thread Oswald Buddenhagen
On Tue, May 07, 2019 at 01:52:48PM +, Liang Qi wrote: > This is a very common issue when I do the integraton work in qt5. > > For example, currently we have 5.12->5.13->dev merge order, and the last > round 5.13->5.13.0 today. One change(changeA) had been integrated in 5.13, > and another

Re: [Development] unique_ptr and Qt, Take 2

2019-05-07 Thread Daniel Teske
Am 06.05.2019 um 12:04 schrieb Lars Knoll: On 6 May 2019, at 10:27, Konstantin Shegunov > wrote: On Mon, May 6, 2019 at 10:42 AM Lars Knoll > wrote: Not sure whether it’s most projects, but there certainly are users doing it. And