Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thomas McGuire
Hi, On Tuesday 05 February 2013 14:22:47 Thomas McGuire wrote: On Tuesday 05 February 2013 11:33:29 Paul Olav Tvete wrote: One of the major features for Qt 5.1 is Android support. We have been doing the work in a feature branch, and are now getting ready to integrate to the dev branch. To

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread BogDan
[...]   M       src/corelib/codecs/qtextcodec.cpp   M       src/corelib/codecs/qtextcodec_p.h This has been discussed before. Please leave the macro called Q_OS_LINUX_ANDROID.   When, where, who ? I changed that macro because Google[1] and GCC[2] consider that the name of the O.S. is  

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Paul Olav Tvete
On Wednesday 6 February 2013 09:00:41 Thomas McGuire wrote: A workaround would be to squash all commits of the branch together into a single patch and then upload that to Gerrit for review. Now, actually pushing the single patch would lose history, so we'd instead manually do a proper merge

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Eskil Abrahamsen Blomfeldt
Thanks for the comments. I'll convert them all into tasks or add them as comments in Gerrit if the patches in question are already in there. On 02/06/2013 03:04 AM, Thiago Macieira wrote: -2 on the -openssl-source option. It's not used anywhere. Yes, that's a left-over. I'll remove it. A

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Oswald Buddenhagen
On Wed, Feb 06, 2013 at 09:41:46AM +0100, Paul Olav Tvete wrote: On Wednesday 6 February 2013 09:00:41 Thomas McGuire wrote: A workaround would be to squash all commits of the branch together into a single patch and then upload that to Gerrit for review. Now, actually pushing the single

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Oswald Buddenhagen
On Tue, Feb 05, 2013 at 12:16:26PM -0800, BogDan wrote: Android has almost none of the previous libraries and utilities. Even distrowatch consider android a different O.S.  http://distrowatch.com/dwres.php?resource=links#otheros it basically boils down to what is more likely to be used as a

Re: [Development] Qt Hebrew

2013-02-06 Thread Knoll Lars
On 2/5/13 4:06 PM, Thiago Macieira thiago.macie...@intel.com wrote: On terça-feira, 5 de fevereiro de 2013 11.19.39, Diego Iastrubni wrote: Note that Qt3 had a very good support for Arabic/Hebrew/Farse (RTL in general). I still remember sitting with Lars back in 2003 in (crap forgot where in

[Development] issue tracker rights

2013-02-06 Thread Frederik Gladhorn
Hello all, yesterday we did a bug triaging and fixing day here in the Digia Oslo office. While everyone always looks at the bugs a little bit, it is sometimes good to actually go through them and figure out if they are valid and their priority so we know what to work on. Traditionally we have

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Paul Olav Tvete
On Wednesday 6 February 2013 09:41:46 Paul Olav Tvete wrote: On Wednesday 6 February 2013 09:00:41 Thomas McGuire wrote: A workaround would be to squash all commits of the branch together into a single patch and then upload that to Gerrit for review. Now, actually pushing the single patch

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thomas McGuire
Hi, On Wednesday 06 February 2013 13:05:33 Paul Olav Tvete wrote: On Wednesday 6 February 2013 09:41:46 Paul Olav Tvete wrote: On Wednesday 6 February 2013 09:00:41 Thomas McGuire wrote: A workaround would be to squash all commits of the branch together into a single patch and then

Re: [Development] SSL Certificate verification overriding !!

2013-02-06 Thread Richard Moore
See http://www.youtube.com/watch?v=btLCVoEuEr8 for a talk on this topic. The examples are at https://gitorious.org/qt-examples/qt-examples/trees/master/ssl-examples For future reference, questions like this should be sent to the inter...@qt-project.org list not the development list. Cheers

Re: [Development] ICU and Windows

2013-02-06 Thread Koehne Kai
-Original Message- From: development-bounces+kai.koehne=digia@qt-project.org [mailto:development-bounces+kai.koehne=digia@qt-project.org] On Behalf Of Thiago Macieira Sent: Tuesday, February 05, 2013 6:42 AM To: development@qt-project.org Subject: Re: [Development] ICU and

[Development] Gardening (merging of branches)

2013-02-06 Thread Frederik Gladhorn
Hello again, if you follow gerrit and the git repos closely you might have noticed that we have merged the branches in a more regular fashion lately. With our current setup we need to continously go this path: release - stable - dev On a side note: Please only submit your patch for one branch.

Re: [Development] issue tracker rights

2013-02-06 Thread Mitch Curtis
On Wednesday, February 06, 2013 12:52:29 PM Frederik Gladhorn wrote: Hello all, yesterday we did a bug triaging and fixing day here in the Digia Oslo office. While everyone always looks at the bugs a little bit, it is sometimes good to actually go through them and figure out if they are

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thiago Macieira
On quarta-feira, 6 de fevereiro de 2013 00.40.45, BogDan wrote: When, where, who ? I changed that macro because Google[1] and GCC[2] consider that the name of the O.S. is ANDROID not LINUX-ANDROID and they define a preprocessor macro as __ANDROID__ (not __LINUX_ANDROID__)! Because Q_OS_ is

Re: [Development] issue tracker rights

2013-02-06 Thread Charley Bay
Mitch sayeth: I think a lot of people are hesitant to contribute fixes because of all of the setup required to contribute, also (yeah, it's easy once you are familiar with it). snip, +1 It would be nice to make this, turn-key. For example, on platforms like Windows, it would-be-nice to

Re: [Development] SSL Certificate verification overriding !!

2013-02-06 Thread Arunprasad Rajkumar
Thank you Richard. Sorry for sending to the wrong mailing list :( On 6 February 2013 18:47, Richard Moore r...@kde.org wrote: See http://www.youtube.com/watch?v=btLCVoEuEr8 for a talk on this topic. The examples are at https://gitorious.org/qt-examples/qt-examples/trees/master/ssl-examples

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thiago Macieira
On quarta-feira, 6 de fevereiro de 2013 16.45.15, Eskil Abrahamsen Blomfeldt wrote: On 02/06/2013 04:43 PM, Thiago Macieira wrote: Note: a way out is to define *both*. This sounds like a logical compromise to me. We can define the Q_OS_LINUX_ANDROID and document that it's to avoid breaking

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thiago Macieira
On quarta-feira, 6 de fevereiro de 2013 11.07.44, Eskil Abrahamsen Blomfeldt wrote: A lib/rules.xml I'd rather you found a better place for this file. I was planning on putting it into src/android and having it deployed into lib/rules.xml when you build for Android. Would that

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread BogDan
[...]    M       src/corelib/kernel/qeventdispatcher_unix.cpp    M       src/corelib/kernel/qeventdispatcher_unix_p.h       This one needs a very good explanation.   Would you mind discussing this with Bogdan on       https://codereview.qt-project.org/#change,46798   Apparently it was

Re: [Development] ChangeLogs

2013-02-06 Thread Olivier Goffart
On Thursday 31 January 2013 07:50:32 Koehne Kai wrote: -Original Message- From: development-bounces+kai.koehne=digia@qt-project.org [mailto:development-bounces+kai.koehne=digia@qt-project.org] On Behalf Of Matt Williams Sent: Tuesday, January 29, 2013 11:14 AM To:

Re: [Development] abandoning stale changes on gerrit

2013-02-06 Thread Jeremy Katz
On 01/31/2013 03:19 AM, Chris Adams wrote: Slightly off-topic, but in any event, I think we can all agree that there's a huge difference between a good QML API and a good C++ API. I haven't looked at it, but if Alan thinks that QScreen, as is, shouldn't be exposed to QML as a property of

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thiago Macieira
On quarta-feira, 6 de fevereiro de 2013 10.23.25, BogDan wrote: On Android all events are coming from another thread, and some time a few events are not delivered by the event loop. It happens because if an event is added to the event loop when the event loop just started to process/deliver

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread BogDan
  On Android all events are coming from another thread, and some time a few   events are not delivered by the event loop. It happens because if an event   is  added to the event loop when the event loop just started to   process/deliver the  events this event is not sent because the event loop   

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Olivier Goffart
About https://codereview.qt-project.org/46798 On Wednesday 06 February 2013 11:51:17 BogDan wrote: I think I understood how the event loop is supposed to work, sadly, at least on android, it doesn't work as it should. Is very simple to check it, just revert that patch and test an UI

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thiago Macieira
On quarta-feira, 6 de fevereiro de 2013 21.13.36, Olivier Goffart wrote: That said, it is probably a good idea not to call select at all when it is not needed. But with that patch, you also make calls to write even when it is not needed, while before there was only call to write. The atomic

[Development] Nominating Andreas Hanssen as Approver

2013-02-06 Thread Thiago Macieira
Hello Andreas is a long-time Qt developer. For those of you who haven't yet had the pleasure of meeting him, he's the brains behind the original implementation and maintenance of Graphics View. Before that, I remember working with him on the networking classes -- in fact, QSslSocket is also

Re: [Development] Nominating Andreas Hanssen as Approver

2013-02-06 Thread Robin Burchell
Seconded happily. Unlike you, I haven't had the chance to work with him, but I've seen his work around the place :) On Wed, Feb 6, 2013 at 10:31 PM, Thiago Macieira thiago.macie...@intel.com wrote: Hello Andreas is a long-time Qt developer. For those of you who haven't yet had the pleasure of

Re: [Development] Nominating Andreas Hanssen as Approver

2013-02-06 Thread Daniel Molkentin
What? He isn't an approver yet? Seconded! On 02/06/2013 10:33 PM, Robin Burchell wrote: Seconded happily. Unlike you, I haven't had the chance to work with him, but I've seen his work around the place :) On Wed, Feb 6, 2013 at 10:31 PM, Thiago Macieira thiago.macie...@intel.com wrote: Hello

Re: [Development] Nominating Andreas Hanssen as Approver

2013-02-06 Thread Olivier Goffart
On Wednesday 06 February 2013 13:31:40 Thiago Macieira wrote: Hello Andreas is a long-time Qt developer. For those of you who haven't yet had the pleasure of meeting him, he's the brains behind the original implementation and maintenance of Graphics View. Before that, I remember working

Re: [Development] Nominating Andreas Hanssen as Approver

2013-02-06 Thread Richard Moore
+1 Rich. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Olivier Goffart
On Wednesday 06 February 2013 12:38:12 Thiago Macieira wrote: On quarta-feira, 6 de fevereiro de 2013 21.13.36, Olivier Goffart wrote: That said, it is probably a good idea not to call select at all when it is not needed. But with that patch, you also make calls to write even when it is

Re: [Development] Reviews needed before android integration in two weeks

2013-02-06 Thread Thiago Macieira
On quarta-feira, 6 de fevereiro de 2013 22.54.45, Olivier Goffart wrote: factors. Namely: - wakeUp() is only called from qcoreapplication.cpp with the event queue mutex locked wakeUp is called from many places, and without the lock. It's called from: -

Re: [Development] issue tracker rights

2013-02-06 Thread Joseph Crowell
On 02/07/2013 02:11 AM, Charley Bay wrote: Mitch sayeth: I think a lot of people are hesitant to contribute fixes because of all of the setup required to contribute, also (yeah, it's easy once you are familiar with it). snip, +1 It would be nice to make this, turn-key.

Re: [Development] issue tracker rights

2013-02-06 Thread Thiago A . Corrêa
Hi, On Wed, Feb 6, 2013 at 1:33 PM, Mitch Curtis mitch.cur...@digia.com wrote: Bug triaging is a good way to get new contributors involved. So in my opinion we should try to encourage everyone to help out with the cleanup of our bug- tracker. Maybe we can even learn from KDE for example, where

Re: [Development] Nominating Andreas Hanssen as Approver

2013-02-06 Thread Samuel Rødal
On 02/06/2013 10:42 PM, Olivier Goffart wrote: On Wednesday 06 February 2013 13:31:40 Thiago Macieira wrote: Hello Andreas is a long-time Qt developer. For those of you who haven't yet had the pleasure of meeting him, he's the brains behind the original implementation and maintenance of