Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_DECL_OVERRIDE - required in new code, don't add to old code - Required to be used consistently within a class, because Clang warns be default if one function has override and another doesn't. - Even add to old code. The benefits

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_NULLPTR - strongly encouraged Ok, trying to summarize the discussion so we can move forward. There's a bug report (https://bugreports.qt.io/browse/QTBUG-45291) about Qt headers not compiling with -Wzero-as-null-pointer-constant,

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_DECL_EQ_DEFAULT - really discouraged I can't think of any case where you could use this and let the code still compile in C++98, so don't use it * Q_DECL_EQ_DELETE - strongly encouraged, use with care Let's the compiler

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_CONSTEXPR - use only where required You probably don't need this. You'll need it when accessing const data from a Q_DECL_CONSTEXPR function. Otherwise, you won't need it. You could use this to create a

[Development] Contribute to the Qt

2015-07-23 Thread Edi Anderson
Hello guys I'm a programmer and would like to gain more experience in large projects, so I would contribute to Qt. I have time available and just need someone to tell me what to do and how to start. Can someone help me ?. And sorry for bad English, I began to study English in three months.

Re: [Development] Contribute to the Qt

2015-07-23 Thread Andrew Knight
Hi Edi, On 07/24/2015 06:11 AM, Edi Anderson wrote: Hello guys I'm a programmer and would like to gain more experience in large projects, so I would contribute to Qt. That's wonderful; welcome to the Qt Project! I have time available and just need someone to tell me what to do and how to

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Knoll Lars
On 23/07/15 14:27, Marc Mutz marc.m...@kdab.com wrote: On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_DECL_OVERRIDE - required in new code, don't add to old code - Required to be used consistently within a class, because Clang warns be default if one function has override

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Knoll Lars
On 23/07/15 14:23, Marc Mutz marc.m...@kdab.com wrote: On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_NULLPTR - strongly encouraged Ok, trying to summarize the discussion so we can move forward. There's a bug report (https://bugreports.qt.io/browse/QTBUG-45291) about Qt

Re: [Development] Is QFutureInterface internal like the other d-pointer classes?

2015-07-23 Thread Lorenz Haas
2015-07-23 13:20 GMT+02:00 Marc Mutz marc.m...@kdab.com: It's undocumented, and considered private, but since it's a template and thus must be visible, it effectively is public API and falls under the same restrictions for changes as public API. IOW: it cannot change (incompatibly) until Qt 6.

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Knoll Lars
On 23/07/15 14:27, Marc Mutz marc.m...@kdab.com wrote: On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_DECL_OVERRIDE - required in new code, don't add to old code - Required to be used consistently within a class, because Clang warns be default if one function has override

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Matthew Woehlke
On 2015-07-23 08:23, Marc Mutz wrote: On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_NULLPTR - strongly encouraged Ok, trying to summarize the discussion so we can move forward. There's a bug report (https://bugreports.qt.io/browse/QTBUG-45291) about Qt headers not

Re: [Development] Nominating Sérgio Martins for Approver status

2015-07-23 Thread Rutledge Shawn
On 21 Jul 2015, at 13:27, Giuseppe D'Angelo giuseppe.dang...@kdab.com wrote: Hi, I'd like to nominate Sérgio Martins for the Approver status in the Qt project. In the last years Sérgio has pushed lots of patches in a number of components: he worked on the QNX/BB platform plugin, on

Re: [Development] Is QFutureInterface internal like the other d-pointer classes?

2015-07-23 Thread Thiago Macieira
On Thursday 23 July 2015 16:34:40 Lorenz Haas wrote: 2015-07-23 13:20 GMT+02:00 Marc Mutz marc.m...@kdab.com: It's undocumented, and considered private, but since it's a template and thus must be visible, it effectively is public API and falls under the same restrictions for changes as

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Thiago Macieira
On Thursday 23 July 2015 19:22:46 Marc Mutz wrote: I believe we should strive to have the LTS release warning-free in this regard. It's going to be in use for a long time, and the demand for nullptr- correctness will only grow with time. Agreed. I'd say go ahead with cleaning up zero-as-null

Re: [Development] MSVC2015 and Qt5.5 -- dot release plans?

2015-07-23 Thread Thiago Macieira
On Thursday 23 July 2015 07:09:05 Tom Isaacson wrote: I don't know whether we'll be able to produce binaries for it for 5.5.1. That depends on how soon we can bring it up in the old CI. Any idea when 5.5.1 is due now? The Wiki says the original date was September but will this be pushed out?

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: Non-C++11 but also useful: * Q_DECL_{PURE,CONST}_FUNCTION - encouraged A pure function is a function that will return the same value if called twice with the same parameters. Pure functions are allowed to read from pointers

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_DECL_NOTHROW / Q_DECL_NOEXCEPT - strongly encouraged To public functions (all modules); any function in modules compiled with exception (QtCore, QtXmlPatterns, QtConcurrent). You probably want Q_DECL_NOTHROW instead of

Re: [Development] Upgrading the sources to C++11 keywords (Q_NULLPTR, etc.)

2015-07-23 Thread Marc Mutz
On Thursday 23 July 2015 15:47:10 Knoll Lars wrote: On 23/07/15 14:23, Marc Mutz marc.m...@kdab.com wrote: On Thursday 08 January 2015 23:33:34 Thiago Macieira wrote: * Q_NULLPTR - strongly encouraged Ok, trying to summarize the discussion so we can move forward. There's a bug report

Re: [Development] MSVC2015 and Qt5.5 -- dot release plans?

2015-07-23 Thread Tom Isaacson
I don't know whether we'll be able to produce binaries for it for 5.5.1. That depends on how soon we can bring it up in the old CI. Any idea when 5.5.1 is due now? The Wiki says the original date was September but will this be pushed out? https://wiki.qt.io/Qt-5.5-release Tom Isaacson

Re: [Development] qtbase 5.5 CI broken again ?

2015-07-23 Thread Friedemann Kleint
Hi, As far as I know, no. No one has a clue why the creation of a temporary directory is failing. It is simply running out of patterns to try since the mime DB tests leaked temp dirs. https://codereview.qt-project.org/#/c/121381/ fixed QDir::removeRecursively() to try harder removing files

Re: [Development] Is QFutureInterface internal like the other d-pointer classes?

2015-07-23 Thread Marc Mutz
On Thursday 23 July 2015 11:24:05 Lorenz Haas wrote: Hi, most - if not all - d-pointer/private implementation files are *internal* and should not be used in a normal project - meaning a project that just uses Qt. These files/classes are clearly marked by // // W A R N I N G //

[Development] Is QFutureInterface internal like the other d-pointer classes?

2015-07-23 Thread Lorenz Haas
Hi, most - if not all - d-pointer/private implementation files are *internal* and should not be used in a normal project - meaning a project that just uses Qt. These files/classes are clearly marked by // // W A R N I N G // - // // This file is not part of the Qt API. It exists

Re: [Development] FileRe: Move ctors for q_declare_shared types

2015-07-23 Thread Daniel Teske
If a change is related to a discussion on the mailing list, I expect that the change is posted to the discussion. I already quoted you the mail where I ... Because not doing that, circumvents the discussion on the mailing list and goes against the spirit of The Qt Governance Model.