Re: [Development] Should QVariant be doing fuzzy comparisons on doubles?

2016-09-23 Thread Sune Vuorela
On 2016-09-23, André Pönitz wrote: > That gives already "surprising" behaviour if fed with QChar('a') and > QString("a") in a row. > > And it is "surprising" to a degree that I'd call it buggy. Then try feeding it boolean's and strings. QQmlPropertyMap map;

Re: [Development] Should QVariant be doing fuzzy comparisons on doubles?

2016-09-23 Thread André Pönitz
On Fri, Sep 23, 2016 at 09:56:30AM +, Edward Welbourne wrote: > Indeed; having all values of some type equivalent is worse (for the "has > my value changed" test you illustrate, at least) than having a value not > equal to itself (which triggers a "changed" event for a non-change). In > fact

Re: [Development] Should QVariant be doing fuzzy comparisons on doubles?

2016-09-23 Thread André Pönitz
On Fri, Sep 23, 2016 at 11:22:08AM +0200, Olivier Goffart wrote: > > There is not much of a choice. An equivalence relation is reflexive, > > i.e. at least Foo(a) == Foo(a) must be true. Lacking the ability > > to compare Foos, treating them all equal at least doesn't break the > > relation. > >

Re: [Development] Should QVariant be doing fuzzy comparisons on doubles?

2016-09-23 Thread Matthew Woehlke
On 2016-09-22 16:58, André Pönitz wrote: > There is not much of a choice. An equivalence relation is reflexive, > i.e. at least Foo(a) == Foo(a) must be true. JFTR... auto nan = qNaN(); assert(nan != nan); // okay assert(!(nan == nan)); // okay -- Matthew

Re: [Development] First Qt 5.8.0 Beta snapshot available

2016-09-23 Thread Thiago Macieira
On sexta-feira, 23 de setembro de 2016 09:07:13 PDT Jani Heikkinen wrote: > Hi, > > > We have finally first Qt 5.8.0 beta snapshot available > > Windows: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/570/ > > Mac: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/439/ > > src:

Re: [Development] Should QVariant be doing fuzzy comparisons on doubles?

2016-09-23 Thread Edward Welbourne
Olivier Goffart > What use case did you have in mind where a reflexive relation is any usefull? Well, having x == x for all x is generally considered a useful property of equality. That's all "reflexive" is saying. > There is the case of the key of a QHash or in a QSet, but even then i'm not >

Re: [Development] Notes on "Managing Qt's branches" session @ QCS 2016

2016-09-23 Thread Oswald Buddenhagen
On Thu, Sep 22, 2016 at 09:41:29AM +0200, Marc Mutz wrote: > On Thursday 22 September 2016 08:55:13 Liang Qi wrote: > > Give the merge permission to everyone is obiviously not a solution. > > Not everyone, but approvers, maybe? Merges need to be reviewed like any other > commit, so why are they

Re: [Development] Should QVariant be doing fuzzy comparisons on doubles?

2016-09-23 Thread Olivier Goffart
On Donnerstag, 22. September 2016 22:58:09 CEST André Pönitz wrote: > On Thu, Sep 22, 2016 at 06:04:58AM +0200, Mathias Hasselmann wrote: > > Am 22.09.2016 um 00:58 schrieb André Pönitz: > > >On Wed, Sep 21, 2016 at 08:57:01AM +0200, Olivier Goffart wrote: > > >>>No, it's not. It's changing

[Development] First Qt 5.8.0 Beta snapshot available

2016-09-23 Thread Jani Heikkinen
Hi, We have finally first Qt 5.8.0 beta snapshot available Windows: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/570/ Mac: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/439/ src: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/latest_src/ Linux ones are there as well but those

Re: [Development] dev doesnt builds

2016-09-23 Thread Martin Smith
I did git checkout 5.8 at the qt5 level but kept my qtbase module on dev branch. That seems to work. martin From: Development on behalf of Vlad Stelmahovsky Sent: Friday,