Re: [Development] qMoveToConst helper for rvalue references to movable Qt containers?

2018-10-22 Thread Giuseppe D'Angelo via Development
Hi, Il 22/10/18 21:40, André Pönitz ha scritto: Which just shows it's working as intended. I have (a) no example that triggers obviously bad behaviour and (b) a bad gut feeling nevertheless. What bad behaviour are we referring to here? The problem is that a 'move' could be a 'swap' in

Re: [Development] qMoveToConst helper for rvalue references to movable Qt containers?

2018-10-22 Thread André Pönitz
On Sun, Oct 21, 2018 at 04:15:58PM +0200, Elvis Stansvik wrote: > In order to try out the unsafe usage you suggested in your other mail, > and also another unsafe usage pointed out in an SO question >

Re: [Development] Un-inlining members allowed?

2018-10-22 Thread Edward Welbourne
On Sonntag, 21. Oktober 2018 20:07:38 CEST Christian Ehrlicher wrote: >>> one more question - is it ok to un-inline a function? For example I >>> want to move QListWidgetItem::isSelected() to the cpp file so I can >>> properly mark QListWidget::isItemSelected() as deprecated but I'm >>> unsure if

Re: [Development] Deprecated functions / procedure of removal in Qt6?

2018-10-22 Thread Giuseppe D'Angelo via Development
Il 22/10/18 07:05, Christian Ehrlicher ha scritto: Ok, I'll go on with adding Q_DECL_DEPRECATED + QT_VERSION < QT_VERSION_CHECK(6, 0, 0) in the places where only the documentation states that this function is deprecated then. Otherwise they might get forgotten again :) Q_DEPRECATED_SINCE

Re: [Development] Un-inlining members allowed?

2018-10-22 Thread Allan Sandfeld Jensen
On Sonntag, 21. Oktober 2018 20:07:38 CEST Christian Ehrlicher wrote: > Hi, > > one more question - is it ok to un-inline a function? For example I want > to move QListWidgetItem::isSelected() to the cpp file so I can properly > mark QListWidget::isItemSelected() as deprecated but I'm unsure if

Re: [Development] Deprecated functions / procedure of removal in Qt6?

2018-10-22 Thread Elvis Stansvik
Den mån 22 okt. 2018 kl 00:14 skrev Giuseppe D'Angelo via Development : > > Hi, > > Il 21/10/18 19:59, Christian Ehrlicher ha scritto: > > there are a lot of deprecated functions in qtbase which are only marked > > as deprecated/obsolete in the documentation but don't have a > > Q_DECL_DEPRECATED.