Re: [Development] Reverting some patches in qtquickcontrols2 for the 5.12.0 release

2018-11-14 Thread J-P Nurmi
Hi Mitch, Check also https://bugreports.qt.io/browse/QTBUG-71811. It might be related too. -- J-P Nurmi On Wed, Nov 14, 2018, 11:28 Mitch Curtis Hi. > > My fixes for https://bugreports.qt.io/browse/QTBUG-67559 have recently > introduced a crash in KDE: > >

Re: [Development] Hardcoded strings and qstricmp comparison

2018-11-14 Thread Thiago Macieira
On Wednesday, 14 November 2018 00:34:50 PST Andy Shaw wrote: > For user code I get that we can just say that they should do something like: > > qstricmp(str, QLatin1String("a").latin1()); What we should do is actually have QLatin1String overloads of the functions in questions. We already

[Development] Reverting some patches in qtquickcontrols2 for the 5.12.0 release

2018-11-14 Thread Mitch Curtis
Hi. My fixes for https://bugreports.qt.io/browse/QTBUG-67559 have recently introduced a crash in KDE: https://bugreports.qt.io/browse/QTBUG-71770 Quoting the commit message from my patch that reverts https://codereview.qt-project.org/#/c/245480/: "Revert all Menu delegate patches This

Re: [Development] Hardcoded strings and qstricmp comparison

2018-11-14 Thread Andy Shaw
Edward Welbourne skrev følgende den 14.11.2018, 11:03: Andy Shaw (14 November 2018 09:34) wrote: > ... there may be some problems that are connected to using qstricmp > and other functions that are expecting latin1 strings for one reason > or another. The reason that this

Re: [Development] Hardcoded strings and qstricmp comparison

2018-11-14 Thread Edward Welbourne
Andy Shaw (14 November 2018 09:34) wrote: > ... there may be some problems that are connected to using qstricmp > and other functions that are expecting latin1 strings for one reason > or another. The reason that this might be a problem is because we are > encoding our source code as UTF-8 and

Re: [Development] Suggestion - Remove Windows 7 as supported development host

2018-11-14 Thread Harald Kjølberg
Hi, Thanks for all the feedback. It seems that Windows 7 is still standing tall. The initial idea was that we probably could remove it, as regular support for Windows 7 ended in 2015. However, from the feedback it is clear that the cost of removing it is greater than the gain. Suggestion

[Development] Hardcoded strings and qstricmp comparison

2018-11-14 Thread Andy Shaw
Hi! In connection to a support case I have been working on it was brought to my attention that there may be some problems that are connected to using qstricmp and other functions that are expecting latin1 strings for one reason or another. The reason that this might be a problem is because we