Re: [Development] Weird offseting in QDataStream

Am 08.11.2013 10:15, schrieb Yves Bailly: Le 08/11/2013 10:05, Giuseppe D'Angelo a écrit : On 8 November 2013 10:01, Yves Bailly yves.bai...@sescoi.fr wrote: As a float is 4 bytes, I would expect the second f.pos() to display 4... but it displays 8, as if QDataStream had moved 8 bytes ahead

Re: [Development] Weird offseting in QDataStream

Am 08.11.2013 10:42, schrieb André Somers: Christian Ehrlicher schreef op 8-11-2013 10:29: Am 08.11.2013 10:15, schrieb Yves Bailly: Le 08/11/2013 10:05, Giuseppe D'Angelo a écrit : On 8 November 2013 10:01, Yves Baillyyves.bai...@sescoi.fr wrote: As a float is 4 bytes, I would expect

Re: [Development] Problem porting app from Qt4 to Qt5 with multiple X-screen

Von: Christian Ehrlicher ch.ehrlic...@gmx.de Am 09.02.2015 um 15:35 schrieb Friedemann Kleint: Hi, we've multiple X-screens configured (:0.0 ... :0.3) but Qt5 seems to have lost the ability to display something on another screen than the default QMainWindow *wm = new QMainWindow(dw

Re: [Development] Problem porting app from Qt4 to Qt5 with multiple X-screen

Am 09.02.2015 um 15:35 schrieb Friedemann Kleint: Hi, we've multiple X-screens configured (:0.0 ... :0.3) but Qt5 seems to have lost the ability to display something on another screen than the default QMainWindow *wm = new QMainWindow(dw-screen(1)); Change

[Development] Problem porting app from Qt4 to Qt5 with multiple X-screen

further or what could went wrong here? Thx, Christian Ehrlicher ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development

[Development] QTimer::setInterval() and

Hi,   According to QTimer documentation, QTimer::setInterval(std::chrono::milliseconds) is available unconditionally in Qt 5.9. But in qtimer.h the std::chrono - functions are guarded with QT_HAS_INCLUDE(chrono) which expands to __has_include(chrono) or 0. The problem is that gcc 4.8 doesn't

Re: [Development] QTimer::setInterval() and

Gesendet: Donnerstag, 07. Dezember 2017 um 10:37 Uhr Von: "Giuseppe D'Angelo" An: development@qt-project.org Betreff: Re: [Development] QTimer::setInterval() and Support for from the Standard Library is one of the things that Qt includes conditionally. I'm not

Re: [Development] QTimer::setInterval() and

Am 07.12.2017 um 17:01 schrieb Thiago Macieira: So you upgrade your compiler. No problem from my side :) See also how no version of Visual Studio has __has_include, so the functionality is disabled with Microsoft's compiler until they implement the macro. This is a conscious decision. Then

Re: [Development] QEasingCurve saving to QDataStream

Am 08.05.2018 um 20:40 schrieb Thiago Macieira: Does anyone remember the implementation details for this class? If so, can you help with https://bugreports.qt.io/browse/QTBUG-68181 ? I can clearly see parameters that are not properly saved to the stream, but I don't know which parameters need

Re: [Development] Proposing David Faure as maintainer of Qt Models

Hi,   There is already a component "Widgets: Itemviews" which should be renamed then.   Christian   Gesendet: Mittwoch, 02. Mai 2018 um 08:37 Uhr Von: "Lars Knoll" An: "Alex Blasche" Cc: "Qt development mailing list"

[Development] Q_COMPILER_UNIFORM_INIT still needed?

Hi, will reviewing a patch I found this comment from Marc Mutz in qstringlistmodel.cpp: // once Q_COMPILER_UNIFORM_INIT can be used, change to: // emit dataChanged(index, index, {Qt::DisplayRole, Qt::EditRole}); Now I wonder if this is still needed because we're using this way calling

[Development] QVector rvalue overloads for convenience functions?

Hi, recently rvalue overloads for QVector::append(T), push_back(T) and others were added to QVector. But not for the convenience functions like operator<<(T) or operator +=(T). Is this an oversight or by intention? Thx, Christian ___ Development

Re: [Development] QVector reserve counterproductive?

Am 03.03.2018 um 23:22 schrieb Martins, Sérgio: On 2018-03-03 20:38, Christian Ehrlicher wrote: But it looks like reserve() allocates *exactly* the amount of elements given. Actually that qpainterpath code is off-by-one, it should be: d_func()->elements.reserve(d_func()->element

[Development] QVector reserve counterproductive?

Hi, while digging through the bugreports I found https://bugreports.qt.io/browse/QTBUG-66677 which seems to show a downside of QVector::reserve(). QPainterPath::addPolygon() is calling reserve() to make sure to have enough space for the new positions. This is exactly what I would have done

Re: [Development] QVector reserve counterproductive?

Am 04.03.2018 um 10:03 schrieb Christian Ehrlicher: Am 03.03.2018 um 23:22 schrieb Martins, Sérgio: On 2018-03-03 20:38, Christian Ehrlicher wrote: But it looks like reserve() allocates *exactly* the amount of elements given. Actually that qpainterpath code is off-by-one, it should

Re: [Development] Deprecated functions / procedure of removal in Qt6?

Am 22.10.2018 um 00:14 schrieb Giuseppe D'Angelo via Development: Hi, Thus, adding deprecation warnings is definitely the right thing to do: users get the deprecation warnings (*), and we have an easy way to find and drop all those functions. Ok, I'll go on with adding Q_DECL_DEPRECATED +

[Development] Deprecated functions / procedure of removal in Qt6?

Hi, there are a lot of deprecated functions in qtbase which are only marked as deprecated/obsolete in the documentation but don't have a Q_DECL_DEPRECATED. Most of them were deprecated in the pre Qt5-era. What's the 'correct' way to make sure they can be removed with Qt6? Must they marked as

[Development] Un-inlining members allowed?

Hi, one more question - is it ok to un-inline a function? For example I want to move QListWidgetItem::isSelected() to the cpp file so I can properly mark QListWidget::isItemSelected() as deprecated but I'm unsure if this is allowed. Thx, Christian

Re: [Development] Build system for Qt 6

Am 30.10.2018 um 06:29 schrieb resurrect...@centrum.cz: set(var1 "Hello") set(var2 "Hello") if(var1 EQUAL var2)     message("They are equal") endif() Guess what, it prints NOTHING despite docs explicitly saying this should work. Nothig will help, STREQUAL, MATCHES, dereferencing the

Re: [Development] Build system for Qt 6

Am 30.10.2018 um 09:21 schrieb resurrect...@centrum.cz: // // set(var1 "Hello") // // set(var2 "Hello") // // // // if(var1 EQUAL var2) // //  message("They are equal") // // endif() Using STREQUAL works here for me with cmake 3.12 on linux so if it does not work for you please file a

Re: [Development] Closing issues automatically with new keyword

Hi, I get this warning when I only add 'Fixes:' in the footer: *** *** Suspicious changes in commit HEAD (QSqlQuery: add another testcase for bindBool()): *** ***   commit message: *** - 8: Text following footers (key "footer") *** ***   See http://wiki.qt.io/Early_Warning_System for

Re: [Development] Closing issues automatically with new keyword

Am 23.09.2018 um 17:39 schrieb Christian Ehrlicher: Hi, I get this warning when I only add 'Fixes:' in the footer: *** *** Suspicious changes in commit HEAD (QSqlQuery: add another testcase for bindBool()): *** ***   commit message: *** - 8: Text following footers (key "f

[Development] Issues with 'Fixes' keyword

Hi, looks like under some circumstances the 'Fixes' keyword in the commit message does trigger the automatic closing of a bug when the bug is in 'In progress' state. Is this the intended behavior? Here some examples: https://bugreports.qt.io/browse/QTBUG-72545

Re: [Development] Issues with 'Fixes' keyword

Am 27.12.2018 um 10:52 schrieb Allan Sandfeld Jensen: It has been for me. I always put bugs I have a patch in review for "in progress", and they have been consistently closed, except one time I found a bug in the script that was then closed. You have probably run into another bug. What else was

Re: [Development] Issues with 'Fixes' keyword

Am 27.12.2018 um 07:43 schrieb Kari Oikarinen: On 26.12.2018 17.58, Christian Ehrlicher wrote: Hi, looks like under some circumstances the 'Fixes' keyword in the commit message does trigger the automatic closing of a bug when the bug is in 'In progress' state. Is this the intended behavior

Re: [Development] Nominating Christian Ehrlicher for Approver

Am 11.12.2018 um 09:51 schrieb Alex Blasche: Hi, Congratulations to Christian. Approver rights have been granted. Thanks! :) Christian ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Deprecation of QByteArray operator const char *()?

Am 26.01.2019 um 08:22 schrieb Olivier Goffart: On 25.01.19 21:11, Christian Ehrlicher wrote: Hello, The two implicit conversions from QByteArray to const char*/void* (QByteArray::operator const char *() and QByteArray::operator const void*()) were marked as obsolete with Qt5.0 but never get

Re: [Development] On deprecating functions

Am 04.03.2019 um 19:28 schrieb Thiago Macieira: On Monday, 4 March 2019 09:58:40 PST Edward Welbourne wrote: Christian Ehrlicher (4 March 2019 17:51) wrote So what's the correct way to deprecate a function and not forgetting about QT_DEPRECATED later on as it happened with a lot of functions

[Development] On deprecating functions

Hi, I recently introduced some new signals (Q(Double)SpinBox::textChanged, QComboBox::textActivated) as replacements for old ones to be able to avoid the use of QOverload<>::of in Qt6 and to better match their respective properties. Within those changes I also marked the old signals as

Re: [Development] On deprecating functions

Am 05.03.2019 um 00:37 schrieb André Pönitz: On Mon, Mar 04, 2019 at 03:12:33PM -0800, Thiago Macieira wrote: On Monday, 4 March 2019 13:48:25 PST André Pönitz wrote: The proposed model would effectively introduce another user-visible level including associated period of time between

Re: [Development] On deprecating functions

Am 05.03.2019 um 11:53 schrieb Tor Arne Vestbø: On 5 Mar 2019, at 11:27, Giuseppe D'Angelo via Development wrote: Il 05/03/19 08:14, Lars Knoll ha scritto: One solution I thought about is to replace the QT_DEPRECATED(_X) macros with something that also contains the version (similar to

[Development] Gerrit run out of disk space?

Hi, gerrit is very slow this evening and now that I wanted to push a change I got this messages from git: fatal: Unpack error, check server log Counting objects: 18, done. Delta compression using up to 4 threads. Compressing objects: 100% (18/18), done. error: remote unpack failed: error No

Re: [Development] All deprecation warnings are P1 for 5.13.0

Am 09.02.2019 um 02:27 schrieb Thiago Macieira: By beta, those that aren't fixed will get P1 bug reports in JIRA. for qtbase/src - feel free to review them :) https://codereview.qt-project.org/252626 https://codereview.qt-project.org/252627 https://codereview.qt-project.org/252628

Re: [Development] All deprecation warnings are P1 for 5.13.0

Am 09.02.2019 um 18:02 schrieb Thiago Macieira: On Saturday, 9 February 2019 07:30:36 PST Christian Ehrlicher wrote: QT_DISABLE_DEPRECATED_BEFORE=0x051300: Uh, that's 0x050d00 :-) Ah, this explains why I also got warnings/erros about functions which got deprecated in 5.14 :) Christian

Re: [Development] All deprecation warnings are P1 for 5.13.0

Am 09.02.2019 um 10:00 schrieb Allan Sandfeld Jensen: By beta, those that aren't fixed will get P1 bug reports in JIRA. By fixed I guess you also mean suppressed were appropriate? some are from tests testing deprecated functions, and other are deprecated functions calling other deprecated

Re: [Development] All deprecation warnings are P1 for 5.13.0

Am 09.02.2019 um 07:34 schrieb Giuseppe D'Angelo via Development: Hi, Il 09/02/19 02:27, Thiago Macieira ha scritto: Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That means we started seeing lots of

[Development] Deprecation of QByteArray operator const char *()?

Hello, The two implicit conversions from QByteArray to const char*/void* (QByteArray::operator const char *() and QByteArray::operator const void*()) were marked as obsolete with Qt5.0 but never get decorated as such. This means their usage even inside QtBase is huge (I would say at least

Re: [Development] Deprecation of QByteArray operator const char *()?

Am 25.01.2019 um 21:23 schrieb Thiago Macieira: On Friday, 25 January 2019 12:11:33 PST Christian Ehrlicher wrote: Hello, The two implicit conversions from QByteArray to const char*/void* (QByteArray::operator const char *() and QByteArray::operator const void*()) were marked as obsolete

Re: [Development] unique_ptr and Qt, Take 2

Am 13.06.2019 um 22:09 schrieb Ville Voutilainen: That's one of the things I love about Qt; object hierarchies give me working dynamic memory management without needing even smart pointers. That's the one thing that makes me queasy about using Qt in large applications; I always need to worry

Re: [Development] unique_ptr and Qt, Take 2

Am 13.06.2019 um 23:44 schrieb Konstantin Tokarev: 14.06.2019, 00:14, "Christian Ehrlicher" : Am 13.06.2019 um 22:09 schrieb Ville Voutilainen:  That's one of the things I love about Qt; object hierarchies give me  working dynamic memory management without needing even smar

Re: [Development] Dropping sqlite2 plugin for Qt6/cmake port

Am 03.05.2019 um 12:34 schrieb Lars Knoll: +1 from my side. Please deprecate sqlite2 for 5.14 if that hasn’t been done yet. Did not find something in the docs so: https://codereview.qt-project.org/#/c/260672/ Cheers, Christian ___ Development mailing

Re: [Development] Qt Release and bugfix

Am 18.09.2019 um 14:13 schrieb Jani Heikkinen: -Original Message- From: Development On Behalf Of Fausto Papandrea Sent: keskiviikko 18. syyskuuta 2019 13.39 To: development@qt-project.org Subject: [Development] Qt Release and bugfix Good morning, I have to update my Qt version because

Re: [Development] QtCS19 Notes: Qt 6 Network Overview

Am 22.11.2019 um 15:18 schrieb Timur Pocheptsov: Before moving to QtNetwork it needs to be significantly refactored Can we maybe create a sub-task for this to elaborate what's meant with 'significantly refactored'? Thx, Christian ___ Development

Re: [Development] Notes from "Releasing" session in QtCon19

Am 20.11.2019 um 15:11 schrieb Kai Köhne: Hi, I took the notes for the "Releasing" Session we just had at the Qt Contributor Summit 2019: https://wiki.qt.io/Qt_Contributor_Summit_2019_-_Releasing_Notes High level summary: * The Releasing Dashboard [1] in JIRA provides a good overview of

Re: [Development] The future of smart pointers in Qt API

Am 02.02.2020 um 01:00 schrieb Иван Комиссаров: I would also like to add the argument about templates. Qt API is still incompatible with STL in some places, so one cannot write a template function that simply calls STL variant. For example: QString foo; if (std::empty(foo)) // oops, fails to

[Development] MYSQL / MariaDB pre-build plugins

Hi, due to the fact that the pre-built MYSQL plugin can no longer be shipped with the Qt installer we get a lot of questions in the forum why it's not shipped anymore and how to build this driver from the sources. We already tried to improve the documentation for it but it's not an ideal

Re: [Development] MYSQL / MariaDB pre-build plugins

Am 30.12.2019 um 15:13 schrieb Thiago Macieira: - do we need a small paragraph in the documentation why we can't ship it anymore and that MariaDB should be preferred? Yes. Just ship the MariaDB one. Can you explain why this isn't done now? Maybe since nobody cares? Don't know. That's why I

Re: [Development] MYSQL / MariaDB pre-build plugins

Am 30.12.2019 um 16:52 schrieb Kevin Kofler: Current Qt 5 (and I presume and hope, Qt 6) just works as shipped, i.e., it can be built against current MariaDB libraries without any patches. With this patch also on Windows: https://codereview.qt-project.org/c/qt/qtbase/+/285384 A separate

Re: [Development] Proposal: Deprecate QVector in Qt 6

Am 24.04.2020 um 09:22 schrieb Lars Knoll: e "vector is a silly name from a mathematical standpoint" argument is valid, but vector is an established term in C++ world. Sorry, that ship has sailed. I am also in favor of proposal 2 or 3. I think deprecating either QList or QVector without any

[Development] Usage of final keyword in Qt6

Hi, while discussing QTBUG-89423 / https://codereview.qt-project.org/c/qt/qtbase/+/326658 the question about the final keywords arised - I know that I once wanted to use it in Qt5 and it was not allowed back then. Are there any reasons to not use final for internal classes/functions in Qt6?

Re: [Development] QString, QVariant and QSQLite

Am 26.05.2021 um 21:39 schrieb Alberto Mardegan: Hi there! I'm encountering some sort of memory corruption issue in a library I'm using, which does not cause a crash, but rather a QSQLite query to sometimes simply return no results, without errors or warnings. You can find the valgrind trace

[Development] Gerrit - Staged changes not integrating since last hickup?

Hi, my staged changes from this morning did no longer show up in my overview and were stuck. I had to unstage + stage them to get them integrated. So if you had staged changes this morning you should check to see if they are also stuck. Cheers, Christian -- Development mailing list

[Development] Qt code browser url changed (cgit <-> cgit.cgi)?

Hi, today there was a thread on stackoverflow which mentions that the links to the examples don't work anymore. The links in the docs (and also in the source repo) are https://code.qt.io/cgit/qt/qtbase.git/tree/examples/widgets/... But it needs to be

Re: [Development] RFC: Defaulting to or enforcing UTF-8 locales on Unix systems

Am 22.03.2023 um 20:48 schrieb Volker Hilsheimer: Indeed, the many hits in the sql code are mostly from warning output, thanks for checking. But that Postgres supports UTF-8 doesn’t mean that an existing server is also configured to use it. If a server is configured to work with e.g.

Re: [Development] RFC: Defaulting to or enforcing UTF-8 locales on Unix systems

Am 22.03.2023 um 17:35 schrieb Volker Hilsheimer via Development: But we use toLocal8Bit in plenty of cases as well. For instance in our Qt SQL APIs. The only plugin which really uses toLocal8Bit() is the IBase - Plugin. Postgres is using it as fallback but according the docs the utf-8

Re: [Development] RFC: Defaulting to or enforcing UTF-8 locales on Unix systems

Am 22.03.2023 um 18:58 schrieb Christian Ehrlicher: Am 22.03.2023 um 17:35 schrieb Volker Hilsheimer via Development:   But we use toLocal8Bit in plenty of cases as well. For instance in our Qt SQL APIs. The only plugin which really uses toLocal8Bit() is the IBase - Plugin. Correction

[Development] Future of java-style iterators?

Hi, Some days ago we got an error report in the forum about QHashIterator, turned out to be a missing documentation for a complete class which remained unnoticed since Qt 6.0 (https://bugreports.qt.io/browse/QTBUG-119461). This leads to the question if we should deprecate all java-style

[Development] Documentation and Q_GADGET / Q_PROPERTY

Hi, In the sql module I've some classes which do not derive from QObject but have a lot of setters/getters. For a nicer documentation without duplicating information I had the idea to convert them to properties. So I added Q_GADGET and a simple Q_PROPERTY with only a READ and WRITE property -

[Development] Issues with QPainter::drawPolygon (off by one error?)

Hello, I'm currently trying to investigate a painting problem within the windowsvista / common style:     QImage img(7, 7, QImage::Format_ARGB32_Premultiplied);     QPolygon poly{ QPoint(1, 1), {5, 1}, {3, 5} };     QPainter p();     p.setPen(Qt::NoPen);     p.setBrush(QColor(Qt::black));    

Re: [Development] Issues with QPainter::drawPolygon (off by one error?)

Am 28.04.2024 um 13:50 schrieb Allan Sandfeld Jensen: I think the problem with the cosmetic pen is partly the need to be symmetric. Years ago I tried cleaning up the cosmetic pen, but had to revert it because it violated rules about symmetry.

Re: [Development] Issues with QPainter::drawPolygon (off by one error?)

Am 26.04.2024 um 22:48 schrieb Henry Skoglund: On 2024-04-26 21:52, Christian Ehrlicher via Development wrote: Hello, I'm currently trying to investigate a painting problem within the windowsvista / common style:     QImage img(7, 7, QImage::Format_ARGB32_Premultiplied);     QPolygon poly