On Tuesday November 22 2011, Stephen Kelly wrote:
[...]
It is useful to move them to QtCore.
[...]
I never understood why QAIM is in QtCore and QAPM and the rest of the bunch
isn't.
+1
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group
of the function created in
Q_GLOBAL_STATIC, which is sequenced before any use of the result value of the
function.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
the typedef unconditional, or in the luxury variant
to add a configure switch (which I'd try to avoid...)
Why not just use a typedef:
typedef QRectImplint QRect;
typedef QRectImpldouble QRectD;
typedef QRectImplfloat QRectF;
?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior
other than the idiomatic QString().sprintf().
Unless there's a clever technique by which we can at compile-time catch
non-static uses of sprintf(), I'd propose to just deprecate it.
What do you think?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland
= QBasicRectint could do
the trick.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
the template with C++11 extern
templates (this would be a good idea for all templates, esp. those with
arguments constrained to just a few potential types). All other compilers:
who cares? :)
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG
On Tuesday February 21 2012, Marc Mutz wrote:
Hi,
The QString header contains a ### about removing sprintf() in 5.0, but it's
still there. I'd like to deprecate them.
I have a long-standing hate of the fact that QString::sprintf() is not
static, so my preferred solution would be to make
On Tuesday February 21 2012, Thiago Macieira wrote:
On terça-feira, 21 de fevereiro de 2012 10.33.12, Marc Mutz wrote:
2. Add static QString::{v,}asprintf()
Do we need them? You can't pass non-POD via ellipsis, so it's not very easy
to use. I'd much rather you invested time in a C++-style
On Tuesday February 21 2012, Thiago Macieira wrote:
On terça-feira, 21 de fevereiro de 2012 10.56.41, Marc Mutz wrote:
Bottomline: until we can expect variadic template support for Qt, I think
we need to keep it. Many people have over the years tried to eradicate
printf, but it's syntax
On Tuesday February 21 2012, Marc Mutz wrote:
On Tuesday February 21 2012, Marc Mutz wrote:
Hi,
The QString header contains a ### about removing sprintf() in 5.0, but
it's still there. I'd like to deprecate them.
I have a long-standing hate of the fact that QString::sprintf
On Tuesday February 21 2012, jan-arve.saet...@nokia.com wrote:
This leads me to my question:
Is there any reason why we cannot move QString::asprintf() to
QByteArray::asprintf() instead?
I'd be fine with that.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH
it all to a byte array just to use that, and
then convert it back.
That's exactly what QString::sprintf does right now - it only works on 8bit
strings, even though it stores the result in a QString.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland
On Tuesday February 21 2012, Marc Mutz wrote:
On Tuesday February 21 2012, you wrote:
On Tue, Feb 21, 2012 at 3:20 PM, jan-arve.saet...@nokia.com wrote:
Is there any reason why we cannot move QString::asprintf() to
QByteArray::asprintf() instead?
If your data is already in a QString
QT_NO_DEPRECATED/QT_NO_CAST_FROM_BYTEARRAY, so I don't see a big problem with
changing the return type.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB
of these changes, I could remove the vtable from QDataStream
and QDirIterator.
Any feedback is greatly appreciated.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46
On Wednesday March 7 2012, andre.poen...@nokia.com wrote:
Marc Mutz wote:
I've uploaded a patch series that makes most of the value classes in
QtCore final in the C++11 sense (ie. under a C++11 compiler, these can no
longer be inherited from).
I disagree with the idea of making Qt core
a safe-as-baseclass version available
(QBasicContainer), so existing designs can be ported with minimal effort, if
they need to be ported at all (they could just define Q_DECL_FINAL_CLASS
away). But I don't see the need to do this for all value classes.
Thanks,
Marc
--
Marc Mutz marc.m
about
containers and QString not being final, shared pointers, too, and I can see
how that would be a nuisance for legacy code out there, and unwanted at this
point in the Qt5 release, but what about - say - QMutexLocker?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
to what everyone
thinks primitive types mean, so I'd like to update the docs accordingly.
Opinions?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
.
If you want to avoid double initialisation, the correct way is
reserve()+push_back(), not resize()+operator[]. That works even for complex
types.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany
/questions/9417477/where-does-the-destructor-hide-in-this-code
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent
Hi Olivier,
Please excuse the delay in answering.
On Wednesday April 25 2012, Olivier Goffart wrote:
On Wednesday 25 April 2012 15:07:24 Marc Mutz wrote:
[...]
We could implement a move setter (Foo::setText(QString)). But that
would
mean duplication, and it could not be inline
On Tuesday May 8 2012, Thiago Macieira wrote:
On terça-feira, 8 de maio de 2012 15.22.55, Marc Mutz wrote:
I'm also giving each class a move constructor. There, the classes which
hold their pimpl in smart pointers create the problem[1] that the move
ctor cannot be inline. I'm tempted
a nicer name than QVector.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
On Thursday June 21 2012, André Pönitz wrote:
On Wed, Jun 20, 2012 at 08:52:55AM +0200, Marc Mutz wrote:
Hi Thiago,
[you knew this would be coming, I don't let you down]
On Monday June 18 2012, Thiago Macieira wrote:
* port QList
Before actually porting QList (esp. as I take
On Thursday June 21 2012, André Pönitz wrote:
On Thu, Jun 21, 2012 at 01:06:16AM +0200, Marc Mutz wrote:
On Thursday June 21 2012, André Pönitz wrote:
On Wed, Jun 20, 2012 at 08:52:55AM +0200, Marc Mutz wrote:
Hi Thiago,
[you knew this would be coming, I don't let you down
On Thursday June 21 2012, Marc Mutz wrote:
A(const A b) : a(sin(b.a) + cos(b.a)) {}
Btw: this class doesn't meet normal copy operation semantics and is therefore
not something anyone would ever stuff into a container (copies do not compare
equal). Such a class would be held by (smart
On Thursday June 21 2012, Thiago Macieira wrote:
On quinta-feira, 21 de junho de 2012 08.26.23, Marc Mutz wrote:
You meant
sizeof(T) _=_ 32 _||_ T is movable,
right?
Yes and no.
sizeof(T) = 32 T is movable
Assuming move constructors become ubiquitous on types that you'd want
-compiled code. I guess
that, at least for GCC users, it might therefore actually be a boon if a Qt
compiled in C++11 mode was incompatible with a Qt compiled in C++98 mode at,
say, the linker level, lest they ran into such hidden BiC issues unawares.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com
be a
bit subtle once a new QFuture appears in QtCore).
Any opinions either way?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts
On Thursday July 5 2012, Thiago Macieira wrote:
On quarta-feira, 4 de julho de 2012 23.09.03, Marc Mutz wrote:
Any opinions either way?
There are no plans to write any class to replace QFuture. However, renaming
the class right now is close to impossible due to source-compatibility
others. That would require a patch that made QList and QVector
identical, API-wise, and that, in turn, would require using member; support
in the compiler (the QT_NO_USING define is still in the code).
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH
this change in particular that keeps popping up on the ML...
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
. That will exclude non-C++11 compilers from seeing the more efficient
implementations, or else from the BC guarantee. Do we care?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden
On Wednesday July 18 2012, Oswald Buddenhagen wrote:
On Wed, Jul 18, 2012 at 12:25:37PM +0200, ext Marc Mutz wrote:
We don't even need to break binary compatibility. We could use inline
namespaces to let new code see the new containers while old code uses the
old ones.
and how exactly
On Wednesday July 18 2012, Olivier Goffart wrote:
On Wednesday 18 July 2012 14:00:08 Marc Mutz wrote:
On Wednesday July 18 2012, Oswald Buddenhagen wrote:
On Wed, Jul 18, 2012 at 12:25:37PM +0200, ext Marc Mutz wrote:
We don't even need to break binary compatibility. We could use inline
On Thursday July 19 2012, joao.abeca...@nokia.com wrote:
Marc Mutz wrote:
On Wednesday July 18 2012, joao.abeca...@nokia.com wrote:
I think it would be feasible to do a binary-only break somewhere
around the 5.2 timeframe (say, ~12 months) where we address this.
Technically, this would
hi Thiago,
There are two sides to this coin.
On Thursday July 19 2012, Thiago Macieira wrote:
On quinta-feira, 19 de julho de 2012 14.19.36, Marc Mutz wrote:
Even with inline namespaces? Then they would have failed to achieve their
goal to hide the fact that the type is in an inline
that a Qt5 application can't link against a Qt6 Qt
w/o recompilation.
I'm not fighting for this, don't get me wrong, I'm just setting misconceptions
straight.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com
On Friday July 20 2012, Olivier Goffart wrote:
On Thursday 19 July 2012 14:19:36 Marc Mutz wrote:
On Wednesday July 18 2012, Olivier Goffart wrote:
We discussed namespaces long time ago already, and decided not to put
Qt in
a namespace.
The reason is that it breaks source
expect people will become familiar with this sooner than
later. The C++11 std library is _full_ of noexcept tags.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46
this is what should happen for a _hash_, which
is supposed to be _fast_ :)
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software
qt_assert()
noexcept before putting it on, say, QMutex::lock() which calls it.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts
On Friday August 3 2012, Thiago Macieira wrote:
On quinta-feira, 2 de agosto de 2012 23.57.58, Marc Mutz wrote:
noexcept(std::declvalObject().f()) should work.
Unfortunately, while the C++11 compiler support seems to be going fine, the
library support is lagging WAY behind. Add
to
prepare :)
Outside C++/Qt, I'm (in)famous for my Sushi appetite and insisting on quality
food, of which I sadly eat too much.
Having passed through Oslo and Berlin, I currently live near Frankfurt/Main
with my wife.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB
On Tuesday August 14 2012, Donald Carr wrote:
I walked home with the man from a party at Volkers: Don't all germans
just default to black as a favourite colour?
Visigothic incursions noted
Only at Kraftverk... *sigh* sadly long since shut down...
--
Marc Mutz marc.m...@kdab.com | Senior
On Monday August 20 2012, Thiago Macieira wrote:
It seems a QVariant constructor that takes a QMetaType::Type is needed.
No, we don't think so.
We probably should add it, but deleted. To prevent that porting mistake.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB
On Monday August 20 2012, Thiago Macieira wrote:
On segunda-feira, 20 de agosto de 2012 18.22.53, Marc Mutz wrote:
On Monday August 20 2012, Thiago Macieira wrote:
It seems a QVariant constructor that takes a QMetaType::Type is
needed.
No, we don't think so.
We probably should
been ensured
of their full support on this.
So I guess the question now becomes: would you, the community, have me? :)
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ
On Thursday September 6 2012, Marc Mutz wrote:
[DRAFT]
Erhm, this isn't draft anymore, promised :)
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt
Hi Lars,
On Wednesday September 19 2012, Knoll Lars wrote:
For the rest of Qt Widgets Marc Mutz has volunteered. I'm really happy to
see him step up to this and support the nomination. But as the area is
rather large, I would longer term be happier if we have separate
maintainers
from Qt's HTML docs, but at some Qt version this
broke).
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent
://en.wikipedia.org/wiki/Liskov_substitution_principle
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
requirement, I'd say we play it safe and stay with
the two-line fix.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform
. in constructors, or just
after a new-expression, or when the type has been created as an automatic
object.
If it does, the symbol needs to be available.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30
to prevent the Gerrit review of the patch (a
necessary precondition for obtaining a final SHA1 of the commit) from
(prematurely) disclosing the vulnerability?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com
On Tuesday October 9 2012, Thiago Macieira wrote:
On terça-feira, 9 de outubro de 2012 18.19.19, Marc Mutz wrote:
It would still break forward compatibility. Assume you do the change in
5.0.1, and an app gets compiled against 5.0.1 using the new symbol (by
not reimplementing
that
introduced the regression.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
require a disconnect/connect pair.
The full solution would be to try to remove all _q_slots() from Qt 5.0. Seeing
as this change could also be done in 5.1, I'd only propose to ban _new_
_q_slots() from being added.
Opinions?
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
On Friday October 12 2012, Thiago Macieira wrote:
On sexta-feira, 12 de outubro de 2012 07.27.51, Marc Mutz wrote:
Hi,
I was wondering whether we should stop using the pattern of declaring
_q_privateSlots() in favour of connecting to functors or functions
directly.
Makes sense, except
On Friday October 12 2012, Olivier Goffart wrote:
On Friday 12 October 2012 10:26:04 Olivier Goffart wrote:
On Thursday 11 October 2012 23:06:18 Thiago Macieira wrote:
On sexta-feira, 12 de outubro de 2012 07.27.51, Marc Mutz wrote:
Hi,
I was wondering whether we should stop
bytes, so I'm out of ideas.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
?
BTW: Two of the three commits that have landed in 'dev' so far are bug-fixes
(one bug-fix and one tests/-only change, to be precise; the third is the
addition of changes-5.1.0), which shows that the 'stable' rules seem to be
interpreted too strictly, currently.
Thanks,
Marc
--
Marc Mutz marc.m
On Sunday December 9 2012, Sune Vuorela wrote:
On 2012-12-09, Sune Vuorela nos...@vuorela.dk wrote:
On 2012-12-09, Marc Mutz marc.m...@kdab.com wrote:
3. new features and bug-fixes that require new strings or BiC changes
should be submitted to 'dev' directly.
binary incompatible
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
___
Development
On Tuesday December 11 2012, Marc Mutz wrote:
text/vnd.qt.quick+qml
text/vnd.rim.cascades+qml (assuming that's what you meant with BB above)
or +vnd.t.qml, just to be extra paranoid in case W3C develops a Quantum
Modelling Language anytime soon and finds their suffix gone.
--
Marc Mutz
in the vnd.qt
tree :)
There are trees other than vnd., btw, but I forgot which ones. One of them
might lend itself better to this kind of prefixing that vnd.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com
Hi all,
On Wednesday December 19 2012, Marc Mutz wrote:
... please cut me some slack while I handle the attached non-maskable
interrupt :)
It took longer than initially expected, but I'm told that's to be expected,
too.
But I'm back in business again, trying to get a hold on the last two
On 2013-09-12 08:07, André Somers wrote:
Op 11-9-2013 17:19, David Faure schreef:
Couldn't such a class be part of the hopefully coming QtConcurrent
replacement?
Can we forget about threads for a second?
No, I'd rather not forget that huge pink elephant in the room... In
this
age of
Hi,
The following backtrace shows QXcbIntegration's ctor, which is called
from QCoreApplication's ctor, call
QGuiApplicationPrivate::setEventDispatcher(). At that time, the
application object isn't yet a QGuiApplication.
#1 0x2aaac96e100d in QGuiApplicationPrivate::q_func
On 2013-09-17 12:30, Sze Howe Koh wrote:
[...]
Example:
#include QMultimedia pulls in the QMultimedia namespace only, but
#include QtMultimedia pulls in the QMultimedia namespace PLUS all
the audio, video, radio, camera etc. classes. This can adversely
impact compilation times for large
On 2013-09-27 06:22, Mandeep Sandhu wrote:
[...]
How do I find the next-best person for review? Check a file's git log
and see who's committed to it most often?
[...]
I usually check who's active in a file, or failing that, in a
subdirectly, with git log, mentally removing the shotgun surgery
Hi,
I'm seeing a .data.rel.ro.local for staticMetaObject in objdump -TtRr
for (apparently) each Q_GADGET use (say, QEvent, QSizePolicy), but not
for any Q_OBJECT use (say QWidget, but funnily enough for QObject).
I don't see any difference between the staticMetaObject's declared in
and
On 2013-10-04 07:34, Kurt Pattyn wrote:
In some markets like Avionics and Defense, it is simply forbidden for
us to use exceptions.
The only reason to forbid exceptions on technical (as opposed to
uneducated or -worse- political) grounds is in hard real-time systems,
because throwing an
On Friday, October 18, 2013 12:55:07 AM Jiergir Ogoerg wrote:
Thanks, that worked.
I compiled the 72...49 snapshot on both Ubuntu 13.10 and Fedora 20 and I
still get the same 130-160ms, though I clearly recall getting about 70ms
with the first pre-beta.
Since I have no idea what's the deal
On Tuesday, October 29, 2013 01:21:08 Jiergir Ogoerg wrote:
Hi,
There's an enum:
//== code
enum TableState
{
UnsupportedLocale,
EmptyTable,
UnknownSystemComposeDir,
MissingComposeFile,
NoErrors
};
//== code
and this:
//== code
On Friday, November 01, 2013 15:35:50 Marc Mutz wrote:
enum object that does have one of the declared enum values results in
does _not_ have, of course.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman
On Thursday, October 31, 2013 16:52:28 Jiergir Ogoerg wrote:
Is there a list of other startup optimizations you're working on
so that we don't dilute the efforts by working on the same thing?
Not directly related, but I've got some WIP on reducing relocations in Qt.
I've pretty much removed
On Saturday, November 02, 2013 02:35:20 Thiago Macieira wrote:
On sexta-feira, 1 de novembro de 2013 15:35:50, Marc Mutz wrote:
According to the standard, they are equivalent, since reading a value
from an enum object that does have one of the declared enum values
results in undefined
On Monday, November 04, 2013 12:24:37 Marc Mutz wrote:
The issue is with the casts to enums in some of the QFlags operators, IIRC,
but the log I cited is old and the line numbers might not match anymore.
I've dug up attached attempt to fix the issue, with which I am, however, not
pleased
On Friday, November 01, 2013 23:49:22 Jiergir Ogoerg wrote:
Anyway who's the hero of the day (and is a contributor) to commit a fix for
this bug?
Finders keepers ;)
___
Development mailing list
Development@qt-project.org
On Monday, November 04, 2013 17:15:26 Thiago Macieira wrote:
On segunda-feira, 4 de novembro de 2013 12:31:22, Marc Mutz wrote:
+Q_DECL_CONSTEXPR inline QFlags operator|(QFlags f) const { return
QFlags(i | f.i, true); } +Q_DECL_CONSTEXPR inline QFlags
operator|(Enum f) const
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
@@ -206,7 +212,8 @@ protected:
int qt4D;
Qt::Orientation qt4O;
Qt::MouseButtons mouseState;
-int reserved;
+uint ph : 2;
+int reserved : 30;
};
#endif
is sizeof(int) == 4 everywhere?
---
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
@@ -101,9 +102,10 @@ public:
{
if (dirty) {
dirty = false;
-QVectorT sorted = values;
-qSort(sorted);
-currentMedian = sorted.at(bufferSize / 2 + 1);
+
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
diff --git a/src/corelib/json/qjsonvalue.h b/src/corelib/json/qjsonvalue.h
index b8bdf55..c0ecdd2 100644
--- a/src/corelib/json/qjsonvalue.h
+++ b/src/corelib/json/qjsonvalue.h
@@ -79,6 +79,7 @@ public:
QJsonValue(bool b);
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
+// ### Qt 6: Merge with above with default offsetSeconds = 0
+QDateTime(const QDate date, const QTime time, Qt::TimeSpec spec, int
offsetSeconds);
+#ifndef QT_BOOTSTRAPPED
+QDateTime(const QDate date, const QTime time,
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
+++ b/src/corelib/tools/qmargins.h
@@ -242,6 +242,24 @@ inline QMargins QMargins::operator-=(const QMargins
margins) return *this = *this - margins;
}
+inline QMargins QMargins::operator+=(int margin)
+{
+m_left +=
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
-return (void *)qptrdiff(data);
+char *null = 0;
+return null + qptrdiff(data);
Since this is equivalent to
return 0[qptrdiff(data)];
isn't that dereferencing the nullptr and therefore
On Tuesday, November 05, 2013 18:00:02 Nicolás Alvarez wrote:
2013/11/5 Marc Mutz marc.m...@kdab.com:
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
-return (void *)qptrdiff(data);
+char *null = 0;
+return null + qptrdiff(data
On Tuesday, November 05, 2013 17:42:38 Thiago Macieira wrote:
I think that was intentional since JSON is still using ECMAScript data
types, whose Number type is a double precision floating point. Inserting
any integer larger than 2^52 will result in loss of precision. So this
forces people to
On Tuesday, November 05, 2013 14:32:03 John Layt wrote:
On 5 November 2013 12:03, Marc Mutz marc.m...@kdab.com wrote:
On Tuesday, November 05, 2013 01:07:32 Thiago Macieira wrote:
+// ### Qt 6: Merge with above with default offsetSeconds = 0
+QDateTime(const QDate date, const QTime
On Tuesday, November 05, 2013 17:51:25 Thiago Macieira wrote:
On terça-feira, 5 de novembro de 2013 11:09:48, Giuseppe D'Angelo wrote:
class Q_WIDGETS_EXPORT QMacCocoaViewContainer : public QWidget
{
Q_OBJECT
public:
-QMacCocoaViewContainer(void
-project.org/70801
https://codereview.qt-project.org/70802
That's all from the header diff.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB
On Tuesday, November 19, 2013 05:02:32 AM Thiago Macieira wrote:
There were exactly 31 commits with [ChangeLog]. Please start using it more.
Samuel Gaist (thanks) suggested in PM to add a check to the sanity bot.
Good idea? I think it is.
Thanks,
Marc
--
Marc Mutz marc.m...@kdab.com | Senior
On Monday, November 25, 2013 12:20:05 PM Joerg Bornemann wrote:
On 25.11.2013 10:53, Marc Mutz wrote:
There were exactly 31 commits with [ChangeLog]. Please start using it
more.
Samuel Gaist (thanks) suggested in PM to add a check to the sanity bot.
How would the bot know whether
On Monday, November 25, 2013 06:26:38 PM Alan Alpert wrote:
On Mon, Nov 25, 2013 at 7:49 AM, Thiago Macieira
thiago.macie...@intel.com wrote:
On segunda-feira, 25 de novembro de 2013 12:49:11, Marc Mutz wrote:
I have found that significantly more than 50% of commits that touched
qtbase
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
co-locate definition and first assignment, use QVector::swap()
for fast assignment.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform
= (QComposeTableElement*) (buf + (i * kElemSize));
vec-push_back(*elem);
}
you should use push_back(qMove(*elem)) and implement the move operation on
QComposableTableElement.
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
?
Thanks,
Marc
[1] http://stackoverflow.com/questions/2526974/qt-undocumented-method-
setsharable/11108588#11108588
--
Marc Mutz marc.m...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB
1 - 100 of 968 matches
Mail list logo
