[Development] QString::fromAscii toAscii's future

2012-04-24 Thread Thiago Macieira
Since Qt 3 days[1], QString::fromAscii has stood for from C strings with Ascii standing for that which the developer writes, instead of its proper definition of US-ASCII, a.k.a. ANSI X3.4-1986. By default, it was Latin 1 in Qt 3 and Qt 4. In addition, QTextCodec::setCodecForCStrings could be used

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread Robin Burchell
2012/4/24 Thiago Macieira thiago.macie...@intel.com: My recommendation is a variant of options 3: we document that it accepts only US-ASCII and that it has undefined behaviour when the input isn't US-ASCII compliant. That way, we can make it be equal to toLatin1() and avoid having to write

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread BRM
- Original Message - From: Robin Burchell robin...@viroteck.net 2012/4/24 Thiago Macieira thiago.macie...@intel.com: My recommendation is a variant of options 3: we document that it accepts only US-ASCII and that it has undefined behaviour when the input isn't US-ASCII

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread Thiago Macieira
On terça-feira, 24 de abril de 2012 15.36.24, Olivier Goffart wrote: On Tuesday 24 April 2012 14:27:10 Thiago Macieira wrote: The question I have is: what shall we do with QString::fromAscii? My personal preference would be to deprecate it. The name is confusing compared to the others that

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread Thiago Macieira
On terça-feira, 24 de abril de 2012 07.33.41, BRM wrote: Question: is there are reason not to support the US-Extended ASCII (128-255)? I know it's not used often, but sometimes those characters are very useful. There's no such encoding. The use of the term is sometimes criticized, because it

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread kai.koehne
::fromAscii toAscii's future [...] In any case, deprecating is orthogonal to the behaviour. What should the function do? There's no use in 'fixing' fromAscii(), toAscii() if we're deprecating it anyway (which I support). So just let it be a synonym to fromLatin1(), toLatin1(), which

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread 1+1=2
On Tue, Apr 24, 2012 at 8:01 AM, kai.koe...@nokia.com wrote: There's no use in 'fixing' fromAscii(), toAscii() if we're deprecating it anyway (which I support). So just let it be a synonym to fromLatin1(), toLatin1(), which it was by default anyway in Qt4. I like the idea.

Re: [Development] QString::fromAscii toAscii's future

2012-04-24 Thread Loaden
- From: development-bounces+kai.koehne=nokia@qt-project.org [mailto:development-bounces+kai.koehne=nokia@qt-project.org] On Behalf Of ext Thiago Macieira Sent: Tuesday, April 24, 2012 4:54 PM To: development@qt-project.org Subject: Re: [Development] QString::fromAscii toAscii's future