Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-11 Thread Konstantin Ritt
2016-02-11 3:47 GMT+04:00 Thiago Macieira : > On quinta-feira, 11 de fevereiro de 2016 03:00:02 PST Konstantin Ritt > wrote: > > > CaseSensitive => no case folding, no > > > normalisation > > > CaseSensitiveNormalized => no case

Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-11 Thread Thiago Macieira
On quinta-feira, 11 de fevereiro de 2016 13:26:50 PST Konstantin Ritt wrote: > BTW, *_wcsicmp* compares strings by simply converting them to their > lowercase forms. > So what you suggest? Changing Qt::CaseInsensitive string comparison to not > use casefolding and introduce more option(s) for

[Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-10 Thread Thiago Macieira
Hi all (especially Konstantin!) When reviewing a change, I noticed that QString::startsWith with CaseInsensitive compares things like this: if (foldCase(data[i]) != foldCase((ushort)latin[i])) return false; with foldCase() being convertCase_helper(ch), whereas

Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-10 Thread Knoll Lars
Hi Thiago, On 10/02/16 19:27, "Development on behalf of Thiago Macieira" wrote: >Hi all > >(especially Konstantin!) > >When reviewing a change, I noticed that QString::startsWith with >CaseInsensitive compares

Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-10 Thread Konstantin Ritt
2016-02-10 23:46 GMT+04:00 Knoll Lars : > Hi Thiago, > > On 10/02/16 19:27, "Development on behalf of Thiago Macieira" < > development-boun...@qt-project.org on behalf of thiago.macie...@intel.com> > wrote: > > > > > > >Hi all > > > >(especially Konstantin!) > > >

Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-10 Thread Thiago Macieira
On quarta-feira, 10 de fevereiro de 2016 19:46:49 PST Knoll Lars wrote: > They should only compare true with full case folding rules. This is > something we have so far not implemented in Qt; as you noted below we're > still using simple case folding rules. > > This is actually somewhat similar

Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-10 Thread Konstantin Ritt
2016-02-11 1:36 GMT+04:00 Thiago Macieira : > On quarta-feira, 10 de fevereiro de 2016 19:46:49 PST Knoll Lars wrote: > > They should only compare true with full case folding rules. This is > > something we have so far not implemented in Qt; as you noted below we're > >

Re: [Development] Qt::CaseInsensitive comparison is not the same as toLower() comparison

2016-02-10 Thread Thiago Macieira
On quinta-feira, 11 de fevereiro de 2016 03:00:02 PST Konstantin Ritt wrote: > > CaseSensitive => no case folding, no > > normalisation > > CaseSensitiveNormalized => no case folding, but normalised > > CaseInsensitive =>