Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Albert Astals Cid
On Friday 23 August 2013 07:50:56 Olivier Goffart wrote: On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki wrote: On 22.08.2013 21:51, Thiago Macieira wrote: On quinta-feira, 22 de agosto de 2013 21:26:15, Antti Kaijanmäki wrote: I have patches (linked in the bug) to amend this, and I

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Simon Hausmann
On Friday 23. August 2013 09.24.54 Albert Astals Cid wrote: On Friday 23 August 2013 07:50:56 Olivier Goffart wrote: On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki wrote: On 22.08.2013 21:51, Thiago Macieira wrote: On quinta-feira, 22 de agosto de 2013 21:26:15, Antti Kaijanmäki

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Giuseppe D'Angelo
On 23 August 2013 09:24, Albert Astals Cid albert.ast...@canonical.com wrote: Also i don't understand that P1 rule for stable, what's the rationale to not fixing bugs in stable? That's what stable branch is for, no? I could understand P1 rule for release, but for stable, what if i fix a

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Albert Astals Cid
On Friday 23 August 2013 09:48:26 Simon Hausmann wrote: On Friday 23. August 2013 09.24.54 Albert Astals Cid wrote: On Friday 23 August 2013 07:50:56 Olivier Goffart wrote: On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki wrote: On 22.08.2013 21:51, Thiago Macieira wrote: On

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Simon Hausmann
On Friday 23. August 2013 10.04.35 Albert Astals Cid wrote: On Friday 23 August 2013 09:48:26 Simon Hausmann wrote: On Friday 23. August 2013 09.24.54 Albert Astals Cid wrote: On Friday 23 August 2013 07:50:56 Olivier Goffart wrote: On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Olivier Goffart
On Friday 23 August 2013 09:24:54 Albert Astals Cid wrote: On Friday 23 August 2013 07:50:56 Olivier Goffart wrote: On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki wrote: On 22.08.2013 21:51, Thiago Macieira wrote: On quinta-feira, 22 de agosto de 2013 21:26:15, Antti Kaijanmäki

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Albert Astals Cid
On Friday 23 August 2013 10:24:01 Simon Hausmann wrote: On Friday 23. August 2013 10.04.35 Albert Astals Cid wrote: On Friday 23 August 2013 09:48:26 Simon Hausmann wrote: On Friday 23. August 2013 09.24.54 Albert Astals Cid wrote: On Friday 23 August 2013 07:50:56 Olivier Goffart wrote:

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-23 Thread Sorvig Morten
On Aug 23, 2013, at 10:32 AM, Olivier Goffart oliv...@woboq.com wrote: https://codereview.qt-project.org/#change,62948 is linked to a bug without categorization This one went to stable because - crash/infinite loop fix - trivial patch for a corner case - fix for new functionality. I don't

[Development] Some QIcon::fromTheme() enhancements

2013-08-22 Thread Antti Kaijanmäki
Hi, I filed a bug[0] about QIconLoader not being able to load icons from /usr/share/pixmaps and not supporting XPM icons. Both are required in the Icon Theme Specification[1]. I have patches (linked in the bug) to amend this, and I would like to get some feedback on them. I also discovered

Re: [Development] Some QIcon::fromTheme() enhancements

2013-08-22 Thread Olivier Goffart
On Thursday 22 August 2013 22:18:54 Antti Kaijanmäki wrote: On 22.08.2013 21:51, Thiago Macieira wrote: On quinta-feira, 22 de agosto de 2013 21:26:15, Antti Kaijanmäki wrote: I have patches (linked in the bug) to amend this, and I would like to get some feedback on them. Hello Antti