Re: [Development] Why does Q_ENUM() need qRegisterMetaType()?

2019-07-04 Thread Thiago Macieira
On Thursday, 4 July 2019 11:18:26 -03 Vlad Stelmahovsky wrote: > isn't Q_ENUM is deprecated and now Q_ENUMS should be used instead? or vice > versa...always forgetting Q_ENUMS is deprecated and you should use Q_ENUM. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect -

Re: [Development] Why does Q_ENUM() need qRegisterMetaType()?

2019-07-04 Thread Olivier Goffart
On 04.07.19 12:43, Tom Isaacson wrote: The problem is that moc only generates the code that calls qRegisterMetaType if it sees Q_DECLARE_METATYPE. Actually, it does a bit more than that. It could as well do it for Q_ENUM type, just not implemented yet. We should consider doing it for all the

Re: [Development] Why does Q_ENUM() need qRegisterMetaType()?

2019-07-04 Thread Vlad Stelmahovsky
isn't Q_ENUM is deprecated and now Q_ENUMS should be used instead? or vice versa...always forgetting :) On Thu, Jul 4, 2019 at 4:14 PM Olivier Goffart wrote: > On 04.07.19 12:43, Tom Isaacson wrote: > >> The problem is that moc only generates the code that calls > qRegisterMetaType if it sees

Re: [Development] Moving to Gerrit 2.16.9

2019-07-04 Thread Robert Loehning
Am 01.07.2019 um 19:57 schrieb André Pönitz: > On Mon, Jul 01, 2019 at 02:43:43PM +, Frederik Gladhorn wrote: and I'll give Gravatar a spin: https://gerrit-review.googlesource.com/admin/repos/plugins/avatars-gravata r >> >> It's there, enjoy and put your avatar up at

Re: [Development] Why does Q_ENUM() need qRegisterMetaType()?

2019-07-04 Thread Olivier Goffart
On 03.07.19 22:25, Tom Isaacson wrote: No response on Qt Interest so trying here. I'm using Qt 5.12.2 on Visual Studio 2019 / Win7. I wanted to make sure Q_ENUM works the way I think it does before updating some legacy code so I wrote a unit test (we use Google Test): TestConnectEnum.h:

Re: [Development] Why does Q_ENUM() need qRegisterMetaType()?

2019-07-04 Thread Tom Isaacson
> The problem is that moc only generates the code that calls qRegisterMetaType > if it sees Q_DECLARE_METATYPE. Actually, it does a bit more than that. It > could as well do it for Q_ENUM type, just not implemented yet. > > We should consider doing it for all the types used in >