Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Christian Ehrlicher
Am 09.02.2019 um 18:02 schrieb Thiago Macieira: On Saturday, 9 February 2019 07:30:36 PST Christian Ehrlicher wrote: QT_DISABLE_DEPRECATED_BEFORE=0x051300: Uh, that's 0x050d00 :-) Ah, this explains why I also got warnings/erros about functions which got deprecated in 5.14 :) Christian

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Thiago Macieira
On Friday, 8 February 2019 22:34:21 PST Giuseppe D'Angelo via Development wrote: > Agree with the rest of the email. From a purely technical point of > view, however, I'm wondering why we didn't see those warnings before? Qt > was already built with warnings enabled AFAICS? For instance:

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Thiago Macieira
On Saturday, 9 February 2019 01:00:46 PST Allan Sandfeld Jensen wrote: > By fixed I guess you also mean suppressed were appropriate? some are from > tests testing deprecated functions, and other are deprecated functions > calling other deprecated functions because they belong together. Yes,

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Thiago Macieira
On Saturday, 9 February 2019 07:30:36 PST Christian Ehrlicher wrote: > QT_DISABLE_DEPRECATED_BEFORE=0x051300: Uh, that's 0x050d00 :-) -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products ___

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Giuseppe D'Angelo via Development
Il 09/02/19 08:11, Christian Ehrlicher ha scritto: It was only enabled for src, not for examples and tests so I did not saw the warnings before your commit I would guess. So even functions which were already marked deprecated for a long time did not trigger warnings. Fixing all the examples and

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Christian Ehrlicher
Am 09.02.2019 um 02:27 schrieb Thiago Macieira: By beta, those that aren't fixed will get P1 bug reports in JIRA. for qtbase/src - feel free to review them :) https://codereview.qt-project.org/252626 https://codereview.qt-project.org/252627 https://codereview.qt-project.org/252628

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Christian Ehrlicher
Am 09.02.2019 um 10:00 schrieb Allan Sandfeld Jensen: By beta, those that aren't fixed will get P1 bug reports in JIRA. By fixed I guess you also mean suppressed were appropriate? some are from tests testing deprecated functions, and other are deprecated functions calling other deprecated

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-09 Thread Allan Sandfeld Jensen
On Samstag, 9. Februar 2019 02:27:20 CET Thiago Macieira wrote: > Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the > QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That > means we started seeing lots of warnings that weren't there in 5.12. > > ALL such

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-08 Thread Christian Ehrlicher
Am 09.02.2019 um 07:34 schrieb Giuseppe D'Angelo via Development: Hi, Il 09/02/19 02:27, Thiago Macieira ha scritto: Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That means we started seeing lots of

Re: [Development] All deprecation warnings are P1 for 5.13.0

2019-02-08 Thread Giuseppe D'Angelo via Development
Hi, Il 09/02/19 02:27, Thiago Macieira ha scritto: Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That means we started seeing lots of warnings that weren't there in 5.12. Agree with the rest of the

[Development] All deprecation warnings are P1 for 5.13.0

2019-02-08 Thread Thiago Macieira
Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That means we started seeing lots of warnings that weren't there in 5.12. ALL such warnings must be fixed by 5.13.0 release. Please treat them as P1 (or P½