Re: [Development] Enabling private features for separate modules

2017-06-20 Thread Oswald Buddenhagen 
On Mon, Jun 19, 2017 at 08:32:43PM +0300, Alexander Volkov wrote:
> 19.06.2017 20:06, Oswald Buddenhagen пишет:
> > On Mon, Jun 19, 2017 at 01:52:59PM +0300, Alexander Volkov wrote:
> >> $ qmake -- -system-ffmpeg
> >> ***Unknown option -system-ffmpeg
> >>
> > you need to specify a file/directory, if only ".".
> >
> Yes, it works this way, thanks.
> Is there a reason for such behavior or is it a bug?
>
bug. patches welcome.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Alexander Volkov 

19.06.2017 20:06, Oswald Buddenhagen пишет:

On Mon, Jun 19, 2017 at 01:52:59PM +0300, Alexander Volkov wrote:

19.06.2017 12:53, Oswald Buddenhagen пишет:

On Mon, Jun 19, 2017 at 12:52:12PM +0300, Alexander Volkov wrote:

Hi,

I build qtwebengine as a separate module.
What is the right way to enable system-ffmpeg feature?


you use

qmake [usual qmake args] -- [configure args]


$ qmake -- -system-ffmpeg
***Unknown option -system-ffmpeg


you need to specify a file/directory, if only ".".


Yes, it works this way, thanks.
Is there a reason for such behavior or is it a bug?
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Oswald Buddenhagen 
On Mon, Jun 19, 2017 at 01:52:59PM +0300, Alexander Volkov wrote:
> 19.06.2017 12:53, Oswald Buddenhagen пишет:
> > On Mon, Jun 19, 2017 at 12:52:12PM +0300, Alexander Volkov wrote:
> >> Hi,
> >>
> >> I build qtwebengine as a separate module.
> >> What is the right way to enable system-ffmpeg feature?
> >>
> > you use
> >
> >qmake [usual qmake args] -- [configure args]
> >
> 
> $ qmake -- -system-ffmpeg
> ***Unknown option -system-ffmpeg
>
you need to specify a file/directory, if only ".".

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Allan Sandfeld Jensen 
On Montag, 19. Juni 2017 11:52:12 CEST Alexander Volkov wrote:
> Hi,
> 
> I build qtwebengine as a separate module.
> What is the right way to enable system-ffmpeg feature?
> It's not auto-detected:
>   "system-ffmpeg": {
>   "label": "ffmpeg",
>   "autoDetect": false,
>   "condition": "libs.ffmpeg && features.system-opus &&
> features.system-webp",
>   "output": [ "privateFeature" ]
>   }
> 
If all else fail you can always edit the generate qtwebengine-config.pri file 
and move the feature from disabled features to enabled features.

' Allan

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Alexander Volkov 

19.06.2017 13:59, Dominik Holland пишет:

$ qmake -- -system-ffmpeg
***Unknown option -system-ffmpeg

I think it needs to be:

qmake -- --enable-system-ffmpeg

if you want to add your own options you can also add a "commandline"
section to configure.json
It also doesn't work. Somehow this way of passing extra arguments with 
'--' doesn't work in release builds.

I tested it in my developer build and it works.
Also I found that it was introduced by 
https://codereview.qt-project.org/#/c/159056/

and there is another way of passing extra arguments with QMAKE_EXTRA_ARGS:
qmake QMAKE_EXTRA_ARGS+="-system-ffmpeg" works.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Dominik Holland 
Am 06/19/2017 um 12:52 PM schrieb Alexander Volkov:

> 19.06.2017 12:53, Oswald Buddenhagen пишет:
>> On Mon, Jun 19, 2017 at 12:52:12PM +0300, Alexander Volkov wrote:
>>> Hi,
>>>
>>> I build qtwebengine as a separate module.
>>> What is the right way to enable system-ffmpeg feature?
>>>
>> you use
>>
>>qmake [usual qmake args] -- [configure args]
>>
>
> $ qmake -- -system-ffmpeg
> ***Unknown option -system-ffmpeg

I think it needs to be:

qmake -- --enable-system-ffmpeg

if you want to add your own options you can also add a "commandline"
section to configure.json

Dominik
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Alexander Volkov 

19.06.2017 12:53, Oswald Buddenhagen пишет:

On Mon, Jun 19, 2017 at 12:52:12PM +0300, Alexander Volkov wrote:

Hi,

I build qtwebengine as a separate module.
What is the right way to enable system-ffmpeg feature?


you use

   qmake [usual qmake args] -- [configure args]



$ qmake -- -system-ffmpeg
***Unknown option -system-ffmpeg
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Enabling private features for separate modules

2017-06-19 Thread Oswald Buddenhagen 
On Mon, Jun 19, 2017 at 12:52:12PM +0300, Alexander Volkov wrote:
> Hi,
> 
> I build qtwebengine as a separate module.
> What is the right way to enable system-ffmpeg feature?
>
you use

  qmake [usual qmake args] -- [configure args]

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Enabling private features for separate modules

2017-06-19 Thread Alexander Volkov 

Hi,

I build qtwebengine as a separate module.
What is the right way to enable system-ffmpeg feature?
It's not auto-detected:
 "system-ffmpeg": {
 "label": "ffmpeg",
 "autoDetect": false,
 "condition": "libs.ffmpeg && features.system-opus && 
features.system-webp",

 "output": [ "privateFeature" ]
 }

Cheers,
Alexander.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development