Re: [Development] Copyright changes
On 03/03/2013 01:23 AM, Rohan McGovern wrote: On Sat, Mar 2, 2013 at 3:34 PM, Laszlo Papp lp...@kde.org wrote: I will take you meant QT_MODULE_TO_TEST=qtdeclarative qtqa/tests/prebuild/license/tst_licenses.pl Yeah, I used this script earlier, but I did not know it is already integrated into the CI. Couldn't this be integrated into a bot rather than CI? It would be nice to know even before pressing the staging button. It does not seem to run long either. Sure, there is a long standing task for that, https://bugreports.qt-project.org/browse/QTQAINFRA-309 . It just waits for somebody to do the work. The current sanity bot has all checks implemented in a couple of big loops and is not designed to call out to separate scripts, so this task may include some refactoring of the sanity bot. I did a simple bot based on the doc bot to check the licenses in Gerrit. it was a work in progress .. but it might help if somebody wants to do it properly https://codereview.qt-project.org/35648 Since Oswald wants this integrated with the sanity bot, then maybe the task can be re-opened and assigned to him. Cheers, -- Sergio Ahumada Release Engineer - Digia, Qt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On 03/01/2013 10:28 AM, Hirvonen Olli wrote: Hi all, We would appreciate Your help in one quite trivial task. With a joint effort together it also should be reasonable small task for individual developer. Digia acquired all Nokia's Qt copyrights last year. We have already changed the copyrights in main branches. All non-Nokia copyrights remain unchanged. [snip] 3.There are repositories where copyright is right, but LGPL_EXCEPTION.txt is Nokia version. Examples: installer-framework\installer-framework playground\qtserialport qt-labs\messagingframework qt-labs\qtest-qml qt-mobility\qt-mobility can you provide the LGPL_EXCEPTION.txt file as well or can we just use https://qt.gitorious.org/qt/qtbase/blobs/stable/LGPL_EXCEPTION.txt as a template ? what about https://qt.gitorious.org/qt/qtbase/blobs/stable/LICENSE.PREVIEW.COMMERCIAL ? should be change as well or is not needed ? Cheers, -- Sergio Ahumada Release Engineer - Digia, Qt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On Sat, Mar 2, 2013 at 3:34 PM, Laszlo Papp lp...@kde.org wrote: I will take you meant QT_MODULE_TO_TEST=qtdeclarative qtqa/tests/prebuild/license/tst_licenses.pl Yeah, I used this script earlier, but I did not know it is already integrated into the CI. Couldn't this be integrated into a bot rather than CI? It would be nice to know even before pressing the staging button. It does not seem to run long either. Sure, there is a long standing task for that, https://bugreports.qt-project.org/browse/QTQAINFRA-309 . It just waits for somebody to do the work. The current sanity bot has all checks implemented in a couple of big loops and is not designed to call out to separate scripts, so this task may include some refactoring of the sanity bot. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On Fri, Mar 01, 2013 at 09:28:13AM +, Hirvonen Olli wrote: 1. Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies) or something similar with different year. For example in: several of these repositories are just dead (and will soon be moved and marked as such once we figure out which ones exactly these are). does it still make sense to adjust copyrights in these? ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On Fri, Mar 1, 2013 at 9:28 AM, Hirvonen Olli olli.hirvo...@digia.comwrote: **2. **In some repositories company copyright is missing and there is only original author copyright. Example: ** Copyright (C) 2012 Firstname Surname em...@xyz.org ** Contact: http://www.qt-project.org/ Is that wrong? What if no one pays someone to work on a change? Also, perhaps you could make a qtqa checker script for these, run them, and publish the result so we can see the issues at a centralized place? For instance, we meant to fix everything in QtSerialPort a while ago, so I am wondering why it is still on your list. I guess this is a generic issue. Perhaps there could be a license checker bot, or just directly integrated into an existing bot like the sanity/doc checker? Laszlo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
I discussed with Tuukka Turunen and his opinion was that even something is not developed further, but it is available, copyrights should be the correct ones. But as said this is not the most urgent issue and priority is low. And sorry if the examples I used were fixed already. I got those examples from Janne Anttila over a month ago and this was just pending in my emails :/ I hope that someone more technical person could reply to Laszlo if license checker bot would be possible or a good idea? -Olli -Original Message- From: Of Oswald Buddenhagen On Fri, Mar 01, 2013 at 09:28:13AM +, Hirvonen Olli wrote: 1. Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies) or something similar with different year. For example in: several of these repositories are just dead (and will soon be moved and marked as such once we figure out which ones exactly these are). does it still make sense to adjust copyrights in these? --- Laszlo wrote: ** Copyright (C) 2012 Firstname Surname em...@xyz.org ** Contact: http://www.qt-project.org/ Is that wrong? What if no one pays someone to work on a change? Also, perhaps you could make a qtqa checker script for these, run them, and publish the result so we can see the issues at a centralized place? For instance, we meant to fix everything in QtSerialPort a while ago, so I am wondering why it is still on your list. I guess this is a generic issue. Perhaps there could be a license checker bot, or just directly integrated into an existing bot like the sanity/doc checker? Laszlo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
tests/prebuild/license in qtqa repo is just for that purpose though I am not sure how it got run on every qt5 module repo. http://qt.gitorious.org/qt/qtqa/trees/master/tests/prebuild/license Regards, Liang On 2013-3-1, at 下午12:24, Hirvonen Olli wrote: I discussed with Tuukka Turunen and his opinion was that even something is not developed further, but it is available, copyrights should be the correct ones. But as said this is not the most urgent issue and priority is low. And sorry if the examples I used were fixed already. I got those examples from Janne Anttila over a month ago and this was just pending in my emails :/ I hope that someone more technical person could reply to Laszlo if license checker bot would be possible or a good idea? -Olli ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On Fri, Mar 1, 2013 at 9:29 PM, Qi Liang liang...@digia.com wrote: tests/prebuild/license in qtqa repo is just for that purpose though I am not sure how it got run on every qt5 module repo. http://qt.gitorious.org/qt/qtqa/trees/master/tests/prebuild/license The license header checker autotest is used by the CI system. You can also run it manually before you commit changes. For example, if I want to manually check qtdeclarative, I do: cd ~/dev/qt5 QT_MODULE_TO_TEST=qtdeclarative qtqa/tests/prebuild/tst_licenses.pl Things to note about the autotest: * It checks that the first few lines of the header match the predefined patterns. The old Nokia copyright line still matches the acceptable pattern, so the script won't complain about those. I can probably fix that if there's sufficient interest. * It checks the text inside the QT_BEGIN_LICENSE/QT_END_LICENSE markers against the reference copies in qtbase/LICENSE.*, so you need to have qtbase in your tree with the correct branch checked out as well as qtqa and the module you want to check. * For each file checked, the script will print a line beginning with ok or not ok depending on the result. When not ok, it will also print some detail about why it failed. For those in Digia, you may also want to have a look in the old non-public mkdist repo which contained the packaging scripts for Qt4.x. In that repo there's a script called bin/replace-licenses.zsh and a small Qt program called replacetags (or maybe replace-tags) that the script calls. This can be used to automatically update the text between the QT_BEGIN_LICENSE and QT_END_LICENSE markers to the current version for the corresponding license type. The script was originally written by Thiago and I later enhanced it to handle license headers in non-C++ files and those embedded inside string literals in programs that generate other source files. (There is one file the script doesn't work on: qtbase/tests/auto/tools/moc/os9-newlines.h. That files has to be carefully updated with a hex editor when the license text changes.) I'd suggest moving that script into the qtqa module and making it use the reference text in qtbase/LICENSE.* instead of the (by now very stale) copies in mkdist. If nobody in Digia has the time to do this, I can do it, but someone in Digia would need to get permission to give me a copy of the code because mkdist was never made public. -- Jason ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On sábado, 2 de março de 2013 10.27.24, Jason McDonald wrote: * For each file checked, the script will print a line beginning with ok or not ok depending on the result. When not ok, it will also print some detail about why it failed. If you don't want to see the ok / not ok lines, simply redirect stdout to /dev/null. The reasons why it failed are printed on stderr. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Copyright changes
On Sat, Mar 2, 2013 at 12:27 AM, Jason McDonald macadd...@gmail.com wrote: cd ~/dev/qt5 QT_MODULE_TO_TEST=qtdeclarative qtqa/tests/prebuild/tst_licenses.pl bash: qtqa/tests/prebuild/tst_licenses.pl: No such file or directory I will take you meant QT_MODULE_TO_TEST=qtdeclarative qtqa/tests/prebuild/license/tst_licenses.pl Yeah, I used this script earlier, but I did not know it is already integrated into the CI. Couldn't this be integrated into a bot rather than CI? It would be nice to know even before pressing the staging button. It does not seem to run long either. * It checks the text inside the QT_BEGIN_LICENSE/QT_END_LICENSE markers against the reference copies in qtbase/LICENSE.*, so you need to have qtbase in your tree with the correct branch checked out as well as qtqa and the module you want to check. Yes, and that is likely the problem for several modules aforementioned unless they copy those into the qt5. However, that is not a clean solution either. Perhaps, qtqa should have the license headers stored on its own, and once there is a need to change it, it is changed there. Then, qtbase and others should be sync'd to that. Laszlo ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
