Re: [Development] Reusing Qt code (or: saving .ico files)

2017-01-13 Thread René J . V . Bertin
Александр Волков wrote: > 13.01.2017 13:58, Александр Волков пишет: >> 13.01.2017 13:52, Konstantin Tokarev пишет: >>> Why not just use QImageWriter? >> QImageWriter doesn't support wrting miltiple images into one file. >> > > Possible fix: https://codereview.qt-project.org/#/c/182255/ Yep,

Re: [Development] Reusing Qt code (or: saving .ico files)

2017-01-13 Thread René J . V . Bertin
On Friday January 13 2017 13:52:36 Konstantin Tokarev wrote: >Why not just use QImageWriter? Because it doesn't append but writes only a single image, the 1st image in the sequence, suprisingly (and I presume not just on Friday the 13th :)) ? R ___

Re: [Development] Reusing Qt code (or: saving .ico files)

2017-01-13 Thread René J . V . Bertin
On Friday January 13 2017 14:01:10 Konstantin Tokarev wrote: Hi, > Alternatively you can import QtIcoHandler from Qt 5.6 which is licensed as > LGPL 2.1 Thanks, that'd be easy, only the license is different, nothing else :) > Why not just use QImageWriter? I understand from CodeReview

Re: [Development] Reusing Qt code (or: saving .ico files)

2017-01-13 Thread Александр Волков
13.01.2017 13:58, Александр Волков пишет: 13.01.2017 13:52, Konstantin Tokarev пишет: Why not just use QImageWriter? QImageWriter doesn't support wrting miltiple images into one file. Possible fix: https://codereview.qt-project.org/#/c/182255/ ___

Re: [Development] Reusing Qt code (or: saving .ico files)

2017-01-13 Thread Александр Волков
13.01.2017 13:52, Konstantin Tokarev пишет: Why not just use QImageWriter? QImageWriter doesn't support wrting miltiple images into one file. I wonder is there a bugreport for it? ___ Development mailing list Development@qt-project.org

Re: [Development] Reusing Qt code (or: saving .ico files)

2017-01-13 Thread Konstantin Tokarev
13.01.2017, 13:29, "René J.V. Bertin" : > Hello, > > Can someone please have a look at the KDE RR below and tell us whether or not > it's OK to include qicohandler.* the way I propose in the patch under review? > There are some whitespace changes and I added a preprocessor