Re: [Development] Reusing Qt code (or: saving .ico files)

[René J . V . Bertin]

Александр Волков wrote:

> 13.01.2017 13:58, Александр Волков пишет:
>> 13.01.2017 13:52, Konstantin Tokarev пишет:
>>> Why not just use QImageWriter?
>> QImageWriter doesn't support wrting miltiple images into one file.
>>
> 
> Possible fix: https://codereview.qt-project.org/#/c/182255/

Yep, that should do the trick: QtIcoHandler always supported writing multiple 
images, it was just not exposed through the QImageWriter API.

Qt is late to catch up with the animage GIF hype! ;)

R.

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Reusing Qt code (or: saving .ico files)

[René J . V . Bertin]

On Friday January 13 2017 13:52:36 Konstantin Tokarev wrote:

>Why not just use QImageWriter?

Because it doesn't append but writes only a single image, the 1st image in the 
sequence, suprisingly (and I presume not just on Friday the 13th :)) ?

R
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Reusing Qt code (or: saving .ico files)

[René J . V . Bertin]

On Friday January 13 2017 14:01:10 Konstantin Tokarev wrote:

Hi,


> Alternatively you can import QtIcoHandler from Qt 5.6 which is licensed as 
> LGPL 2.1

Thanks, that'd be easy, only the license is different, nothing else :)



> Why not just use QImageWriter?

I understand from CodeReview 182255 that I'd have to call QImageWriter::write() 
for each individual image?

If that works cross-platform it would evidently be better.

R.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Reusing Qt code (or: saving .ico files)

[Александр Волков]

13.01.2017 13:58, Александр Волков пишет:

13.01.2017 13:52, Konstantin Tokarev пишет:

Why not just use QImageWriter?

QImageWriter doesn't support wrting miltiple images into one file.



Possible fix: https://codereview.qt-project.org/#/c/182255/
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Reusing Qt code (or: saving .ico files)

[Александр Волков]

13.01.2017 13:52, Konstantin Tokarev пишет:

Why not just use QImageWriter?

QImageWriter doesn't support wrting miltiple images into one file.
I wonder is there a bugreport for it?
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Reusing Qt code (or: saving .ico files)

[Konstantin Tokarev]

13.01.2017, 13:29, "René J.V. Bertin" :
> Hello,
>
> Can someone please have a look at the KDE RR below and tell us whether or not 
> it's OK to include qicohandler.* the way I propose in the patch under review? 
> There are some whitespace changes and I added a preprocessor token to exclude 
> ico read support.
> My understanding of the GPL legalese is that it should be OK but Christoph is 
> right that we have to double-check.
>
> Maybe we all overlooked something and there is another way to create .ico 
> files, without needing to use (and thus include) QtIcoHandler explicitly? I 
> see that the relevant QtBase code is built on Linux and Mac but I cannot tell 
> whether it is also installed (the header isn't in any case).

Why not just use QImageWriter?

>
> Thanks,
> René
>
> ---
> Forwarded message:
> Date: Friday January 13 2017
> From: Christoph Feck 
> Subject: Re: Review Request 129807: proposal: add ksvg2ico
>
> https://git.reviewboard.kde.org/r/129807/#review101968
>
> Someone more experienced with legal matters should review the verbatim 
> inclusion of Qt code; in particular the license header.
>
> - Christoph Feck
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development