Re: [PATCH V4 3/4] mmc: pwrseq: Initial support for the simple MMC power sequence provider

2015-01-28 Thread Javier Martinez Canillas
. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [PATCH V4 1/4] mmc: core: Initial support for MMC power sequences

2015-01-28 Thread Javier Martinez Canillas
the pwrseq_simple driver so on Exynos5250 Snow Chromebook: Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message

Re: [PATCH 2/5] mmc: pwrseq_simple: Extend to support more pins

2015-01-28 Thread Javier Martinez Canillas
linux-mmc? May be we can merge goods in both :-) Sure, I want $subject to be generic enough to be useful for other platforms. On 28/01/15 10:10, Javier Martinez Canillas wrote: Many WLAN attached to a SDIO/MMC interface, needs more than one pin for their reset sequence. For example, is very

Re: [PATCH 01/24] Documentation: DT: document compatible string existence requirement

2015-01-29 Thread Javier Martinez Canillas
will be matching those or not. But since the decision is to warn for all strings in a compatible property even if those are not used, I agree with you that it should be documented. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from

[PATCH v3 5/6] ARM: dts: exynos5250-snow: Enable wifi power-on

2015-01-29 Thread Javier Martinez Canillas
MMC/SDIO slot. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v2: None. Changes since v1: - Remove cap-sdio-irq from mmc3 dev node since is a separate change. Suggested by Arend van Spriel. --- arch/arm/boot/dts/exynos5250-snow.dts | 25

[PATCH v3 6/6] ARM: dts: exynos5250-snow: Add cap-sdio-irq to wifi mmc node

2015-01-29 Thread Javier Martinez Canillas
Enabling SDIO IRQ signalling for the wifi MMC/SDIO slot doubles the transmission transfer rate. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v2: None. Changes since v1: None, new patch. --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed

[PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-01-29 Thread Javier Martinez Canillas
clock. This is the third version of the series that addressed issues pointed out in the previous versions. The series depend on v4 mmc: core: Add support for MMC power sequences: http://comments.gmane.org/gmane.linux.kernel.mmc/30665 Javier Martinez Canillas (6): mmc: pwrseq: Document

[PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-29 Thread Javier Martinez Canillas
is not found. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v2: - Add a clk_enabled bool to struct mmc_pwrseq_simple to track clock gate/ungate since .power_off can be called prior to .pre_power_on. Suggested by Ulf Hansson. - clk_get() does not return

[PATCH v3 3/6] mmc: pwrseq: Document optional clock for the simple power sequence

2015-01-29 Thread Javier Martinez Canillas
Some WLAN chips attached to a SDIO interface, need an external clock to be operational. Since this is very common, extend the simple MMC power sequence DT binding to support an optional clock. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v2: None

[PATCH v3 2/6] mmc: pwrseq_simple: Extend to support more pins

2015-01-29 Thread Javier Martinez Canillas
number, it uses the of_gpio_named_count() since the MMC power sequence is only built when CONFIG_OF is enabled. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Changes since v2: None. Changes since v1

[PATCH v3 1/6] mmc: pwrseq: Document that simple sequence support more than one GPIO

2015-01-29 Thread Javier Martinez Canillas
Many SDIO/MMC attached WLAN chips need more than one ping for their reset sequence. Extend the pwrseq_simple binding to support more than one pin. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v2: None. Changes since v1: - Make the explanation

Re: [PATCH 1/4] mmc: core: add support for hardware reset gpio line

2015-01-29 Thread Javier Martinez Canillas
Hello Marek, On Thu, Jan 29, 2015 at 10:15 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: Also, I wonder whether we could extend the mmc-pwrseq to cover your case? Did you consider that as an option? I didn't consider mmc-pwrseq yet. For me it looked straightforward to I agree with

Re: [PATCH v2 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-29 Thread Javier Martinez Canillas
Hello Ulf, Thanks a lot for your feedback. On 01/29/2015 02:05 PM, Ulf Hansson wrote: struct mmc_pwrseq_simple { struct mmc_pwrseq pwrseq; + struct clk *ext_clk; You need to add a bool, maybe call it clk_enabled; See why below. Ok int nr_gpios; struct

Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-23 Thread Javier Martinez Canillas
Hello Jaehoon, On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Add sd0_rst node to exynos5420-pinctrl.dtsi. (It's used on odroid-xu3 board) It would be good to mention which device needs this pinctrl line. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com ---

Re: [PATCH] ARM: dts: exynos5420: Add maudio power domain

2015-02-09 Thread Javier Martinez Canillas
not introduce any functional change except of visibility of this domain to the system. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Your patch looks good to me, I just have two small comments below. With those changes, feel free to add: Reviewed-by: Javier Martinez Canillas

Re: [PATCH v6] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-03-18 Thread Javier Martinez Canillas
Hello Alim, On Wed, Mar 18, 2015 at 4:08 AM, Alim Akhtar alim.akh...@samsung.com wrote: From: Seungwon Jeon tgih@samsung.com HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards. This also adds RCLK GPIO line, this gpio should be in pull-down

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-03-10 Thread Javier Martinez Canillas
Hello Kukjin, On 02/05/2015 03:45 PM, Javier Martinez Canillas wrote: Hello Andrzej, Thanks a lot for finally finding what was causing the HDMI issue. On 02/05/2015 01:35 PM, Andrzej Hajda wrote: Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs

[PATCH 1/1] OMAPDSS: Correct video ports description file path in DT binding doc

2015-03-07 Thread Javier Martinez Canillas
The doc refers to Documentation/devicetree/bindings/video/video-ports.txt which does not exist. The documentation seems to be outdated and wants to refer to Documentation/devicetree/bindings/graph.txt instead. Suggested-by: Tomi Valkeinen tomi.valkei...@ti.com Signed-off-by: Javier Martinez

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Javier Martinez Canillas
Hello Tony, On Tue, Mar 10, 2015 at 6:35 PM, Tony Lindgren t...@atomide.com wrote: we do have to make sure these wl18xx bindings are future-compatible with the wl12xx ones, but i think the current bindings are pretty much standard (and are actually a subset of the bindings needed by wl12xx),

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Javier Martinez Canillas
Hello Eliad, On Wed, Mar 11, 2015 at 1:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: --- a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts +++ b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts @@ -42,4 +42,13

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
Hello Arnd, On Wed, Mar 11, 2015 at 10:53 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas wrote: What do you mean by parsing here? IIUC there isn't a clock driver for these clocks and are setup directly in the drivers/net/wireless/ti/wl12xx

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-11 Thread Javier Martinez Canillas
Hello Arnd, On Wed, Mar 11, 2015 at 10:51 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 01:34:19 Javier Martinez Canillas wrote: + +static struct wl12xx_platform_data * +wlcore_get_platform_data(struct device *dev) +{ + struct wl12xx_platform_data *pdata

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
Hello Arnd, On Wed, Mar 11, 2015 at 1:40 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 12:34:03 Javier Martinez Canillas wrote: Hello Arnd, On Wed, Mar 11, 2015 at 10:53 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems that all boards in mainline with a WiLink6 part are using internal clocks. So as a first step I think that adding an optional refclock

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
Hello Eliad, On Wed, Mar 11, 2015 at 12:59 PM, Eliad Peller el...@wizery.com wrote: On Wed, Mar 11, 2015 at 3:19 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: But there wasn't a DT binding to describe that so most boards use the same hack which is to define a fake fixed-regulator

Re: [PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-13 Thread Javier Martinez Canillas
, your patch looks good to me so for the arch/arm/boot/dts/omap3-igep00* changes: Acked-by: Javier Martinez Canillas jav...@dowhile0.org Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Javier Martinez Canillas
Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining the platform data through the pdata-quirks. The patch was compile-tested only. You should look at

Re: [PATCH v5 2/3] wl18xx: add basic device-tree support

2015-03-10 Thread Javier Martinez Canillas
Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: When running with device-tree, we no longer have a board file that can set up the platform data for wlcore. Allow this data to be passed from DT. For now, parse only the irq used. Other (optional) properties

Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id

2015-03-31 Thread Javier Martinez Canillas
Choi cw00.c...@samsung.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc

2015-03-31 Thread Javier Martinez Canillas
...@samsung.com Thanks, Chanwoo Choi -- Looks good to me also. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-31 Thread Javier Martinez Canillas
k.kozlow...@samsung.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord

Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-03-03 Thread Javier Martinez Canillas
Hello Kukjin, On 02/06/2015 12:27 PM, Javier Martinez Canillas wrote: Hello Andrzej, On 02/06/2015 11:55 AM, Andrzej Hajda wrote: FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), therefore their clocks should be enabled during power domain switch. Signed-off

Re: [PATCH 1/6] ASoC: max98088: Document DT bindings

2015-02-23 Thread Javier Martinez Canillas
Hello Sylwester, On 02/20/2015 01:12 PM, Sylwester Nawrocki wrote: On 20/02/15 01:36, Andreas Färber wrote: So it seems the mclk is not always set up properly by the kernel, relying on firmware. Who's in charge of setting that clock up? Right, it seems audio is only working due the

Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling

2015-02-23 Thread Javier Martinez Canillas
...@suse.de --- sound/soc/codecs/max98088.c | 24 1 file changed, 24 insertions(+) Looks good. Acked-by: Tushar Behera trbli...@gmail.com Looks good to me as well. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier

Re: [PATCH V4 4/4] mmc: pwrseq_simple: Add support for a reset GPIO pin

2015-01-23 Thread Javier Martinez Canillas
Hello Ulf, On Mon, Jan 19, 2015 at 10:13 AM, Ulf Hansson ulf.hans...@linaro.org wrote: int mmc_pwrseq_simple_alloc(struct mmc_host *host, struct device *dev) { struct mmc_pwrseq_simple *pwrseq; + int ret = 0; pwrseq = kzalloc(sizeof(struct mmc_pwrseq_simple),

Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-23 Thread Javier Martinez Canillas
Hello Sjoerd, On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons sjoerd.sim...@collabora.co.uk wrote: If this pin is used by the Odroid XU3 board, shouldn't be defined in the exynos5422-odroidxu3.dts instead? It's not just used by the XU3 though, it's also hooked up on the peach pi chromebook

Re: [PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-30 Thread Javier Martinez Canillas
Hello Ulf, On 01/30/2015 12:17 PM, Ulf Hansson wrote: }; @@ -39,6 +42,11 @@ static void mmc_pwrseq_simple_pre_power_on(struct mmc_host *host) struct mmc_pwrseq_simple *pwrseq = container_of(host-pwrseq, struct mmc_pwrseq_simple, pwrseq); +

Re: [PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-01-30 Thread Javier Martinez Canillas
Hello Ulf, On 01/30/2015 12:13 PM, Ulf Hansson wrote: Patch #1 extends the simple MMC power sequence DT binding to support more than one GPIO and patch #2 adds the actual implementation. In the same way, patch #3 and #4 extend the simple MMC power sequence DT binding and pwrseq_simple

Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653

2015-04-02 Thread Javier Martinez Canillas
Hello Pavel, I haven't reviewed the patch since I'm not familiar with the hardware but just wanted to point out a couple of things that I spot: On Thu, Apr 2, 2015 at 10:34 PM, Pavel Machek pa...@ucw.cz wrote: We are moving to device tree support on OMAP3, but that currently breaks ADP1653

Re: [PATCH 2/2] ARM: dts: Use last parent for clocks during power domain on/off

2015-04-02 Thread Javier Martinez Canillas
are different than those specified in DTS. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk On an Exynos5420 Peach Pit Chromebook: Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier

Re: [PATCH 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off

2015-04-02 Thread Javier Martinez Canillas
/pm_genpd/pm_genpd_summary and after enabling it again with: $ echo 0 /sys/devices/platform/exynos-drm/graphics/fb0/blank the DISP1 power domain is on again and the display is working correctly. Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier

Re: [PATCH 2/2] ARM: dts: Enable S3C RTC on Trats2, Odroid-U3 and Arndale Octa

2015-04-02 Thread Javier Martinez Canillas
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: Use define for s3c-rtc clock id

2015-04-02 Thread Javier Martinez Canillas
Hello Krzysztof, On 04/02/2015 01:03 PM, Krzysztof Kozlowski wrote: Use a define instead of raw number as a ID for rtc_src clock. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier

Re: [PATCHv4] media: i2c/adp1653: devicetree support for adp1653

2015-04-03 Thread Javier Martinez Canillas
Hello Pavel, On Fri, Apr 3, 2015 at 10:21 AM, Pavel Machek pa...@ucw.cz wrote: Hi! Fixed feedback by Sakari. Please apply, There is no need to ask for patches to be applied IMHO. It is expected that people post patches wanting them to be applied unless there is an RFC prefix in the

Re: [PATCHv7] media: i2c/adp1653: fix includes

2015-04-13 Thread Javier Martinez Canillas
Hello Pali, On Thu, Apr 9, 2015 at 2:59 PM, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 09 April 2015 14:43:59 Javier Martinez Canillas wrote: Please re-spin your previous patch and submit it properly. Best regards, Javier Hi all! What about stopping this meaningless discussion

Re: [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off

2015-04-07 Thread Javier Martinez Canillas
by Andrzej Hajda. This was significant change so I did not add Javier's reviewed/tested tags. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk on an Exynos5420 Peach Pit Chromebook: Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards

Re: [PATCHv7] media: i2c/adp1653: fix includes

2015-04-09 Thread Javier Martinez Canillas
Hello Pavel, On Thu, Apr 9, 2015 at 2:31 PM, Pavel Machek pa...@ucw.cz wrote: Fix includes according to Sebastian. Signed-off-by: Pavel Machek pa...@ucw.cz --- On Thu 2015-04-09 14:19:14, Sebastian Reichel wrote: On Thu, Apr 09, 2015 at 01:29:43PM +0200, Pavel Machek wrote: On Thu

Re: [PATCH 2/2] ARM: dts: exynos4415: Add syscon property to the MIPI DPHY

2015-05-21 Thread Javier Martinez Canillas
; #phy-cells = 1; + syscon = pmu_system_controller; }; pd_cam: cam-power-domain@10024000 { -- Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send

Re: [PATCH 1/2] ARM: dts: exynos4: Remove obsolete MIPI DPHY 'reg' property

2015-05-21 Thread Javier Martinez Canillas
; syscon = pmu_system_controller; }; Indeed, is even removed from the DT binding so this is clearly a left over. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree

Re: [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250

2015-05-21 Thread Javier Martinez Canillas
property as Krzysztof suggested. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH v4 1/8] mfd: cros_ec: Use a zero-length array for command data

2015-06-02 Thread Javier Martinez Canillas
for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou gwen...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org

[PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-02 Thread Javier Martinez Canillas
. Signed-off-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Dmitry Torokhov d...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v3: - Add defines for the EC and PD index constants. - Remove cros_ec_dev_register() and declare

[PATCH v4 8/8] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-02 Thread Javier Martinez Canillas
that the EC has already woken up. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de

[PATCH v4 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-02 Thread Javier Martinez Canillas
as other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he

[PATCH v4 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-02 Thread Javier Martinez Canillas
it will cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-02 Thread Javier Martinez Canillas
the CS mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (1): mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Use a zero-length array for command data mfd: cros_ec: Move protocol helpers out of the MFD driver Stephen Barber (3): mfd

[PATCH v4 5/8] mfd: cros_ec: add bus-specific proto v3 code

2015-06-02 Thread Javier Martinez Canillas
From: Stephen Barber smbar...@chromium.org Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen

[PATCH v4 2/8] mfd: cros_ec: rev cros_ec_commands.h

2015-06-02 Thread Javier Martinez Canillas
rspang...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Acked-by: Lee Jones lee.jo...@linaro.org --- Changes since v3: None

[PATCH v4 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-02 Thread Javier Martinez Canillas
for handling proto v3 packets. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-05 Thread Javier Martinez Canillas
Hello Lee, On 06/05/2015 12:38 PM, Lee Jones wrote: [...] -err = mfd_add_devices(dev, 0, cros_devs, - ARRAY_SIZE(cros_devs), +err = mfd_add_devices(ec_dev-dev, PLATFORM_DEVID_AUTO, ec_cell, 1, NULL, ec_dev-irq, NULL); if

[PATCH v7 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-09 Thread Javier Martinez Canillas
as other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he

[PATCH v7 5/8] mfd: cros_ec: add bus-specific proto v3 code

2015-06-09 Thread Javier Martinez Canillas
From: Stephen Barber smbar...@chromium.org Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen

[PATCH v7 8/8] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-09 Thread Javier Martinez Canillas
transaction, to make sure that the EC has already woken up, if the property has been defined in the DTS. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH v7 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-09 Thread Javier Martinez Canillas
...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Olof Johansson o...@lixom.net --- Changes since v6: - Add Lee Jones Acked-by tag. - Add Olof Johansson Acked-by tag

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-09 Thread Javier Martinez Canillas
Hello Olof, On 06/08/2015 10:46 PM, Olof Johansson wrote: On Fri, Jun 05, 2015 at 11:17:30AM +0100, Lee Jones wrote: On Thu, 04 Jun 2015, Javier Martinez Canillas wrote: From: Gwendal Grignou gwen...@chromium.org Chromebooks can have more than one Embedded Controller so the cros_ec

[PATCH v7 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-09 Thread Javier Martinez Canillas
it will cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH v7 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-09 Thread Javier Martinez Canillas
for handling proto v3 packets. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee

Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-05 Thread Javier Martinez Canillas
Hello Lee, On 06/05/2015 12:17 PM, Lee Jones wrote: On Thu, 04 Jun 2015, Javier Martinez Canillas wrote: From: Gwendal Grignou gwen...@chromium.org Chromebooks can have more than one Embedded Controller so the cros_ec device id has to be incremented for each EC registered. Add a new

Re: [RESEND 1/2] usb: ehci-exynos: Make provision for vdd regulators

2015-06-08 Thread Javier Martinez Canillas
Hello Krzysztof, On Mon, Jun 8, 2015 at 8:52 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: 2015-06-08 15:42 GMT+09:00 Javier Martinez Canillas jav...@dowhile0.org: Hello, On Mon, Jun 8, 2015 at 7:14 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: [...] To summarize my

Re: [RESEND 1/2] usb: ehci-exynos: Make provision for vdd regulators

2015-06-08 Thread Javier Martinez Canillas
Hello, On Mon, Jun 8, 2015 at 7:14 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: [...] To summarize my point of view: 1. Unless Vivek's says otherwise, please give him the credits with proper from field. 2. Issues mentioned in previous mail should be addressed (missing IS_ERR(),

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 06/03/2015 10:53 AM, Lee Jones wrote: On Tue, 02 Jun 2015, Javier Martinez Canillas wrote: From: Gwendal Grignou gwen...@chromium.org Chromebooks can have more than one Embedded Controller so the cros_ec device id has to be incremented

Re: [PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, On 06/03/2015 01:27 PM, Lee Jones wrote: On Wed, 03 Jun 2015, Javier Martinez Canillas wrote: [snip] - err = mfd_add_devices(dev, 0, cros_devs, - ARRAY_SIZE(cros_devs), + if (IS_ENABLED(CONFIG_OF) dev-of_node) + ec_p.ec_name

Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-03 Thread Javier Martinez Canillas
Hello Heiko, On 06/02/2015 11:15 PM, Heiko Stübner wrote: Am Dienstag, 2. Juni 2015, 10:11:03 schrieb Javier Martinez Canillas: Hello, Newer Chromebooks have more than one Embedded Controller (EC) in the system. These additional ECs are connected through I2C with a host EC which is the one

Re: [PATCH v5 7/9] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
Hello Lee, On 06/03/2015 03:49 PM, Lee Jones wrote: [...] int cros_ec_register(struct cros_ec_device *ec_dev) @@ -52,14 +68,39 @@ int cros_ec_register(struct cros_ec_device *ec_dev) cros_ec_query_all(ec_dev); -err = mfd_add_devices(dev, 0, cros_devs, -

[PATCH v5 5/9] mfd: cros_ec: add bus-specific proto v3 code

2015-06-03 Thread Javier Martinez Canillas
From: Stephen Barber smbar...@chromium.org Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen

[PATCH v5 3/9] mfd: cros_ec: Move protocol helpers out of the MFD driver

2015-06-03 Thread Javier Martinez Canillas
as other protocols are supported in the future. So move the communication protocol helpers to its own driver as drivers/platform/chrome/cros_ec_proto.c. Suggested-by: Lee Jones lee.jo...@linaro.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he

[PATCH v5 1/9] mfd: cros_ec: Use a zero-length array for command data

2015-06-03 Thread Javier Martinez Canillas
for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou gwen...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org

[PATCH v5 4/9] mfd: cros_ec: add proto v3 skeleton

2015-06-03 Thread Javier Martinez Canillas
for handling proto v3 packets. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee

[PATCH v5 2/9] mfd: cros_ec: rev cros_ec_commands.h

2015-06-03 Thread Javier Martinez Canillas
rspang...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Acked-by: Lee Jones lee.jo...@linaro.org --- Changes since v4: None

[PATCH v5 9/9] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-03 Thread Javier Martinez Canillas
that the EC has already woken up. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de

[PATCH v5 8/9] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-03 Thread Javier Martinez Canillas
it will cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH v5 0/9] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-03 Thread Javier Martinez Canillas
the CS mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (2): mfd: cros_ec: Add DT property to define ChromeOS EC name mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Use a zero-length array for command data mfd: cros_ec: Move protocol

[PATCH v5 6/9] mfd: cros_ec: Add DT property to define ChromeOS EC name

2015-06-03 Thread Javier Martinez Canillas
Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v4: None, new patch --- Documentation/devicetree/bindings/mfd/cros-ec.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros

[PATCH v5 7/9] mfd: cros_ec: Support multiple EC in a system

2015-06-03 Thread Javier Martinez Canillas
...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de --- Changes since v4: - Use cros-ec-name DT property instead of devname. Suggested by Lee Jones. - Pass PLATFORM_DEVID_AUTO directly to mfd_add_devices(). Suggested

Re: [PATCH 01/11] ARM: dt: Add SPI CS on Samsung Snow board.

2015-06-04 Thread Javier Martinez Canillas
Hello Michal, On Wed, Jun 3, 2015 at 11:26 PM, Michal Suchanek hramr...@gmail.com wrote: Although there is only one choice of chipselect it is necessary to specify it. The driver cannot claim the gpio otherwise. Signed-off-by: Michal Suchanek hramr...@gmail.com ---

[PATCH v6 4/8] mfd: cros_ec: add proto v3 skeleton

2015-06-04 Thread Javier Martinez Canillas
for handling proto v3 packets. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee

[PATCH v6 2/8] mfd: cros_ec: rev cros_ec_commands.h

2015-06-04 Thread Javier Martinez Canillas
rspang...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org Acked-by: Lee Jones lee.jo...@linaro.org --- Changes since v5: None

[PATCH v6 1/8] mfd: cros_ec: Use a zero-length array for command data

2015-06-04 Thread Javier Martinez Canillas
for both output and input data so the maximum of these values should be used to allocate it. Suggested-by: Gwendal Grignou gwen...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Acked-by: Lee Jones lee.jo...@linaro.org

[PATCH v6 0/8] mfd: cros_ec: Add multi EC and proto v3 support

2015-06-04 Thread Javier Martinez Canillas
mfd: cros_ec: spi: Add delay for asserting CS Gwendal Grignou (1): mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Use a zero-length array for command data mfd: cros_ec: Move protocol helpers out of the MFD driver Stephen Barber (3): mfd: cros_ec

[PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system

2015-06-04 Thread Javier Martinez Canillas
...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de --- Changes since v5: - Don't allow to change the device name from DT. Suggested by Lee Jones. - Expand error messages in case of mfd_add_devices() failure. Suggested

[PATCH v6 5/8] mfd: cros_ec: add bus-specific proto v3 code

2015-06-04 Thread Javier Martinez Canillas
From: Stephen Barber smbar...@chromium.org Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber smbar...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Tested-by: Heiko Stuebner he...@sntech.de Reviewed-by: Gwendal Grignou gwen

[PATCH v6 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS

2015-06-04 Thread Javier Martinez Canillas
it will cause a delay equal to the value passed to it to be inserted at the beginning of a transaction. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH v6 8/8] mfd: cros_ec: spi: Add delay for asserting CS

2015-06-04 Thread Javier Martinez Canillas
transaction, to make sure that the EC has already woken up, if the property has been defined in the DTS. Signed-off-by: Alexandru M Stan ams...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Chris Zhong z...@rock-chips.com Signed-off-by: Javier Martinez Canillas javier.marti

Re: [PATCH v2 7/9] ARM: multi_v7_defconfig: Enable support for PWM Regulators

2015-06-25 Thread Javier Martinez Canillas
Hello Lee, On Thu, Jun 25, 2015 at 5:02 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 25 Jun 2015, Javier Martinez Canillas wrote: On Thu, Jun 25, 2015 at 10:42 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 24 Jun 2015, Javier Martinez Canillas wrote: [...] diff --git a/arch/arm

Re: [PATCH v2 7/9] ARM: multi_v7_defconfig: Enable support for PWM Regulators

2015-06-24 Thread Javier Martinez Canillas
Hello Lee, On Wed, Jun 24, 2015 at 3:59 PM, Lee Jones lee.jo...@linaro.org wrote: Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig

Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA

2015-06-24 Thread Javier Martinez Canillas
Hello Paul, On Thu, Jun 25, 2015 at 2:00 AM, Paul Gortmaker paul.gortma...@windriver.com wrote: [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote: On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote: Hi Herbert, On

Re: [PATCH v2 7/9] ARM: multi_v7_defconfig: Enable support for PWM Regulators

2015-06-25 Thread Javier Martinez Canillas
Hello Lee, On Thu, Jun 25, 2015 at 10:42 AM, Lee Jones lee.jo...@linaro.org wrote: On Wed, 24 Jun 2015, Javier Martinez Canillas wrote: [...] diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index f632af0..973 100644 --- a/arch/arm/configs

Re: [PATCH 8/8] dt: cpufreq: st: Provide bindings for ST's CPUFreq implementation

2015-06-23 Thread Javier Martinez Canillas
Hello Lee and Viresh, On Tue, Jun 23, 2015 at 10:38 AM, Lee Jones lee.jo...@linaro.org wrote: On Tue, 23 Jun 2015, Viresh Kumar wrote: On 23-06-15, 08:06, Lee Jones wrote: Over that, this patch should have been present before any other patches using these bindings. I've never heard

Re: [PATCH 1/2] clk: exynos4: Add PCLK_ADC gate clock on Exynos4x12

2015-06-11 Thread Javier Martinez Canillas
Hello Krzysztof, On Thu, Jun 11, 2015 at 2:40 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: W dniu 11.06.2015 o 21:15, Javier Martinez Canillas pisze: Hello Krzysztof, On Thu, Jun 11, 2015 at 12:43 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: W dniu 11.06.2015 o 17:26

Re: [PATCH 1/2] clk: exynos4: Add PCLK_ADC gate clock on Exynos4x12

2015-06-11 Thread Javier Martinez Canillas
Hello Krzysztof, On Thu, Jun 11, 2015 at 12:43 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: W dniu 11.06.2015 o 17:26, Krzysztof Kozlowski pisze: Add proper gate clock for the Analog to Digital Converter (ADC) on Exynos4x12. Signed-off-by: Krzysztof Kozlowski

<    1   2   3   4   5   6   7   8   >