Re: [PATCH 1/3] misc: Add crossbar driver

2013-07-18 Thread Felipe Balbi
Hi, On Thu, Jul 18, 2013 at 10:13:48PM +0530, Sricharan R wrote: > Some socs have a large number of interrupts/dma requests to service > the needs of its many peripherals and subsystems. All of the > requests lines from the subsystems are not needed at the same > time, so they have to be muxed to

Re: [PATCH v6] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-07-15 Thread Felipe Balbi
aham I > Acked-by: Felipe Balbi > Acked-by: Chanwoo Choi > --- > This patch should be applied after all of the extcon patchset will be applied > because this patch has dependency of extcon patch related to DT. > http://goo.gl/Tu3qW > > Changes from v5: > * rebased to 3

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-11 Thread Felipe Balbi
Hi, On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote: > Hi Felipe, > > This is intended to pull down a reset signal line, not to switch power > to the device. I could implement that with the regulator framework > too, but I think that would just be confusing and harder to understand

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-07-09 Thread Felipe Balbi
On Tue, Jul 09, 2013 at 05:34:15PM -0700, Julius Werner wrote: > This patch adds support for a new 'samsung,hsic-reset-gpio' in the > device tree, which will be interpreted as an active-low reset pin during > PHY initialization when it exists. Useful for intergrated HSIC devices > like an SMSC 3503

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-09 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 02:33:58PM +0200, Patel, Satish wrote: > > > Operation: > > > > > > Once the card gets inserted into the slot, user application can > > > initiate activate sequence anytime, it is not mandatory that > > > activation has to be called Immediately. It all depends whether >

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-09 Thread Felipe Balbi
Hi, On Tue, Jul 09, 2013 at 04:23:29AM +0200, Patel, Satish wrote: > > > We have two options over here > > > > > > Option 1: > > > > > > Defining generic api to which can be mapped over multiple phys > > > For smartcard case, I have can thought of following mapping with new > > > generic apis as s

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-08 Thread Felipe Balbi
Hi, On Mon, Jul 08, 2013 at 01:24:49PM +0200, Patel, Satish wrote: [ big snip ] > We have two options over here > > Option 1: > > Defining generic api to which can be mapped over multiple phys > For smartcard case, I have can thought of following mapping with new > generic apis as suggested.

Re: [PATCH v2 3/3] mmc: omap_hsmmc: add PSTATE to debugfs regs_show.

2013-07-08 Thread Felipe Balbi
On Fri, Apr 12, 2013 at 02:38:27PM +0200, Andreas Fenkart wrote: > PSTATE shows current state of data lines. > > Signed-off-by: Andreas Fenkart this looks useful Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital

Re: [PATCH v2 2/3] mmc: omap_hsmmc: debugfs entries for GPIO mode.

2013-07-08 Thread Felipe Balbi
On Fri, Apr 12, 2013 at 02:38:26PM +0200, Andreas Fenkart wrote: > Signed-off-by: Andreas Fenkart -ENODESCRIPTION ?? Also, looking at the patch, I wonder if it really needs to be applied in mainline. Seems like you only needed it to count how many times it went into suspend and we already have g

Re: [PATCH v2 1/3] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

2013-07-08 Thread Felipe Balbi
Hi, On Fri, Apr 12, 2013 at 02:38:25PM +0200, Andreas Fenkart wrote: > Without functional clock the omap_hsmmc module can't forward > SDIO IRQs to the system. This patch reconfigures dat1 line as a > gpio while the fclk is off. It uses regulare SDIO IRQ detection of > the module, while fclk is pre

Re: [PATCH 1/4] usb: gadget: s3c-hsotg: Allow driver instantiation using device tree

2013-07-08 Thread Felipe Balbi
Hi, On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > This patch adds OF match table to the driver to allow instantiating it > using device tree. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park I will take this one only, the others have no dependency on this. cheers

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-04 Thread Felipe Balbi
On Thu, Jul 04, 2013 at 03:25:32PM +0530, Kishon Vijay Abraham I wrote: > On Thursday 04 July 2013 02:51 PM, Patel, Satish wrote: > >Hi, > > > >>-Original Message- > >>From: Balbi, Felipe > >>Sent: Wednesday, July 03, 2013 6:51 PM > >>To: ABRAHAM, KISHON VIJAY > >>Cc: Patel, Satish; grant.l

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Felipe Balbi
On Wed, Jul 03, 2013 at 05:18:14PM +0300, Luciano Coelho wrote: > On Wed, 2013-07-03 at 17:13 +0300, Felipe Balbi wrote: > > Hi, > > > > On Wed, Jul 03, 2013 at 05:03:23PM +0300, Luciano Coelho wrote: > > > diff --git a/arch/arm/mach-omap2/board-4430sdp.c >

Re: [PATCH v3 3/8] wlcore: remove pwr_in_suspend from platform data

2013-07-03 Thread Felipe Balbi
ssed from SDIO to wlcore. > > Signed-off-by: Luciano Coelho Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v3 8/8] wlcore/wl12xx: check if we got correct clock data from DT

2013-07-03 Thread Felipe Balbi
urn with > an error. WiLink7 needs both clocks, if either is not available we > return with an error. > > Signed-off-by: Luciano Coelho Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss

Re: [PATCH v3 5/8] wlcore: add initial device tree support to the sdio module

2013-07-03 Thread Felipe Balbi
> > Signed-off-by: Luciano Coelho Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v3 4/8] wl12xx: use frequency instead of enumerations for pdata clocks

2013-07-03 Thread Felipe Balbi
board files to reflect this. > > Cc: Tony Lindgren > Cc: Sekhar Nori > Signed-off-by: Luciano Coelho Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-dis

Re: [PATCH v3 2/8] wlcore: set irq_flags in the board files instead of hiding behind a quirk

2013-07-03 Thread Felipe Balbi
Hi, On Wed, Jul 03, 2013 at 05:03:23PM +0300, Luciano Coelho wrote: > diff --git a/arch/arm/mach-omap2/board-4430sdp.c > b/arch/arm/mach-omap2/board-4430sdp.c > index 56a9a4f..953f620 100644 > --- a/arch/arm/mach-omap2/board-4430sdp.c > +++ b/arch/arm/mach-omap2/board-4430sdp.c > @@ -703,12 +703,

Re: [PATCH v3 1/8] wl1251: split wl251 platform data to a separate structure

2013-07-03 Thread Felipe Balbi
ed-off-by: Luciano Coelho > Acked-by: Tony Lindgren Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v9 0/8] Generic PHY Framework

2013-07-03 Thread Felipe Balbi
Hi, On Wed, Jul 03, 2013 at 03:35:39PM +0530, Kishon Vijay Abraham I wrote: > On Wednesday 03 July 2013 03:02 PM, Patel, Satish wrote: > >Hi Kishon, > > > >>-Original Message- > >>From: ABRAHAM, KISHON VIJAY > >>Sent: Wednesday, June 26, 2013 5:17 PM > >>To: grant.lik...@linaro.org; t...@a

Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree

2013-07-02 Thread Felipe Balbi
On Tue, Jul 02, 2013 at 11:19:54PM +0300, Luciano Coelho wrote: > On Tue, 2013-07-02 at 18:35 +0300, Felipe Balbi wrote: > > Hi, > > > > On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote: > > > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_fu

Re: [PATCH v2 7/9] wlcore: sdio: add wilink clock providers

2013-07-02 Thread Felipe Balbi
Hi, On Tue, Jul 02, 2013 at 06:34:23PM +0300, Felipe Balbi wrote: > On Tue, Jul 02, 2013 at 05:55:46PM +0300, Luciano Coelho wrote: > > Add refclock and tcxoclock as clock providers in WiLink. These clocks > > are not accesible outside the WiLink module, but they are registered &

Re: [PATCH v2 8/9] wlcore: sdio: get clocks from device tree

2013-07-02 Thread Felipe Balbi
Hi, On Tue, Jul 02, 2013 at 05:55:47PM +0300, Luciano Coelho wrote: > @@ -294,6 +316,8 @@ static int wl1271_probe(struct sdio_func *func, > /* Use block mode for transferring over one block size of data */ > func->card->quirks |= MMC_QUIRK_BLKSZ_FOR_BYTE_MODE; > > + sdio_set_drvd

Re: [PATCH v2 7/9] wlcore: sdio: add wilink clock providers

2013-07-02 Thread Felipe Balbi
> be specified. > > Signed-off-by: Luciano Coelho Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v2 5/9] wlcore: always use one-shot IRQ

2013-07-02 Thread Felipe Balbi
about this a while back :-) Acked-by: Felipe Balbi Still, if you call irq_set_irq_type() on board-file (since DT will do something similar for you anyway) then you can completely drop irq_flags. -- balbi signature.asc Description: Digital signature __

Re: [PATCH v2 4/9] wl12xx: use frequency instead of enumerations for pdata clocks

2013-07-02 Thread Felipe Balbi
Hi, On Tue, Jul 02, 2013 at 05:55:43PM +0300, Luciano Coelho wrote: > diff --git a/drivers/net/wireless/ti/wl12xx/main.c > b/drivers/net/wireless/ti/wl12xx/main.c > index 1c627da..903dcb3 100644 > --- a/drivers/net/wireless/ti/wl12xx/main.c > +++ b/drivers/net/wireless/ti/wl12xx/main.c > @@ -1701

Re: [PATCH v2 2/9] wlcore: use irq_flags in pdata instead of hiding it behind a quirk

2013-07-02 Thread Felipe Balbi
Hi, On Tue, Jul 02, 2013 at 05:55:41PM +0300, Luciano Coelho wrote: > The platform_quirk element in the platform data was used to change the > way the IRQ is triggered. When set, the EDGE_IRQ quirk would change > the irqflags used and treat edge trigger differently from the rest. > > Instead of

Re: [RFC] wlcore: sdio: add wilink clock providers

2013-07-01 Thread Felipe Balbi
Hi, On Mon, Jul 01, 2013 at 10:34:10PM +0300, Luciano Coelho wrote: > diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi > b/arch/arm/boot/dts/omap4-panda-common.dtsi > index 670c3ce..7f061b8 100644 > --- a/arch/arm/boot/dts/omap4-panda-common.dtsi > +++ b/arch/arm/boot/dts/omap4-panda-common

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-28 Thread Felipe Balbi
On Fri, Jun 28, 2013 at 03:13:52PM +0300, Luciano Coelho wrote: > On Fri, 2013-06-28 at 14:41 +0300, Felipe Balbi wrote: > > On Fri, Jun 28, 2013 at 02:22:11PM +0300, Luciano Coelho wrote: > > > On Fri, 2013-06-28 at 13:31 +0300, Luciano Coelho wrote: > > &

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-28 Thread Felipe Balbi
On Fri, Jun 28, 2013 at 02:22:11PM +0300, Luciano Coelho wrote: > On Fri, 2013-06-28 at 13:31 +0300, Luciano Coelho wrote: > > (fixed Mike's address) > > > > On Fri, 2013-06-28 at 11:21 +0100, Mark Rutland wrote: > > > On Fri, Jun 28, 2013 at 10:53:35AM +0100, Luciano Coelho wrote: > > > > On Fri,

Re: [PATCH V2 3/3] video: exynos_dp: Use the generic PHY driver

2013-06-28 Thread Felipe Balbi
NOMEM; > - goto err; > - } > - > -err: > - of_node_put(dp_phy_node); > - > - return ret; > -} > - > -static void exynos_dp_phy_init(struct exynos_dp_device *dp) > -{ > - u32 reg; > - > - reg = __raw_readl(dp->phy_addr)

Re: [PATCH V2 1/3] phy: Add driver for Exynos DP PHY

2013-06-28 Thread Felipe Balbi
On Fri, Jun 28, 2013 at 04:15:32PM +0900, Jingoo Han wrote: > Add a PHY provider driver for the Samsung Exynos SoC DP PHY. > > Signed-off-by: Jingoo Han Now that you fixed Kishon's concerns, this looks pretty good: Acked-by: Felipe Balbi -- balbi signature.asc Descri

Re: [PATCH V2 2/3] ARM: dts: Add DP PHY node to exynos5250.dtsi

2013-06-28 Thread Felipe Balbi
10040720>; > - samsung,enable-mask = <1>; > - }; > + phys = <&dp_phy 0>; phy-cells being 0, means that this would become: phys = <&dp_phy>; > +

Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-27 Thread Felipe Balbi
HI, On Thu, Jun 27, 2013 at 12:24:25PM +0300, Tero Kristo wrote: > On 06/27/2013 11:44 AM, Felipe Balbi wrote: > >Hi, > > > >On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote: > >>+ rc = clk_set_parent(abe_dpll_ref, sys_32k_ck); > >>+ ab

Re: [PATCH 2/4] ARM: OMAP5: clockdomain data: add init file for omap54xx

2013-06-27 Thread Felipe Balbi
Hi, On Thu, Jun 27, 2013 at 11:38:17AM +0300, Tero Kristo wrote: > + rc = clk_set_parent(abe_dpll_ref, sys_32k_ck); > + abe_dpll = clk_get_sys(NULL, "dpll_abe_ck"); should these two lines be swaped ? > + if (!rc) > + rc = clk_set_rate(abe_dpll, OMAP5_DPLL_ABE_DEFFREQ); >

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-27 Thread Felipe Balbi
On Thu, Jun 27, 2013 at 10:37:12AM +0200, Sylwester Nawrocki wrote: > On 06/27/2013 09:52 AM, Felipe Balbi wrote: > > On Wed, Jun 26, 2013 at 05:02:22PM +0200, Sylwester Nawrocki wrote: > >> Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 > >> receiv

Re: [PATCH v3 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-27 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:02:22PM +0200, Sylwester Nawrocki wrote: > Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 > receiver and MIPI DSI transmitter DPHYs. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Felipe Ba

Re: [PATCH v3 2/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

2013-06-27 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:02:23PM +0200, Sylwester Nawrocki wrote: > Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi -- balbi signature.asc Description: Digit

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-27 Thread Felipe Balbi
On Thu, Jun 27, 2013 at 09:47:47AM +0200, Andrzej Hajda wrote: > Hi Felipe, > > On 06/27/2013 08:17 AM, Felipe Balbi wrote: > > On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote: > >> Hi, > >> > >> On 06/25/2013 05:06 PM, Felipe Balbi wr

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 05:00:34PM +0200, Sylwester Nawrocki wrote: > Hi, > > On 06/25/2013 05:06 PM, Felipe Balbi wrote: > >> +static struct platform_driver exynos_video_phy_driver = { > >> > +.probe = exynos_video_phy_probe, > > > > you *must*

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-26 Thread Felipe Balbi
On Wed, Jun 26, 2013 at 02:03:42PM +0200, Sylwester Nawrocki wrote: > On 06/26/2013 01:21 PM, Kishon Vijay Abraham I wrote: > > +static int exynos_video_phy_probe(struct platform_device *pdev) > > +{ > > + struct exynos_video_phy *state; > > + struct device *dev = &

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-26 Thread Felipe Balbi
/phy.txt and the documentation for dt binding can be found at > Documentation/devicetree/bindings/phy/phy-bindings.txt > > Signed-off-by: Kishon Vijay Abraham I > Tested-by: Sylwester Nawrocki looks great to my eyes Acked-by: Felipe Balbi -- balbi si

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-25 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 11:47:13PM +0200, Sylwester Nawrocki wrote: > Hi, > > On 06/25/2013 10:54 PM, Felipe Balbi wrote: > >>>>+static int exynos_video_phy_probe(struct platform_device *pdev) > >>>>> >> +{ > >>>>> >>

Re: [PATCH 1/4] usb: gadget: s3c-hsotg: Allow driver instantiation using device tree

2013-06-25 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 10:57:06PM +0200, Tomasz Figa wrote: > On Tuesday 25 of June 2013 23:46:32 Felipe Balbi wrote: > > On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > > > This patch adds OF match table to the driver to allow instantiating it >

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-25 Thread Felipe Balbi
Hi, On Tue, Jun 25, 2013 at 07:44:52PM +0200, Sylwester Nawrocki wrote: > >> +struct exynos_video_phy { > >> + spinlock_t slock; > >> + struct phy *phys[NUM_PHYS]; > > > > more than one phy ? This means you should instantiate driver multiple > > drivers. Each phy id should call probe again. >

Re: [PATCH 1/4] usb: gadget: s3c-hsotg: Allow driver instantiation using device tree

2013-06-25 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 05:38:23PM +0200, Tomasz Figa wrote: > This patch adds OF match table to the driver to allow instantiating it > using device tree. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park when will this driver get merged into dwc2 ? -- balbi signature.asc Descri

Re: [PATCH v8 1/8] drivers: phy: add generic PHY framework

2013-06-25 Thread Felipe Balbi
Hi, On Tue, Jun 25, 2013 at 11:28:39AM +0530, Kishon Vijay Abraham I wrote: > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > new file mode 100644 > index 000..7abf573 > --- /dev/null > +++ b/include/linux/phy/phy.h on this header, how about adding phy_set_drvdata() and phy_g

Re: [PATCH v8 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-25 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 11:28:46AM +0530, Kishon Vijay Abraham I wrote: > Now that twl4030-usb is adapted to the new generic PHY framework, > *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Felipe B

Re: [PATCH v8 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-06-25 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 11:28:45AM +0530, Kishon Vijay Abraham I wrote: > Now that omap-usb2 is adapted to the new generic PHY framework, > *set_suspend* ops can be removed from omap-usb2 driver. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Felipe Balbi Acked-b

Re: [PATCH v8 6/8] usb: musb: omap2430: use the new generic PHY framework

2013-06-25 Thread Felipe Balbi
;t be removed as of now because musb core uses xceiv.state and > xceiv.otg. Once there is a separate state machine to handle otg, these can be > moved out of xceiv and then we can start using the generic PHY framework. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwe

Re: [PATCH v8 4/8] ARM: OMAP: USB: Add phy binding information

2013-06-25 Thread Felipe Balbi
> Reviewed-by: Sylwester Nawrocki Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v8 5/8] ARM: dts: omap: update usb_otg_hs data

2013-06-25 Thread Felipe Balbi
> The PHY binding information can be found at > Documentation/devicetree/bindings/phy/phy-bindings.txt > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Felipe Balbi Acked-by: Felipe Balbi -- balbi signature.asc Descri

Re: [PATCH v8 3/8] usb: phy: twl4030: use the new generic PHY framework

2013-06-25 Thread Felipe Balbi
get rid of the usb phy library. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Felipe Balbi I'll add an Acked-by here: Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing li

Re: [PATCH v8 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-25 Thread Felipe Balbi
e completely removed > because OTG is intertwined with PHY and moving to the new framework > will break OTG. Once we have a separate OTG state machine, we > can get rid of the USB PHY library. > > Signed-off-by: Kishon Vijay Abraham I > Reviewed-by: Sylwester Nawrocki Acke

Re: [PATCH v2 5/5] ARM: Samsung: Remove MIPI PHY setup code

2013-06-25 Thread Felipe Balbi
SIM (not any upstream currently) it should use the generic > PHY API to bind the PHYs to respective PHY consumer drivers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park pretty cool stuff Acked-by: Felipe Balbi -- balbi signature.asc Descri

Re: [PATCH v2 4/5] exynos4-is: Use generic MIPI CSIS PHY driver

2013-06-25 Thread Felipe Balbi
Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v2 3/5] video: exynos_mipi_dsim: Use generic PHY driver

2013-06-25 Thread Felipe Balbi
> > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park this is awesome :-) Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-25 Thread Felipe Balbi
Hi, On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote: > +enum phy_id { > + PHY_CSIS0, > + PHY_DSIM0, > + PHY_CSIS1, > + PHY_DSIM1, > + NUM_PHYS please prepend these with EXYNOS_PHY_ or EXYNOS_MIPI_PHY_ > +struct exynos_video_phy { > + spinlock_t slock; >

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-25 Thread Felipe Balbi
On Tue, Jun 25, 2013 at 02:56:10PM +0300, Luciano Coelho wrote: > On Tue, 2013-06-25 at 14:12 +0300, Felipe Balbi wrote: > > On Tue, Jun 25, 2013 at 11:35:30AM +0300, Luciano Coelho wrote: > > > +- tcxoclock: the internal WLAN TCXO clock frequency (required for > > &

Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

2013-06-25 Thread Felipe Balbi
Hi, On Tue, Jun 25, 2013 at 11:35:30AM +0300, Luciano Coelho wrote: > Add device tree bindings documentation for the TI WiLink modules. > Currently only the WLAN part of the WiLink6, WiLink7 and WiLink8 > modules is supported. > > Signed-off-by: Luciano Coelho > --- > > I created a new director

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-24 Thread Felipe Balbi
On Mon, Jun 24, 2013 at 09:27:20PM +0200, Sylwester Nawrocki wrote: > Hi, > > On 06/18/2013 11:49 AM, Felipe Balbi wrote: > > On Mon, Jun 17, 2013 at 12:16:35PM +0200, Sylwester Nawrocki wrote: > >> I have already used this API for our MIPI CSI-2/DSIM DPHYs driver, >

Re: [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-23 Thread Felipe Balbi
Hi, On Mon, Jun 24, 2013 at 11:01:56AM +0530, Kishon Vijay Abraham I wrote: > >>@@ -397,9 +407,10 @@ static int omap2430_musb_init(struct musb *musb) > >>if (glue->status != OMAP_MUSB_UNKNOWN) > >>omap_musb_set_mailbox(glue); > >> > >>- usb_phy_init(musb->xceiv); > >>+ phy_init

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 08:25:00PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 18 June 2013 06:05 PM, Felipe Balbi wrote: > >Hi, > > > >On Tue, Jun 18, 2013 at 04:43:44PM +0530, Kishon Vijay Abraham I wrote: > >>>On Tue, Jun 18, 2013 at 0

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 04:43:44PM +0530, Kishon Vijay Abraham I wrote: > >On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote: > >>On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: > >>>On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vija

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:34:36PM +0530, Kishon Vijay Abraham I wrote: > On Tuesday 18 June 2013 03:14 PM, Felipe Balbi wrote: > >On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vijay Abraham I wrote: > >>In order for controllers to get PHY in case of non dt boot, t

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:26:23PM +0530, Kishon Vijay Abraham I wrote: > >>>On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: > @@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device > *pdev) > otg->start_srp = omap_usb_sta

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-18 Thread Felipe Balbi
Hi, On Mon, Jun 17, 2013 at 12:16:35PM +0200, Sylwester Nawrocki wrote: > I have already used this API for our MIPI CSI-2/DSIM DPHYs driver, > the RFC patch series can be found at [1]. > > Thanks, > Sylwester > > [1] http://www.spinics.net/lists/arm-kernel/msg251666.html one comment to that ser

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 03:19:03PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 18 June 2013 03:10 PM, Felipe Balbi wrote: > >Hi, > > > >On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: > >>@@ -159,6 +191,12

Re: [PATCH v7 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Thu, Jun 13, 2013 at 02:13:57PM +0530, Kishon Vijay Abraham I wrote: > Use the generic PHY framework API to get the PHY. The usb_phy_set_resume > and usb_phy_set_suspend is replaced with power_on/get_sync and > power_off/put_sync to align with the new PHY framework. > > musb->xceiv can't b

Re: [PATCH v7 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-06-18 Thread Felipe Balbi
On Thu, Jun 13, 2013 at 02:13:58PM +0530, Kishon Vijay Abraham I wrote: > Now that omap-usb2 is adapted to the new generic PHY framework, > *set_suspend* ops can be removed from omap-usb2 driver. > > Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi -- balbi s

Re: [PATCH v7 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-06-18 Thread Felipe Balbi
On Thu, Jun 13, 2013 at 02:13:59PM +0530, Kishon Vijay Abraham I wrote: > Now that twl4030-usb is adapted to the new generic PHY framework, > *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. > > Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi

Re: [PATCH v7 6/9] ARM: dts: omap: update usb_otg_hs data

2013-06-18 Thread Felipe Balbi
> The PHY binding information can be found at > Documentation/devicetree/bindings/phy/phy-bindings.txt > > Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree

Re: [PATCH v7 5/9] ARM: OMAP: USB: Add phy binding information

2013-06-18 Thread Felipe Balbi
On Thu, Jun 13, 2013 at 02:13:55PM +0530, Kishon Vijay Abraham I wrote: > In order for controllers to get PHY in case of non dt boot, the phy > binding information (phy device name) should be added in the platform > data of the controller. > > Signed-off-by: Kishon Vijay Abraham I I would rather

Re: [PATCH v7 4/9] usb: phy: twl4030: twl4030 shouldn't be subsys_initcall

2013-06-18 Thread Felipe Balbi
On Thu, Jun 13, 2013 at 02:13:54PM +0530, Kishon Vijay Abraham I wrote: > Changed the inticall from subsys_initcall to module_init for > twl4030-usb. > > Signed-off-by: Kishon Vijay Abraham I not part of the series, should be sent separately. I'll queue this one for v3.12 once v3.11-rc1 is tagge

Re: [PATCH v7 3/9] usb: phy: twl4030: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
get rid of the usb phy library. > > Signed-off-by: Kishon Vijay Abraham I Reviewed-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v7 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Thu, Jun 13, 2013 at 02:13:52PM +0530, Kishon Vijay Abraham I wrote: > @@ -159,6 +191,12 @@ static int omap_usb2_probe(struct platform_device *pdev) > otg->start_srp = omap_usb_start_srp; > otg->phy= &phy->phy; > > + pm_runtime_enable(phy->dev); e

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-18 Thread Felipe Balbi
Hi, On Thu, Jun 13, 2013 at 02:13:51PM +0530, Kishon Vijay Abraham I wrote: > +struct phy_provider *of_phy_provider_register(struct device *dev, > + struct module *owner, struct phy * (*of_xlate)(struct device *dev, > + struct of_phandle_args *args)) I would rename this to __of_phy_provid

Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support

2013-06-15 Thread Felipe Balbi
Hi, On Fri, Jun 14, 2013 at 06:43:51PM -0500, Joel A Fernandes wrote: > > > >> I just doublechecked MMC rootfs on bone and evmsk as it's the standard > > > >> smoke test. My EVM is intermittent now so trying to coax it to power > > up > > > >> to reverify. > > > >> > > > > > > > > Matt, > > > > >

Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support

2013-06-14 Thread Felipe Balbi
Hi, On Fri, Jun 14, 2013 at 02:54:33PM -0500, Joel A Fernandes wrote: > Hi Tony, Vaibhav, > > >> I just doublechecked MMC rootfs on bone and evmsk as it's the standard > >> smoke test. My EVM is intermittent now so trying to coax it to power up > >> to reverify. > >> > > > > Matt, > > > > Your br

Re: [PATCH 1/7] USB: add devicetree helpers for determining dr_mode and phy_type

2013-06-04 Thread Felipe Balbi
.spinics.net/lists/linux-usb/msg86906.html heh, it's so difficult to take vacations :-p I think this patch is good to go. Acked-by: Felipe Balbi > > > Signed-off-by: Michael Grzeschik > > > Signed-off-by: Marc Kleine-Budde > > >

Re: [PATCH 0/3] palmas usb driver

2013-05-29 Thread Felipe Balbi
Hi, On Wed, May 29, 2013 at 11:36:01AM +0530, Kishon Vijay Abraham I wrote: > Hi Felipe, > > On Tuesday 28 May 2013 11:05 PM, Felipe Balbi wrote: > >On Fri, May 24, 2013 at 08:01:33PM +0530, Kishon Vijay Abraham I wrote: > >>This patch series adds driver for palmas usb

Re: [PATCH 0/3] palmas usb driver

2013-05-28 Thread Felipe Balbi
On Fri, May 24, 2013 at 08:01:33PM +0530, Kishon Vijay Abraham I wrote: > This patch series adds driver for palmas usb which is used to detect > attach/detach events of usb device and usb host. > > [PATCH v5 2/3] extcon: Palmas Extcon Driver which was sent previously > is added in this patch serie

Re: [PATCH 3/7] USB: gadget: atmel_usba: add DT support

2013-05-23 Thread Felipe Balbi
On Mon, May 20, 2013 at 06:25:56PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > Allow to compile the driver all the time if AT91 enabled. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Nicolas Ferre > Cc: linux-...@vger.kernel.org Acked-by: Felipe Ba

Re: [PATCH 1/7] USB: gadget: atmel_usba: move global struct usba_ep usba_ep to struct usba_udc

2013-05-23 Thread Felipe Balbi
On Mon, May 20, 2013 at 06:25:54PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > so we can have multiple usb gadget instance > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Nicolas Ferre > Cc: linux-...@vger.kernel.org Acked-by: Felipe Balbi -- balbi

Re: [PATCH 2/7] USB: gadget: atmel_usba: allow multi instance

2013-05-23 Thread Felipe Balbi
On Mon, May 20, 2013 at 06:25:55PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > drop static struct usba_udc the_udc > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > Cc: Nicolas Ferre > Cc: linux-...@vger.kernel.org Acked-by: Felipe Balbi > --- > drivers/usb/ga

Re: [PATCH 3/5] gpio/omap: optimise interrupt service routine

2013-04-05 Thread Felipe Balbi
, instead of checking every bit use the __ffs() function, > which returns the location of the first set bit, to find all the set > bits. > > This optimisation was suggested-by and developed in collaboration > with Felipe Balbi. > > Cc: Felipe Balbi > > Signed-off-by: J

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-04 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 05:54:11PM -0600, Stephen Warren wrote: > struct phy { > struct device *dev; > struct module *owner; > int (*init)(struct phy *phy); > int (*exit)(struct phy *phy); > int (*suspend)(struct phy *phy); > int (*resume)(st

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 02:55:47PM +, Arnd Bergmann wrote: > On Wednesday 03 April 2013, Felipe Balbi wrote: > > const ? Maybe provide a: > > > > #define DEFINE_PHY_OPS(name)\ > > const struct phy_ops #name_phy_ops = { > > > > macro ? This wil

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Felipe Balbi
Hi, On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote: > + ret = -EINVAL; > + goto err0; > + } > + > + if (!phy_class) > + phy_core_init(); > >>> > >>>why don't you setup the class on module_init ? Then this would be a > >>>terri

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Felipe Balbi
hi, On Wed, Apr 03, 2013 at 07:48:42PM +0530, Kishon Vijay Abraham I wrote: > >>+struct phy *of_phy_xlate(struct phy *phy, struct of_phandle_args *args) > >>+{ > >>+ return phy; > >>+} > >>+EXPORT_SYMBOL_GPL(of_phy_xlate); > > > >so you get a PHY and just return it ? What gives ?? (maybe I skipp

Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 06:23:50PM +0530, Kishon Vijay Abraham I wrote: > Used the generic PHY framework API to create the PHY. omap_usb2_suspend > is split into omap_usb_suspend and omap_usb_resume in order to align > with the new framework. > > However using the old USB PHY library cannot be com

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Felipe Balbi
On Wed, Apr 03, 2013 at 06:23:49PM +0530, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of APIs for the PHY drivers to > create/destroy a PHY and APIs for the PHY users to obtain a reference to the > PHY with or without using phandle. To obtain a reference to the PHY without > us

Re: [PATCH v4 0/6] support other fsl SoCs with usbmisc + small fixes

2013-03-26 Thread Felipe Balbi
Hi, On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote: > > http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-phy > > 4414a59 Merge 'v3.9/topic/usb-phy' into usb-3.9 > > a806027 usb: otg: mxs-phy: remove clkgate/sftrst clearing > > 026881b usb: otg: mxs-phy: Improve mxs ph

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Felipe Balbi
Hi, On Tue, Mar 26, 2013 at 03:58:41PM +0530, Laxman Dewangan wrote: > On Tuesday 26 March 2013 03:51 PM, Felipe Balbi wrote: > >* PGP Signed by an unknown key > > > >Hi, > > > >On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote: > >>>>&

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Felipe Balbi
Hi, On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote: > >>> From: Graeme Gregory > >>> > >>> This is the driver for the OTG transceiver built into the Palmas > >>> chip. It > >>> handles the various USB OTG events that can be generated by cable > >>> insertion/removal. > >>> > >>> S

Re: [PATCH v3] USB: PHY: Palmas USB Transceiver Driver

2013-03-26 Thread Felipe Balbi
Hi, On Tue, Mar 26, 2013 at 11:33:44AM +0530, Kishon Vijay Abraham I wrote: > >>+static int palmas_usb_write(struct palmas *palmas, unsigned int reg, > >>+ unsigned int data) > >>+{ > >>+ unsigned int addr; > >>+ int slave; > >>+ > >>+ slave = PALMAS_BASE_TO_SLAVE(P

Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-03-20 Thread Felipe Balbi
On Wed, Mar 20, 2013 at 05:47:46PM +0530, Venu Byravarasu wrote: > > -Original Message- > > From: kishon [mailto:kis...@ti.com] > > Sent: Wednesday, March 20, 2013 4:53 PM > > To: Venu Byravarasu > > Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; > > ba...@ti.com; linux-...@vger

Re: [PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 11:36:00AM +0530, Vivek Gautam wrote: > >> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > >> calls as required by common clock framework. > >> > >> Signed-off-by: Vivek Gautam > &

Re: [PATCH 11/12] USB: ehci-omap: Try to get PHY even if not in PHY mode

2013-03-14 Thread Felipe Balbi
On Tue, Mar 12, 2013 at 11:57:56AM -0400, Alan Stern wrote: > On Tue, 12 Mar 2013, Roger Quadros wrote: > > > Even when not in PHY mode, the USB device on the port (e.g. HUB) > > might need resources like RESET which can be modelled as a PHY > > device. So try to get the PHY device in any case. >

Re: [PATCH 3/6] mfd: omap-usb-host: Actually update hostconfig

2013-03-14 Thread Felipe Balbi
t; Signed-off-by: Roger Quadros makes sense :-) Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

  1   2   3   4   >